update "rollout_max_batch_size" to replace "max_concurrent" for user settings #1225
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YanhuiDua
force-pushed
the
update_rollout_worker
branch
from
7a90af8 to
f0bc0f8
Compare
YanhuiDua
changed the title
hhaAndroid
approved these changes
Nov 7, 2025
hhaAndroid
reviewed
Nov 7, 2025
tests/ray/test_rollout.py
Outdated
| ] | ||
| self.dataloader_cfg = DataloaderConfig( | ||
| pack_max_length=self.max_prompt_length, | ||
| pack_max_length=self.max_prompt_length+self.max_response_length, |
YanhuiDua
force-pushed
the
update_rollout_worker
branch
from
2890ff6 to
e7b7f5b
Compare
Contributor
|
rollout worker的http_concurrency需要能够大于rollout_max_batch_size，现在还是根据rollout_max_batch_size算的 |
Contributor
max_concurrent和http_concurrency可以绑定，这两个参数是客户端的请求数，而rollout_max_batch_size是推理引擎端的参数，这二者需要分开配置，否则GPU功率打不满 |
CyCle1024
reviewed
Nov 10, 2025
xtuner/v1/ray/config/worker.py
Outdated
| api_key (Optional[Union[List[str], str]]): API keys for rollout service. | ||
| Supports single key or list of keys. Defaults to None. | ||
| api_key (Optional[Union[List[str], str]]): API keys for rollout service. åSupports single key or list of keys. Defaults to None. |
Collaborator
There was a problem hiding this comment.
fix typo before supports
Collaborator
Author
done, 通过 ttp_concurrency = config.rollout_max_batch_size_per_instance * config.allow_over_concurrency_ratio 来配置 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
用户配置并发度的方式为以rollout_max_batch_per_instance为基准，从而配置数据流等并发度。配置文档见 xtuner/docs/zh_cn/rl/advanced_tutorial/efficiency.md
可能的几种情况如下：