Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pick_block event for smart glasses #80

Open
superjaja05 opened this issue May 1, 2024 · 9 comments
Open

pick_block event for smart glasses #80

superjaja05 opened this issue May 1, 2024 · 9 comments
Assignees
Labels
area-SmartGlasses SmartGlasses relative

Comments

@superjaja05
Copy link

Describe your idea

I'd like to have a "pick_block" event that would trigger when a player (in this case, the inventory manager's owner) uses the "Pick Block" keybind on something

For example, it would allow to automatically grab the blocks from a ME system, then push it into the player's hand using inventory manager

I think the event values should look like this:
event_name <string>,
block_id <string> or block_data <table>,
is_present <bool> (this would be true if the block is already in the player's inventory/hand/backpack (if soph backpack+refill upgrade) etc, and false if not present),

Describe alternatives you've considered if any

Couldn't really think of anything else that would be as practical as this

Additional context

No response

Linked Issues

No response

@zyxkad zyxkad added area-Detectors Player/Envionment detector or Geo Scanner / NBT reader area-SmartGlasses SmartGlasses relative area-InvManager Inventory manager and removed area-SmartGlasses SmartGlasses relative area-Detectors Player/Envionment detector or Geo Scanner / NBT reader labels May 1, 2024
@zyxkad zyxkad added area-SmartGlasses SmartGlasses relative and removed area-InvManager Inventory manager labels Jul 22, 2024
@zyxkad
Copy link
Collaborator

zyxkad commented Jul 22, 2024

This should be implemented on smart glasses better than inventory manager

@superjaja05
Copy link
Author

No i think it should be on the inventory manager, since the main use of picking blocks is putting them in the inventory anyway, and smart glasses aren't implemented yet

Smart glass would add a pointless layer of complexity, requiring the glasses to send out a signal to an external computer to do the inventory stuff

@zyxkad
Copy link
Collaborator

zyxkad commented Jul 24, 2024

inventoryManager is mainly used for operate inventories but not detecting player actions.
where smartglasses will be able to check keybinds and the block looking for, and makes more sense.

The complexity or limit is also the fun of programming imo

@superjaja05
Copy link
Author

Well i'd rather see such a useful feature sooner than later, and locking it behind something that doesn't exist yet is not great for that
Even if its later moved to smartglasses, i think it'd be better to have it on inv managers until then

And keybinds wouldn't be good enough, a real "pick_block" event directly interacting with the pick block feature would be a lot better here
Some things have special interactions with pick-block button, for example Create's copycat blocks gives you the camouflage block, not the copycat itself (unless sneaking)
with mobs it selects the spawn egg,
with item frames it selects the framed item etc

Sure people could do their own compat, but you just end up with a 10mb program from having to add special exceptions for every single mods with special pick-block interactions and every single mobs with abnormal spawn eggs etc

@zyxkad
Copy link
Collaborator

zyxkad commented Jul 24, 2024

And keybinds wouldn't be good enough, a real "pick_block" event directly interacting with the pick block feature would be a lot better here

Yes this is a reasonable feature to smartglass (but should be on with the keybind upgrade).
So the only difference is you need to forward the pick_block event from smartglass to your base, through websocket or wireless modem.

@zyxkad
Copy link
Collaborator

zyxkad commented Jul 24, 2024

Well i'd rather see such a useful feature sooner than later, and locking it behind something that doesn't exist yet is not great for that
Even if its later moved to smartglasses, i think it'd be better to have it on inv managers until then

In fact we are stopping add features to 0.7 (tho pick_block should not be a big deal, but we'll see if we have time). 0.8 is a little bit far yes, but you can compile your own version (and use at your own risk)

@superjaja05
Copy link
Author

The main issue with adding it to smartglasses is that it will take much longer to get implemented because now it relies on another much more complicated feature to add. Instead of just temporarily adding it to the inv manager until smart glasses are released properly.

And "compiling your own version" isn't really an option, lots of people play on servers including me, so installing an unstable version of a mod is not possible.

@zyxkad
Copy link
Collaborator

zyxkad commented Jul 24, 2024

The main issue with adding it to smartglasses is that it will take much longer to get implemented because now it relies on another much more complicated feature to add.

Yes, I can see your point. However, I can tell that the main framework of smartglasses is almost done. And a fact is, any features did not implemented in 0.7 will eventually adds to 0.8 or later, that will only be released when smartglasses is done :/

Instead of just temporarily adding it to the inv manager until smart glasses are released properly.

Temporarily add a feature is not an option, we should keep the backward compatibility as much as possible.

@SirEndii SirEndii moved this to In Progress in Advanced Peripherals Nov 21, 2024
@SirEndii SirEndii moved this from In Progress to Todo in Advanced Peripherals Nov 21, 2024
@SirEndii SirEndii modified the milestones: 0.7.x, 0.8r Nov 21, 2024
@SirEndii SirEndii moved this to Backlog in 0.8/1.0 Backlog Jan 15, 2025
@zyxkad zyxkad changed the title pick_block event for inventory manager pick_block event for smart glass Jan 17, 2025
@zyxkad zyxkad changed the title pick_block event for smart glass pick_block event for smart glasses Jan 17, 2025
@zyxkad zyxkad self-assigned this Jan 17, 2025
@zyxkad zyxkad moved this from Backlog to In progress in 0.8/1.0 Backlog Jan 17, 2025
@zyxkad zyxkad assigned SirEndii and unassigned zyxkad Jan 18, 2025
@zyxkad zyxkad moved this from In progress to Backlog in 0.8/1.0 Backlog Jan 18, 2025
@zyxkad
Copy link
Collaborator

zyxkad commented Jan 19, 2025

related #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-SmartGlasses SmartGlasses relative
Projects
Status: Backlog
Development

No branches or pull requests

3 participants