make namespace-scope constexpr variables inline in headers

ndgrigorian · ndgrigorian · commit c6bc9904b051 · 2025-06-05T16:22:20.000-07:00
this gives these constants external linkage and prevents duplication
diff --git a/dpctl/tensor/libtensor/include/kernels/alignment.hpp b/dpctl/tensor/libtensor/include/kernels/alignment.hpp
@@ -30,7 +30,7 @@ namespace kernels
 namespace alignment_utils
 {
 
-static constexpr std::size_t required_alignment = 64UL;
+inline constexpr std::size_t required_alignment = 64UL;
 
 template <std::uintptr_t alignment, typename Ptr> bool is_aligned(Ptr p)
 {
diff --git a/dpctl/tensor/libtensor/include/utils/type_dispatch_building.hpp b/dpctl/tensor/libtensor/include/utils/type_dispatch_building.hpp
@@ -56,7 +56,7 @@ enum class typenum_t : int
     CFLOAT,
     CDOUBLE, // 13
 };
-constexpr int num_types = 14; // number of elements in typenum_t
+inline constexpr int num_types = 14; // number of elements in typenum_t
 
 template <typename funcPtrT,
           template <typename fnT, typename D, typename S>
diff --git a/dpctl/tensor/libtensor/include/utils/type_utils.hpp b/dpctl/tensor/libtensor/include/utils/type_utils.hpp
@@ -51,7 +51,7 @@ struct is_complex<
 {
 };
 
-template <typename T> constexpr bool is_complex_v = is_complex<T>::value;
+template <typename T> inline constexpr bool is_complex_v = is_complex<T>::value;
 
 template <typename dstTy, typename srcTy> dstTy convert_impl(const srcTy &v)
 {

Original file line number	Diff line number	Diff line change
`@@ -30,7 +30,7 @@ namespace kernels`
`30`	`30`	`namespace alignment_utils`
`31`	`31`	`{`
`32`	`32`
`33`		`-static constexpr std::size_t required_alignment = 64UL;`
	`33`	`+inline constexpr std::size_t required_alignment = 64UL;`
`34`	`34`
`35`	`35`	`template <std::uintptr_t alignment, typename Ptr> bool is_aligned(Ptr p)`
`36`	`36`	`{`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ struct is_complex<`
`51`	`51`	`{`
`52`	`52`	`};`
`53`	`53`
`54`		`-template <typename T> constexpr bool is_complex_v = is_complex<T>::value;`
	`54`	`+template <typename T> inline constexpr bool is_complex_v = is_complex<T>::value;`
`55`	`55`
`56`	`56`	`template <typename dstTy, typename srcTy> dstTy convert_impl(const srcTy &v)`
`57`	`57`	`{`