[MOB-8866] Start SDK from JS only (#704)

* Start SDK from JS only

* Update CHANGELOG

* Update README

* Update CHANGELOG.md

Co-authored-by: Ali Abdelfattah <[email protected]>

Author: TheBuggedYRN

CHANGELOG.md

@@ -1,10 +1,11 @@
 ## master
 
+* Breaking: Adds the ability to initialize the Android SDK from JavaScript. Check the migration guide referenced in our README
+* Breaking: Removes the deprecated APIs. Check the migration guide referenced in our README
 * Adds the ability to opt out of iOS source maps auto upload through the INSTABUG_SOURCEMAPS_UPLOAD_DISABLE env variable
 * Adds dynamic entry file support through the INSTABUG_ENTRY_FILE env variable
 * Fixes an issue with setRequestFilterExpression API not working with Hermes
 * Fixes an issue with swipe invocation event not working on Android
-* Breaking: Removes the deprecated APIs. For the full list, check PR #703
 
 ## 10.13.0 (2022-03-17)
 

InstabugSample/android/app/src/main/java/com/instabugsample/MainApplication.java

@@ -9,7 +9,6 @@
 import com.facebook.react.ReactPackage;
 import com.facebook.soloader.SoLoader;
 import java.lang.reflect.InvocationTargetException;
-import com.instabug.reactlibrary.RNInstabugReactnativePackage;
 
 import java.util.List;
 
@@ -45,12 +44,6 @@ public ReactNativeHost getReactNativeHost() {
   @Override
   public void onCreate() {
     super.onCreate();
-     new RNInstabugReactnativePackage.Builder("2c63627b9923e10eee2c8abf92e6925f", MainApplication.this)
-            .setInvocationEvent("button")
-            .setPrimaryColor("#1D82DC")
-            .setFloatingEdge("left")
-            .setFloatingButtonOffsetFromTop(250)
-            .build();
     SoLoader.init(this, /* native exopackage */ false);
     initializeFlipper(this, getReactNativeHost().getReactInstanceManager());
   }

README.md

@@ -44,56 +44,26 @@ Updating to a new version? Check the [Update Guide](#update-guide) before bumpin
 
 ## Initializing Instabug
 
- To start using Instabug, import it as follows.
+To start using Instabug, import it as follows, then initialize it in the `constructor` or `componentWillMount`. This line will let the SDK work with the default behavior. The SDK will be invoked when the device is shaken. You can customize this behavior through the APIs.
 
 ```javascript
 import Instabug from 'instabug-reactnative';
+
+Instabug.start('APP_TOKEN', [Instabug.invocationEvent.shake]);
 ```
-### iOS
-- Initialize it in the `constructor` or `componentWillMount`. This line will let the Instabug SDK work with the default behavior. The SDK will be invoked when the device is shaken. You can customize this behavior through the APIs.
 
-    ```javascript
-    Instabug.start('IOS_APP_TOKEN', [Instabug.invocationEvent.shake]);
-    ```
-### Android
-- Open `android/app/src/main/java/[...]/MainApplication.java`
-    * Make sure to import the package class:  
-    `import com.instabug.reactlibrary.RNInstabugReactnativePackage;`
-    * **For React Native >= 0.60**   
-   Add the integration code to the `onCreate()` method like the below snippet. 
-
-       ```java
-        @Override
-        public void onCreate() {
-            super.onCreate();
-            new RNInstabugReactnativePackage
-                .Builder("APP_TOKEN", MainApplication.this)
-                .setInvocationEvent("shake")
-                .setPrimaryColor("#1D82DC")
-                .setFloatingEdge("left")
-                .setFloatingButtonOffsetFromTop(250)
-                .build();
-        }
-      ```
-    * **For React Native < 0.60**  
-   You should find the `getPackages()` method looks like the below snippet. You just need to add your Android app token. 
-
-        ```javascript
-        @Override
-        protected List<ReactPackage> getPackages() {
-            return Arrays.<ReactPackage>asList(
-                new MainReactPackage(),
-                new RNInstabugReactnativePackage.Builder("YOUR_APP_TOKEN", MainApplication.this)
-                .setInvocationEvent("shake")
-                .setPrimaryColor("#1D82DC")
-                .setFloatingEdge("left")
-                .setFloatingButtonOffsetFromTop(250)
-                .build()
-            );
-        }
-        ```
-    * You can change the invocation event from here, simply by replacing the `"shake"` with any of the following `"button"`, `"none"`, `"screenshot"`, or `"swipe"`. You can change the primary color by replacing the `"#1D82DC"` with any color of your choice.
-   In the case that you are using the floating button as an invocation event, you can change the floating button edge and the floating button offset using the last two methods, by replacing `"left"` to `"right"`, and by changing the offset number. 
+**For React Native < 0.60 on Android**  
+You should find the `getPackages()` method looks like the below snippet. You just need to add your Android app token. 
+
+```java
+@Override
+protected List<ReactPackage> getPackages() {
+    return Arrays.<ReactPackage>asList(
+        new MainReactPackage(),
+        new RNInstabugReactnativePackage()
+    );
+}
+```
    
 _You can find your app token by selecting the SDK tab from your [**Instabug dashboard**](https://dashboard.instabug.com)._
 

__tests__/index.spec.js

@@ -101,8 +101,6 @@ describe('Instabug Module', () => {
   });
 
   it('should call the native method start', () => {
-
-    Platform.OS = 'ios';
     const token = 'some-token';
     const invocationEvents = [Instabug.invocationEvent.floatingButton, Instabug.invocationEvent.shake];
     Instabug.start(token, invocationEvents);
@@ -111,17 +109,6 @@ describe('Instabug Module', () => {
 
   });
 
-  // it('should not call the native method start when platform is android', () => {
-
-  //   Platform.OS = 'android';
-  //   const token = 'some-token';
-  //   const invocationEvents = [Instabug.invocationEvent.floatingButton, Instabug.invocationEvent.shake];
-  //   Instabug.start(token, invocationEvents);
-
-  //   expect(start.calledOnceWithExactly(token, invocationEvents)).toBe(true);
-
-  // });
-
   it('should call the native method setUserData', () => {
 
     const userData = "userData";

android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java

@@ -6,6 +6,7 @@
 import android.net.Uri;
 import android.os.Handler;
 import android.os.Looper;
+import android.util.Log;
 import android.view.View;
 
 import com.facebook.react.bridge.Arguments;
@@ -25,6 +26,7 @@
 import com.facebook.react.uimanager.NativeViewHierarchyManager;
 import com.facebook.react.uimanager.UIBlock;
 import com.facebook.react.uimanager.UIManagerModule;
+import com.instabug.apm.APM;
 import com.instabug.bug.BugReporting;
 import com.instabug.bug.instabugdisclaimer.Internal;
 import com.instabug.bug.invocation.InvocationMode;
@@ -38,6 +40,7 @@
 import com.instabug.library.Instabug;
 import com.instabug.library.InstabugState;
 import com.instabug.library.OnSdkDismissCallback;
+import com.instabug.library.Platform;
 import com.instabug.library.extendedbugreport.ExtendedBugReport;
 import com.instabug.library.invocation.InstabugInvocationEvent;
 import com.instabug.library.InstabugColorTheme;
@@ -236,23 +239,16 @@ public class RNInstabugReactnativeModule extends ReactContextBaseJavaModule {
     private final String REPORT_DISCARD_DIALOG_POSITIVE_ACTION = "discardAlertAction";
     private final String REPORT_ADD_ATTACHMENT_HEADER = "addAttachmentButtonTitleStringName";
 
-    private Application androidApplication;
-    private Instabug mInstabug;
-    private InstabugInvocationEvent invocationEvent;
     private InstabugCustomTextPlaceHolder placeHolders;
     private Report currentReport;
 
     /**
-     * Instantiates a new Rn instabug reactnative module.
+     * Instantiates a new Rn Instabug ReactNative module.
      *
      * @param reactContext the react context
-     * @param mInstabug    the m instabug
      */
-    public RNInstabugReactnativeModule(ReactApplicationContext reactContext, Application
-            androidApplication, Instabug mInstabug) {
+    public RNInstabugReactnativeModule(ReactApplicationContext reactContext) {
         super(reactContext);
-        this.androidApplication = androidApplication;
-        this.mInstabug = mInstabug;
         //init placHolders
         placeHolders = new InstabugCustomTextPlaceHolder();
     }
@@ -283,13 +279,52 @@ public void run() {
                         String key = stringArray[i];
                         invocationEventsArray[i] = ArgsRegistry.getDeserializedValue(key, InstabugInvocationEvent.class);
                     }
-                    new Instabug.Builder(getCurrentActivity().getApplication(), token).setInvocationEvents(invocationEventsArray).build();
+
+                    final Application application = (Application) getReactApplicationContext().getApplicationContext();
+
+                    setCurrentPlatform();
+                    setBaseUrlForDeprecationLogs();
+
+                    new Instabug.Builder(application, token)
+                            .setInvocationEvents(invocationEventsArray)
+                            .build();
+
+                    // Temporarily disabling APM hot launches
+                    APM.setHotAppLaunchEnabled(false);
                 } catch (Exception e) {
                     e.printStackTrace();
                 }
             }
         });
+    }
+
+    private void setCurrentPlatform() {
+        try {
+            Method method = InstabugUtil.getMethod(Class.forName("com.instabug.library.Instabug"), "setCurrentPlatform", int.class);
+            if (method != null) {
+                Log.i("IB-CP-Bridge", "invoking setCurrentPlatform with platform: " + Platform.RN);
+                method.invoke(null, Platform.RN);
+            } else {
+                Log.e("IB-CP-Bridge", "setCurrentPlatform was not found by reflection");
+            }
+        } catch (Exception e) {
+            e.printStackTrace();
+        }
+    }
 
+    private void setBaseUrlForDeprecationLogs() {
+        try {
+            Method method = InstabugUtil.getMethod(Class.forName("com.instabug.library.util.InstabugDeprecationLogger"), "setBaseUrl", String.class);
+            if (method != null) {
+                method.invoke(null, "https://docs.instabug.com/docs/react-native-sdk-migration-guide");
+            }
+        } catch (ClassNotFoundException e) {
+            e.printStackTrace();
+        } catch (IllegalAccessException e) {
+            e.printStackTrace();
+        } catch (InvocationTargetException e) {
+            e.printStackTrace();
+        }
     }
 
     /**
@@ -1070,7 +1105,7 @@ public void getAllUserAttributes(final Callback userAttributesCallback) {
             public void run() {
                 WritableMap writableMap = Arguments.createMap();
                 try {
-                    HashMap<String, String> map = mInstabug.getAllUserAttributes();
+                    HashMap<String, String> map = Instabug.getAllUserAttributes();
                     for (HashMap.Entry<String, String> entry : map.entrySet()) {
                         writableMap.putString(entry.getKey(), entry.getValue());
                     }