Skip to content

Commit c6138ea

Browse files
a7medevmzelzoghbi
authored andcommitted
fix(android): change parameters used in inner class to final (#1239)
1 parent 3ec90b4 commit c6138ea

File tree

4 files changed

+10
-4
lines changed

4 files changed

+10
-4
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
# Changelog
22

3+
## [Unreleased](https://github.com/Instabug/Instabug-React-Native/compare/v13.1.1...dev)
4+
5+
### Fixed
6+
7+
- Change parameters used inside inner classes to `final` in Android code to maintain compatibility with Java 7 and earlier ([#1239](https://github.com/Instabug/Instabug-React-Native/pull/1239)).
8+
39
## [13.1.1](https://github.com/Instabug/Instabug-React-Native/compare/v13.0.4...dev) (JUN 6, 2024)
410

511
### Fixed

android/src/main/java/com/instabug/reactlibrary/RNInstabugCrashReportingModule.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@ public void run() {
9090
* @param level different severity levels for errors
9191
*/
9292
@ReactMethod
93-
public void sendHandledJSCrash(final String exceptionObject, @Nullable ReadableMap userAttributes, @Nullable String fingerprint, @Nullable String level) {
93+
public void sendHandledJSCrash(final String exceptionObject, @Nullable final ReadableMap userAttributes, @Nullable final String fingerprint, @Nullable final String level) {
9494
try {
95-
JSONObject jsonObject = new JSONObject(exceptionObject);
95+
final JSONObject jsonObject = new JSONObject(exceptionObject);
9696
MainThreadHandler.runOnMainThread(new Runnable() {
9797
@Override
9898
public void run() {

android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -161,7 +161,7 @@ public void run() {
161161
}
162162

163163
@ReactMethod
164-
public void setCodePushVersion(@Nullable String version) {
164+
public void setCodePushVersion(@Nullable final String version) {
165165
MainThreadHandler.runOnMainThread(new Runnable() {
166166
@Override
167167
public void run() {

android/src/main/java/com/instabug/reactlibrary/RNInstabugSessionReplayModule.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ public void run() {
8383
}
8484

8585
@ReactMethod
86-
public void getSessionReplayLink(Promise promise) {
86+
public void getSessionReplayLink(final Promise promise) {
8787
MainThreadHandler.runOnMainThread(new Runnable() {
8888
@Override
8989
public void run() {

0 commit comments

Comments
 (0)