Skip to content

Commit b05ce5a

Browse files
committed
🐛 Fix a bug where the app crashes on iOS 8 due to os_logs.
1 parent 720581c commit b05ce5a

File tree

1 file changed

+13
-10
lines changed

1 file changed

+13
-10
lines changed

ios/RNInstabug/InstabugReactBridge.m

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -450,11 +450,12 @@ + (BOOL)iOSVersionIsLessThan:(NSString *)iOSVersion {
450450
NSString *message
451451
)
452452
{
453-
NSString *log = RCTFormatLog([NSDate date], level, fileName, lineNumber, message);
454-
455-
456-
NSLog(@"Instabug - REACT LOG: %s", log.UTF8String);
453+
NSString *log = RCTFormatLog([NSDate date], level, fileName, lineNumber, message);
454+
NSString *compeleteLog = [NSString stringWithFormat:@"Instabug - REACT LOG: %@", log];
455+
456+
va_list arg_list;
457457

458+
IBGNSLog(compeleteLog, arg_list);
458459
if([InstabugReactBridge iOSVersionIsLessThan:@"10.0"]) {
459460
int aslLevel;
460461
switch(level) {
@@ -474,23 +475,25 @@ + (BOOL)iOSVersionIsLessThan:(NSString *)iOSVersion {
474475
aslLevel = ASL_LEVEL_CRIT;
475476
break;
476477
}
477-
asl_log(NULL, NULL, aslLevel, "%s", message.UTF8String);
478+
asl_log(NULL, NULL, aslLevel, "%s", log.UTF8String);
478479
} else {
480+
os_log_t newlog = os_log_create("Default", "Instabug");
481+
479482
switch(level) {
480483
case RCTLogLevelTrace:
481-
os_log(OS_LOG_DEFAULT, "%s", [message UTF8String]);
484+
os_log(newlog, "%s", [message UTF8String]);
482485
break;
483486
case RCTLogLevelInfo:
484-
os_log_with_type(OS_LOG_DEFAULT, OS_LOG_TYPE_INFO, "%s", [message UTF8String]);
487+
os_log_with_type(newlog, OS_LOG_TYPE_INFO, "%s", [message UTF8String]);
485488
break;
486489
case RCTLogLevelWarning:
487-
os_log(OS_LOG_DEFAULT, "%s", [message UTF8String]);
490+
os_log(newlog, "%s", [message UTF8String]);
488491
break;
489492
case RCTLogLevelError:
490-
os_log_error(OS_LOG_DEFAULT, "%s", [message UTF8String]);
493+
os_log_error(newlog, "%s", [message UTF8String]);
491494
break;
492495
case RCTLogLevelFatal:
493-
os_log_fault(OS_LOG_DEFAULT, "%s", [message UTF8String]);
496+
os_log_fault(newlog, "%s", [message UTF8String]);
494497
break;
495498
}
496499
}

0 commit comments

Comments
 (0)