Skip to content

Commit 977241a

Browse files
committed
📝 Adjust the auto screen recording to take the duration in seconds, and not in milliseconds
1 parent 728b076 commit 977241a

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@ android {
2121

2222
dependencies {
2323
compile 'com.facebook.react:react-native:0.20.+'
24-
compile 'com.instabug.library:instabug:4.10.0'
24+
compile 'com.instabug.library:instabug:4.10.1'
2525

2626
}

android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,7 +258,8 @@ public void setAutoScreenRecordingEnabled(boolean autoScreenRecordingEnabled) {
258258
@ReactMethod
259259
public void setAutoScreenRecordingMaxDuration(int autoScreenRecordingMaxDuration) {
260260
try {
261-
Instabug.setAutoScreenRecordingMaxDuration(autoScreenRecordingMaxDuration);
261+
int durationInMilli = autoScreenRecordingMaxDuration*1000;
262+
Instabug.setAutoScreenRecordingMaxDuration(durationInMilli);
262263
} catch (Exception e) {
263264
e.printStackTrace();
264265
}

index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -73,8 +73,8 @@ module.exports = {
7373
* Sets auto screen recording maximum duration
7474
*
7575
* @param autoScreenRecordingMaxDuration maximum duration of the screen recording video
76-
* in milliseconds
77-
* The maximum duration is 30000 milliseconds
76+
* in seconds
77+
* The maximum duration is 30 seconds
7878
*/
7979
setAutoScreenRecordingMaxDuration: function(autoScreenRecordingMaxDuration) {
8080
Instabug.setAutoScreenRecordingMaxDuration(autoScreenRecordingMaxDuration)

0 commit comments

Comments
 (0)