🎉 Unifying native SDKs initialization (#356)

Author: alyezz

CHANGELOG.md

@@ -1,3 +1,9 @@
+## Master
+
+**⚠️ If you are using Android, please make sure to follow the migration guide [here](https://github.com/Instabug/Instabug-React-Native/blob/master/README.md#updating-to-version-863)**
+* You can now initialize Instabug on Android by calling `Instabug.start` from Javascript, instead of calling the builder method from the application class.
+* Updates native iOS SDK to v8.6.2
+
 ## v8.6.2 (2019-08-29)
 
 * Updates native Android SDK to v8.6.2

InstabugSample/android/app/src/main/java/com/instabugsample/MainApplication.java

@@ -26,9 +26,6 @@ protected List<ReactPackage> getPackages() {
       List<ReactPackage> packages = new PackageList(this).getPackages();
       // Packages that cannot be autolinked yet can be added manually here, for example:
       // packages.add(new MyReactNativePackage());
-      new RNInstabugReactnativePackage.Builder("YOUR_TOKEN",this.getApplication())
-              .setInvocationEvent("shake")
-              .build();
       return packages;
     }
 

README.md

@@ -87,35 +87,19 @@ pod install
 ```
 
 ## Using Instabug
-1. To start using Instabug, import it into your `index.ios.js` and `index.android.js` file.
+1. To start using Instabug, import it into your `index.js` file.
 
 ```javascript
 import Instabug from 'instabug-reactnative';
 ```
-2. Then initialize it in the `constructor` or `componentWillMount`. This line will let the Instabug SDK work with the default behavior. The SDK will be invoked when the device is shaken. You can customize this behavior through the APIs (You can skip this step if you are building an Android app only).
+2. Then initialize it in the `constructor` or `componentWillMount`. This line will let the Instabug SDK work with the default behavior. The SDK will be invoked when the device is shaken. You can customize this behavior through the APIs.
 
 ```javascript
-Instabug.startWithToken('IOS_APP_TOKEN', [Instabug.invocationEvent.shake]);
-```
-3. Open `android/app/src/main/java/[...]/MainApplication.java`
-   You should find the getPackages method looks like the following snippet. You just need to add your Android app token (You can skip this step if you are building an iOS app only). You can change the invocation event from here, simply by replacing the `"shake"` with any of the following `"button"`, `"none"`, `"screenshot"`, or `"swipe"`. You can change the primary color by replacing the `"#1D82DC"` with any colour of your choice.
-   In the case that you are using the floating button as an invocation event, you can change the floating button edge and the floating button offset using the last two methods, by replacing `"left"` to `"right"`, and by changing the offset number.
-```javascript
-@Override
-protected List<ReactPackage> getPackages() {
-	return Arrays.<ReactPackage>asList(
-	new MainReactPackage(),
-	new RNInstabugReactnativePackage.Builder("YOUR_APP_TOKEN", MainApplication.this)
-                            .setInvocationEvent("shake")
-                            .setPrimaryColor("#1D82DC")
-                            .setFloatingEdge("left")
-                            .setFloatingButtonOffsetFromTop(250)
-                            .build()
-}
+Instabug.start('APP_TOKEN', [Instabug.invocationEvent.shake]);
 ```
 You can find your app token by selecting the SDK tab from your [**Instabug dashboard**](https://dashboard.instabug.com/app/sdk/).
 
-4. Make sure the following snippet is added to your project level `build.gradle`. This should be added automatically upon linking. If not, you can add it manually.
+3. Make sure the following snippet is added to your project level `build.gradle`. This should be added automatically upon linking. If not, you can add it manually.
 ```dart
 allprojects {
 	repositories {
@@ -166,6 +150,25 @@ npm install instabug-reactnative
 react-native add-instabug
 ```
 
+### Updating to version 8.6.3
+
+Starting 8.6.3, starting the SDK on Android can now be done from the JS side and no longer requires the integration code inside Android's `MainApplication.java`.
+
+1) Remove the android integration code from your `MainApplication.java`, it should look something like this:
+
+```java
+new RNInstabugReactnativePackage.Builder("YOUR_APP_TOKEN", MainApplication.this)
+                            .setInvocationEvent("shake")
+                            .build();
+```
+
+2. Then initialize it in the `constructor` or `componentWillMount`. This line will let the Instabug SDK work with the default behavior. The SDK will be invoked when the device is shaken. You can customize this behavior through the APIs.
+
+```javascript
+Instabug.start('APP_TOKEN', [Instabug.invocationEvent.shake]);
+```
+
+
 ## Microphone and Photo Library Usage Description (iOS Only)
 
 Instabug needs access to the microphone and photo library to be able to let users add audio and video attachments. Starting from iOS 10, apps that don’t provide a usage description for those 2 permissions would be rejected when submitted to the App Store.

__tests__/index.spec.js

@@ -102,7 +102,7 @@ describe('Instabug Module', () => {
     const invocationEvents = [Instabug.invocationEvent.floatingButton, Instabug.invocationEvent.shake];
     Instabug.start(token, invocationEvents);
 
-    expect(startWithToken.notCalled).toBe(true);
+    expect(startWithToken.calledOnceWithExactly(token, invocationEvents)).toBe(true);
 
   });
 

android/build.gradle

@@ -27,7 +27,7 @@ android {
 
 dependencies {
     implementation 'com.facebook.react:react-native:+'
-    api('com.instabug.library:instabug:8.6.2.0') {
+    api('com.instabug.library:instabug:8.6.3.0') {
         exclude group: 'com.android.support:appcompat-v7'
     }
     testImplementation 'org.mockito:mockito-core:1.10.19'

android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java

@@ -237,6 +237,39 @@ public String getName() {
         return "Instabug";
     }
 
+  /**
+   * Starts the SDK.
+   * @param token string The token that identifies the app, you can find
+   * it on your dashboard.
+   * @param invocationEventValues ReadableArray The events that invokes
+   * the SDK's UI.
+   */
+    @ReactMethod
+    public void startWithToken(final String token, final ReadableArray invocationEventValues) {
+        try {
+            Object[] objectArray = ArrayUtil.toArray(invocationEventValues);
+            String[] stringArray = Arrays.copyOf(objectArray, objectArray.length, String[].class);
+            final InstabugInvocationEvent[] invocationEventsArray = new InstabugInvocationEvent[stringArray.length];
+
+            for (int i = 0; i < stringArray.length; i++) {
+                String key = stringArray[i];
+                invocationEventsArray[i] = ArgsRegistry.getDeserializedValue(key, InstabugInvocationEvent.class);
+            }
+            new Handler(Looper.getMainLooper()).post(new Runnable() {
+                @Override
+                public void run() {
+                    try {
+                        new Instabug.Builder(getCurrentActivity().getApplication(), token).setInvocationEvents(invocationEventsArray).build();
+                    } catch (Exception e) {
+                        e.printStackTrace();
+                    }
+                }
+            });
+        } catch (Exception e) {
+            e.printStackTrace();
+        }
+    }
+
     /**
      * Adds tag(s) to issues before sending them
      *

index.js

@@ -55,8 +55,8 @@ const InstabugModule = {
    * @param {invocationEvent} invocationEvent The event that invokes
    * the SDK's UI.
    */
-  start(token, invocationEvent) {
-    if (Platform.OS === 'ios') Instabug.startWithToken(token, invocationEvent);
+  start: function(token, invocationEvent) {
+    Instabug.startWithToken(token, invocationEvent);
   },
 
   /**

ios/Instabug.framework/Headers/IBGBugReporting.h

@@ -5,7 +5,7 @@
  
  Copyright:  (c) 2013-2019 by Instabug, Inc., all rights reserved.
  
- Version:    8.6.1
+ Version:    8.6.2
  */
 
 #import <Foundation/Foundation.h>

ios/Instabug.framework/Headers/IBGChats.h

@@ -5,7 +5,7 @@
  
  Copyright:  (c) 2013-2019 by Instabug, Inc., all rights reserved.
  
- Version:    8.6.1
+ Version:    8.6.2
  */
 
 #import <Foundation/Foundation.h>

ios/Instabug.framework/Headers/IBGCrashReporting.h

@@ -5,7 +5,7 @@
  
  Copyright:  (c) 2013-2019 by Instabug, Inc., all rights reserved.
  
- Version:    8.6.1
+ Version:    8.6.2
  */
 
 #import <Foundation/Foundation.h>

ios/Instabug.framework/Headers/IBGFeatureRequests.h

@@ -5,7 +5,7 @@
  
  Copyright:  (c) 2013-2019 by Instabug, Inc., all rights reserved.
  
- Version:    8.6.1
+ Version:    8.6.2
  */
 
 

ios/Instabug.framework/Headers/IBGLog.h

@@ -5,7 +5,7 @@
  
  Copyright:  (c) 2013-2019 by Instabug, Inc., all rights reserved.
  
- Version:    8.6.1
+ Version:    8.6.2
  */
 
 #import <Foundation/Foundation.h>