Skip to content

Commit 5c7efd3

Browse files
committed
Merge branch 'master' of github.com:Instabug/Instabug-React-Native into release/8.0.24
2 parents 5fa5218 + aa5e3e2 commit 5c7efd3

File tree

2 files changed

+35
-14
lines changed

2 files changed

+35
-14
lines changed

README.md

Lines changed: 34 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,46 +17,61 @@ For more info, visit [Instabug.com](https://www.instabug.com).
1717

1818
## Installation
1919

20-
1. Open the terminal and navigate to your React Native Directory. Then run the following command.
20+
### Using react-native CLI
21+
22+
1. In Terminal, navigate to your React Native directory and install the `instabug-reactnative` package:
2123

2224
```bash
2325
npm install instabug-reactnative
2426
```
25-
or
27+
28+
Or if you prefer to use Yarn instead of npm:
2629

2730
```bash
2831
yarn add instabug-reactnative
2932
```
3033

31-
2. Install [**Ruby**](https://www.ruby-lang.org/en/documentation/installation/). (You can skip this step if you're building for Android only)
34+
2. For projects that build for iOS, install `xcodeproj` gem:
3235

33-
3. Install `xcodeproj` gem by running the following command. (You can also skip this step if you're building for Android only)
3436
```bash
3537
gem install xcodeproj
3638
```
3739

38-
4. Link the bridging files in the npm package to the ios project use the following command.
40+
3. Finally, link the bridging files in the `instabug-reactnative` package:
41+
42+
3943
```bash
4044
react-native link instabug-reactnative
4145
```
42-
### Installing using Cocoapods
43-
Alternatively, for iOS you can use [CocoaPods](https://cocoapods.org/) for managing dependencies. After following the first step from the installation steps above, add the following to your `Podfile`:
46+
47+
### Using CocoaPods (iOS only)
48+
49+
Alternatively, for iOS you can use [CocoaPods](https://cocoapods.org/) for managing dependencies.
50+
51+
1. In Terminal, navigate to your React Native directory and install the `instabug-reactnative` package:
52+
53+
```bash
54+
npm install instabug-reactnative
55+
```
56+
57+
2. Add the following to your `Podfile`:
4458

4559
```ruby
4660
pod 'instabug-reactnative', :path => '../node_modules/instabug-reactnative'
4761
pod 'React', :path => '../node_modules/react-native', :subspecs => [
48-
'Core',
49-
'CxxBridge',
50-
'DevSupport'
62+
'Core',
63+
'CxxBridge',
64+
'DevSupport'
5165
]
66+
67+
# Required React native dependencies
5268
pod 'yoga', :path => '../node_modules/react-native/ReactCommon/yoga'
5369
pod 'DoubleConversion', :podspec => '../node_modules/react-native/third-party-podspecs/DoubleConversion.podspec'
5470
pod 'glog', :podspec => '../node_modules/react-native/third-party-podspecs/GLog.podspec'
5571
pod 'Folly', :podspec => '../node_modules/react-native/third-party-podspecs/Folly.podspec'
56-
```
57-
And add the following post install script at the end of your `Podfile`:
5872

59-
```ruby
73+
# To make sure that archiving works correctly in Xcode, React has to be
74+
# removed from the Pods project as it's already included in the main project.
6075
post_install do |installer|
6176
installer.pods_project.targets.each do |target|
6277
if target.name == "React"
@@ -66,6 +81,12 @@ post_install do |installer|
6681
end
6782
```
6883

84+
3. Install `instabug-reactnative`:
85+
86+
```bash
87+
pod install
88+
```
89+
6990
## Using Instabug
7091
1. To start using Instabug, import it into your `index.ios.js` and `index.android.js` file.
7192

ios/Instabug.framework/InstabugResources.bundle/Instabug_dsym_upload.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ echo "Instabug: Compressing dSYM file..."
136136
# Upload dSYM
137137
echo "Instabug: Uploading dSYM file..."
138138
ENDPOINT="https://api.instabug.com/api/sdk/v3/symbols_files"
139-
STATUS=$(curl "${ENDPOINT}" --write-out %{http_code} --silent --output /dev/null -F symbols_file=@"${DSYM_PATH_ZIP}" -F application_token="${APP_TOKEN}")
139+
STATUS=$(curl "${ENDPOINT}" --write-out %{http_code} --silent --output /dev/null -F os=ios -F symbols_file=@"${DSYM_PATH_ZIP}" -F application_token="${APP_TOKEN}")
140140
if [ $STATUS -ne 200 ]; then
141141
echo "Instabug: err: dSYM archive not succesfully uploaded."
142142
echo "Instabug: deleting temporary dSYM archive..."

0 commit comments

Comments
 (0)