[INSD-6505] Add missing string keys (#661)

* Add missing string keys

* Update CHANGELOG.md

* Add more string keys

 - videoPressRecord
 - reproStepsListItemTitle

Co-authored-by: Ali Abdelfattah <[email protected]>
Co-authored-by: Youssef Raafat <[email protected]>

Author: 3 people

CHANGELOG.md

@@ -4,6 +4,7 @@
 * Breaking: Removes the deprecated APIs. Check the migration guide referenced in our README
 * Adds the ability to opt out of iOS source maps auto upload through the INSTABUG_SOURCEMAPS_UPLOAD_DISABLE env variable
 * Adds dynamic entry file support through the INSTABUG_ENTRY_FILE env variable
+* Adds string keys for the Repro Steps
 * Fixes an issue with setRequestFilterExpression API not working with Hermes
 * Fixes an issue with swipe invocation event not working on Android
 

android/src/main/java/com/instabug/reactlibrary/ArgsRegistry.java

@@ -194,6 +194,7 @@ static void registerCustomTextPlaceHolderKeysArgs(Map<String, Object> args) {
         args.put("reportSuccessfullySent", InstabugCustomTextPlaceHolder.Key.REPORT_SUCCESSFULLY_SENT);
         args.put("successDialogHeader", InstabugCustomTextPlaceHolder.Key.SUCCESS_DIALOG_HEADER);
         args.put("addVideoMessage", InstabugCustomTextPlaceHolder.Key.ADD_VIDEO);
+        args.put("videoPressRecord", InstabugCustomTextPlaceHolder.Key.VIDEO_RECORDING_FAB_BUBBLE_HINT);
         args.put("betaWelcomeMessageWelcomeStepTitle", InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_WELCOME_STEP_TITLE);
         args.put("betaWelcomeMessageWelcomeStepContent", InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_WELCOME_STEP_CONTENT);
         args.put("betaWelcomeMessageHowToReportStepTitle", InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_HOW_TO_REPORT_STEP_TITLE);
@@ -207,6 +208,13 @@ static void registerCustomTextPlaceHolderKeysArgs(Map<String, Object> args) {
         args.put("discardAlertCancel", InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_NEGATIVE_ACTION);
         args.put("discardAlertAction", InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_POSITIVE_ACTION);
         args.put("addAttachmentButtonTitleStringName", InstabugCustomTextPlaceHolder.Key.REPORT_ADD_ATTACHMENT_HEADER);
+        args.put("reportReproStepsDisclaimerBody", InstabugCustomTextPlaceHolder.Key.REPORT_REPRO_STEPS_DISCLAIMER_BODY);
+        args.put("reportReproStepsDisclaimerLink", InstabugCustomTextPlaceHolder.Key.REPORT_REPRO_STEPS_DISCLAIMER_LINK);
+        args.put("reproStepsProgressDialogBody", InstabugCustomTextPlaceHolder.Key.REPRO_STEPS_PROGRESS_DIALOG_BODY);
+        args.put("reproStepsListHeader", InstabugCustomTextPlaceHolder.Key.REPRO_STEPS_LIST_HEADER);
+        args.put("reproStepsListDescription", InstabugCustomTextPlaceHolder.Key.REPRO_STEPS_LIST_DESCRIPTION);
+        args.put("reproStepsListEmptyStateDescription", InstabugCustomTextPlaceHolder.Key.REPRO_STEPS_LIST_EMPTY_STATE_DESCRIPTION);
+        args.put("reproStepsListItemTitle", InstabugCustomTextPlaceHolder.Key.REPRO_STEPS_LIST_ITEM_NUMBERING_TITLE);
     }
 
     static void registerInstabugReportTypesArgs(Map<String, Object> args) {

android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java

@@ -198,6 +198,7 @@ public class RNInstabugReactnativeModule extends ReactContextBaseJavaModule {
     private final String ADD_IMAGE_FROM_GALLERY = "addImageFromGallery";
     private final String ADD_EXTRA_SCREENSHOT = "addExtraScreenshot";
     private final String ADD_VIDEO = "addVideoMessage";
+    private final String VIDEO_PRESS_RECORD = "videoPressRecord";
 
     private final String AUDIO_RECORDING_PERMISSION_DENIED = "audioRecordingPermissionDenied";
 
@@ -233,6 +234,13 @@ public class RNInstabugReactnativeModule extends ReactContextBaseJavaModule {
     private final String REPORT_DISCARD_DIALOG_NEGATIVE_ACTION = "discardAlertCancel";
     private final String REPORT_DISCARD_DIALOG_POSITIVE_ACTION = "discardAlertAction";
     private final String REPORT_ADD_ATTACHMENT_HEADER = "addAttachmentButtonTitleStringName";
+    private final String REPORT_REPRO_STEPS_DISCLAIMER_BODY = "reportReproStepsDisclaimerBody";
+    private final String REPORT_REPRO_STEPS_DISCLAIMER_LINK = "reportReproStepsDisclaimerLink";
+    private final String REPRO_STEPS_PROGRESS_DIALOG_BODY = "reproStepsProgressDialogBody";
+    private final String REPRO_STEPS_LIST_HEADER = "reproStepsListHeader";
+    private final String REPRO_STEPS_LIST_DESCRIPTION = "reproStepsListDescription";
+    private final String REPRO_STEPS_LIST_EMPTY_STATE_DESCRIPTION = "reproStepsListEmptyStateDescription";
+    private final String REPRO_STEPS_LIST_ITEM_TITLE = "reproStepsListItemTitle";
 
     private InstabugCustomTextPlaceHolder placeHolders;
     private Report currentReport;
@@ -2038,6 +2046,8 @@ private InstabugCustomTextPlaceHolder.Key getStringToKeyConstant(String key) {
                 return InstabugCustomTextPlaceHolder.Key.ADD_EXTRA_SCREENSHOT;
             case ADD_VIDEO:
                 return InstabugCustomTextPlaceHolder.Key.ADD_VIDEO;
+            case VIDEO_PRESS_RECORD:
+                return InstabugCustomTextPlaceHolder.Key.VIDEO_RECORDING_FAB_BUBBLE_HINT;
             case AUDIO_RECORDING_PERMISSION_DENIED:
                 return InstabugCustomTextPlaceHolder.Key.AUDIO_RECORDING_PERMISSION_DENIED;
             case VOICE_MESSAGE_PRESS_AND_HOLD_TO_RECORD:
@@ -2090,6 +2100,20 @@ private InstabugCustomTextPlaceHolder.Key getStringToKeyConstant(String key) {
                 return InstabugCustomTextPlaceHolder.Key.REPORT_DISCARD_DIALOG_POSITIVE_ACTION;
             case REPORT_ADD_ATTACHMENT_HEADER:
                 return InstabugCustomTextPlaceHolder.Key.REPORT_ADD_ATTACHMENT_HEADER;
+            case REPORT_REPRO_STEPS_DISCLAIMER_BODY:
+                return InstabugCustomTextPlaceHolder.Key.REPORT_REPRO_STEPS_DISCLAIMER_BODY;
+            case REPORT_REPRO_STEPS_DISCLAIMER_LINK:
+                return InstabugCustomTextPlaceHolder.Key.REPORT_REPRO_STEPS_DISCLAIMER_LINK;
+            case REPRO_STEPS_PROGRESS_DIALOG_BODY:
+                return InstabugCustomTextPlaceHolder.Key.REPRO_STEPS_PROGRESS_DIALOG_BODY;
+            case REPRO_STEPS_LIST_HEADER:
+                return InstabugCustomTextPlaceHolder.Key.REPRO_STEPS_LIST_HEADER;
+            case REPRO_STEPS_LIST_DESCRIPTION:
+                return InstabugCustomTextPlaceHolder.Key.REPRO_STEPS_LIST_DESCRIPTION;
+            case REPRO_STEPS_LIST_EMPTY_STATE_DESCRIPTION:
+                return InstabugCustomTextPlaceHolder.Key.REPRO_STEPS_LIST_EMPTY_STATE_DESCRIPTION;
+            case REPRO_STEPS_LIST_ITEM_TITLE:
+                return InstabugCustomTextPlaceHolder.Key.REPRO_STEPS_LIST_ITEM_NUMBERING_TITLE;
             default:
                 return null;
         }
@@ -2279,6 +2303,7 @@ public Map<String, Object> getConstants() {
         constants.put("addImageFromGallery", ADD_IMAGE_FROM_GALLERY);
         constants.put("addExtraScreenshot", ADD_EXTRA_SCREENSHOT);
         constants.put("addVideoMessage", ADD_VIDEO);
+        constants.put("videoPressRecord", VIDEO_PRESS_RECORD);
         constants.put("audioRecordingPermissionDeniedMessage", AUDIO_RECORDING_PERMISSION_DENIED);
         constants.put("recordingMessageToHoldText", VOICE_MESSAGE_PRESS_AND_HOLD_TO_RECORD);
         constants.put("recordingMessageToReleaseText", VOICE_MESSAGE_RELEASE_TO_ATTACH);
@@ -2309,6 +2334,13 @@ public Map<String, Object> getConstants() {
         constants.put(REPORT_DISCARD_DIALOG_NEGATIVE_ACTION, REPORT_DISCARD_DIALOG_NEGATIVE_ACTION);
         constants.put(REPORT_DISCARD_DIALOG_POSITIVE_ACTION, REPORT_DISCARD_DIALOG_POSITIVE_ACTION);
         constants.put(REPORT_ADD_ATTACHMENT_HEADER, REPORT_ADD_ATTACHMENT_HEADER);
+        constants.put(REPORT_REPRO_STEPS_DISCLAIMER_BODY, REPORT_REPRO_STEPS_DISCLAIMER_BODY);
+        constants.put(REPORT_REPRO_STEPS_DISCLAIMER_LINK, REPORT_REPRO_STEPS_DISCLAIMER_LINK);
+        constants.put(REPRO_STEPS_PROGRESS_DIALOG_BODY, REPRO_STEPS_PROGRESS_DIALOG_BODY);
+        constants.put(REPRO_STEPS_LIST_HEADER, REPRO_STEPS_LIST_HEADER);
+        constants.put(REPRO_STEPS_LIST_DESCRIPTION, REPRO_STEPS_LIST_DESCRIPTION);
+        constants.put(REPRO_STEPS_LIST_EMPTY_STATE_DESCRIPTION, REPRO_STEPS_LIST_EMPTY_STATE_DESCRIPTION);
+        constants.put(REPRO_STEPS_LIST_ITEM_TITLE, REPRO_STEPS_LIST_ITEM_TITLE);
 
         return constants;
     }

index.d.ts

@@ -1070,6 +1070,7 @@ export enum strings {
   commentFieldHintForBugReport,
   commentFieldHintForFeedback,
   commentFieldHintForQuestion,
+  videoPressRecord,
   addVideoMessage,
   addVoiceMessage,
   addImageFromGallery,
@@ -1112,7 +1113,14 @@ export enum strings {
   discardAlertMessage,
   discardAlertCancel,
   discardAlertAction,
-  addAttachmentButtonTitleStringName
+  addAttachmentButtonTitleStringName,
+  reportReproStepsDisclaimerBody,
+  reportReproStepsDisclaimerLink,
+  reproStepsProgressDialogBody,
+  reproStepsListHeader,
+  reproStepsListDescription,
+  reproStepsListEmptyStateDescription,
+  reproStepsListItemTitle
 }
 
 interface Report {

index.js

@@ -764,6 +764,7 @@ const InstabugModule = {
     commentFieldHintForBugReport: Instabug.commentFieldHintForBugReport,
     commentFieldHintForFeedback: Instabug.commentFieldHintForFeedback,
     commentFieldHintForQuestion: Instabug.commentFieldHintForQuestion,
+    videoPressRecord: Instabug.videoPressRecord,
     addVideoMessage: Instabug.addVideoMessage,
     addVoiceMessage: Instabug.addVoiceMessage,
     addImageFromGallery: Instabug.addImageFromGallery,
@@ -817,7 +818,14 @@ const InstabugModule = {
     discardAlertMessage: Instabug.discardAlertMessage,
     discardAlertCancel: Instabug.discardAlertCancel,
     discardAlertAction: Instabug.discardAlertAction,
-    addAttachmentButtonTitleStringName: Instabug.addAttachmentButtonTitleStringName
+    addAttachmentButtonTitleStringName: Instabug.addAttachmentButtonTitleStringName,
+    reportReproStepsDisclaimerBody: Instabug.reportReproStepsDisclaimerBody,
+    reportReproStepsDisclaimerLink: Instabug.reportReproStepsDisclaimerLink,
+    reproStepsProgressDialogBody: Instabug.reproStepsProgressDialogBody,
+    reproStepsListHeader: Instabug.reproStepsListHeader,
+    reproStepsListDescription: Instabug.reproStepsListDescription,
+    reproStepsListEmptyStateDescription: Instabug.reproStepsListEmptyStateDescription,
+    reproStepsListItemTitle: Instabug.reproStepsListItemTitle,
   },
 
 };

ios/RNInstabug/InstabugReactBridge.m

@@ -574,7 +574,7 @@ - (NSDictionary *)constantsToExport
               @"screenRecording": kIBGScreenRecordingStringName,
               @"image": kIBGImageStringName,
               @"surveyEnterYourAnswer": kIBGSurveyEnterYourAnswerTextPlaceholder,
-              @"videPressRecord": kIBGVideoPressRecordTitle,
+              @"videoPressRecord": kIBGVideoPressRecordTitle,
               @"collectingDataText": kIBGCollectingDataText,
               @"thankYouAlertText": kIBGThankYouAlertMessageStringName,
 
@@ -599,7 +599,14 @@ - (NSDictionary *)constantsToExport
               @"discardAlertMessage": kIBGDiscardAlertMessage,
               @"discardAlertCancel": kIBGDiscardAlertCancel,
               @"discardAlertAction": kIBGDiscardAlertAction,
-              @"addAttachmentButtonTitleStringName": kIBGAddAttachmentButtonTitleStringName
+              @"addAttachmentButtonTitleStringName": kIBGAddAttachmentButtonTitleStringName,
+              @"reportReproStepsDisclaimerBody": kIBGReproStepsDisclaimerBody,
+              @"reportReproStepsDisclaimerLink": kIBGReproStepsDisclaimerLink,
+              @"reproStepsProgressDialogBody": kIBGProgressViewTitle,
+              @"reproStepsListHeader": kIBGReproStepsListTitle,
+              @"reproStepsListDescription": kIBGReproStepsListHeader,
+              @"reproStepsListEmptyStateDescription": kIBGReproStepsListEmptyStateLabel,
+              @"reproStepsListItemTitle": kIBGReproStepsListItemName
             };
 };