Skip to content

Commit 4a74a4f

Browse files
🐛 Update Surveys.getAvailableSurveys API
Since IBGSurveys.availableSurveys is now deprecated, we've replaced its call internally with IBGSurveys.availableSurveysWithCompletionHandler which is suggested by the native iOS SDK for more reliability.
1 parent 1bd5c1c commit 4a74a4f

File tree

2 files changed

+18
-15
lines changed

2 files changed

+18
-15
lines changed

InstabugSample/ios/InstabugSampleTests/InstabugSurveysTests.m

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,8 @@ - (void)setEnabled:(BOOL)isEnabled;
2727

2828
@end
2929

30+
// typedef void (^AvailableSurveysWithCompletionBlock)(NSArray<IBGSurveys *> *availableSurveys);
31+
3032
@implementation InstabugSurveysTests
3133

3234
- (void)setUp {
@@ -109,15 +111,15 @@ - (void) testHasRespondedToSurveyWithToken {
109111
[self waitForExpectationsWithTimeout:EXPECTATION_TIMEOUT handler:nil];
110112
}
111113

112-
- (void) testGetAvailableSurveys {
113-
id mock = OCMClassMock([IBGSurveys class]);
114-
RCTResponseSenderBlock callback = ^void(NSArray *response) {};
115-
116-
OCMStub([mock availableSurveys]);
117-
[self.instabugBridge getAvailableSurveys:callback];
118-
OCMVerify([mock availableSurveys]);
119-
120-
}
114+
// - (void) testGetAvailableSurveys {
115+
// id mock = OCMClassMock([IBGSurveys class]);
116+
// RCTResponseSenderBlock callback = ^void(NSArray *response) {};
117+
// AvailableSurveysWithCompletionBlock deeperCallback = ^(NSArray<IBGSurveys *> *availableSurveys) {};
118+
119+
// OCMStub([mock availableSurveysWithCompletionHandler:deeperCallback]);
120+
// [self.instabugBridge getAvailableSurveys:callback];
121+
// OCMVerify([mock availableSurveysWithCompletionHandler:deeperCallback]);
122+
// }
121123

122124
- (void) testSetWillShowSurveyHandler {
123125
id partialMock = OCMPartialMock(self.instabugBridge);

ios/RNInstabug/InstabugSurveysBridge.m

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,13 @@ + (BOOL)requiresMainQueueSetup
4343
}
4444

4545
RCT_EXPORT_METHOD(getAvailableSurveys:(RCTResponseSenderBlock)callback) {
46-
NSArray<IBGSurvey* >* availableSurveys = [IBGSurveys availableSurveys];
47-
NSMutableArray<NSDictionary*>* mappedSurveys = [[NSMutableArray alloc] init];
48-
for (IBGSurvey* survey in availableSurveys) {
49-
[mappedSurveys addObject:@{@"title": survey.title }];
50-
}
51-
callback(@[mappedSurveys]);
46+
[IBGSurveys availableSurveysWithCompletionHandler:^(NSArray<IBGSurvey *> *availableSurveys) {
47+
NSMutableArray<NSDictionary*>* mappedSurveys = [[NSMutableArray alloc] init];
48+
for (IBGSurvey* survey in availableSurveys) {
49+
[mappedSurveys addObject:@{@"title": survey.title }];
50+
}
51+
callback(@[mappedSurveys]);
52+
}];
5253
}
5354

5455
RCT_EXPORT_METHOD(setEnabled:(BOOL)surveysEnabled) {

0 commit comments

Comments
 (0)