Skip to content

Commit 369cabc

Browse files
authored
Release/8.4 (#301)
* ⬆️ update native android SDK to version 8.4.0.1 * 📝 change android private views native implementation to match ios * ⬆️ Update native iOS SDK to 8.4 * 💎 Bump version to 8.4.0
1 parent 2e3862f commit 369cabc

File tree

74 files changed

+388
-285
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

74 files changed

+388
-285
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions

android/build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ android {
2727

2828
dependencies {
2929
implementation 'com.facebook.react:react-native:+'
30-
api ('com.instabug.library:instabug:8.3.0.0'){
30+
api ('com.instabug.library:instabug:8.4.0.1'){
3131
exclude group: 'com.android.support:appcompat-v7'
3232
}
3333
}

android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import android.os.Handler;
77
import android.os.Looper;
88
import android.util.Log;
9+
import android.view.View;
910

1011
import com.facebook.react.bridge.Arguments;
1112
import com.facebook.react.bridge.Promise;
@@ -22,6 +23,9 @@
2223
import com.facebook.react.bridge.Callback;
2324

2425
import com.facebook.react.modules.core.DeviceEventManagerModule;
26+
import com.facebook.react.uimanager.NativeViewHierarchyManager;
27+
import com.facebook.react.uimanager.UIBlock;
28+
import com.facebook.react.uimanager.UIManagerModule;
2529
import com.instabug.bug.BugReporting;
2630
import com.instabug.bug.PromptOption;
2731
import com.instabug.bug.instabugdisclaimer.Internal;
@@ -2034,27 +2038,19 @@ public void networkLog(String jsonObject) throws JSONException {
20342038

20352039

20362040
@ReactMethod
2037-
public void hideView(ReadableArray ids) {
2038-
int[] arrayOfIds = new int[ids.size()];
2039-
for (int i = 0; i < ids.size(); i++) {
2040-
int viewId = (int) ids.getDouble(i);
2041-
arrayOfIds[i] = viewId;
2042-
}
2043-
Method method = null;
2044-
try {
2045-
method = InstabugUtil.getMethod(Class.forName("com.instabug.library.Instabug"), "setSecureViewsId", int[].class);
2046-
} catch (ClassNotFoundException e) {
2047-
e.printStackTrace();
2048-
}
2049-
if (method != null) {
2050-
try {
2051-
method.invoke(null, arrayOfIds);
2052-
} catch (IllegalAccessException e) {
2053-
e.printStackTrace();
2054-
} catch (InvocationTargetException e) {
2055-
e.printStackTrace();
2041+
public void hideView(final ReadableArray ids) {
2042+
UIManagerModule uiManagerModule = getReactApplicationContext().getNativeModule(UIManagerModule.class);
2043+
uiManagerModule.prependUIBlock(new UIBlock() {
2044+
@Override
2045+
public void execute(NativeViewHierarchyManager nativeViewHierarchyManager) {
2046+
final View[] arrayOfViews = new View[ids.size()];
2047+
for (int i = 0; i < ids.size(); i++) {
2048+
int viewId = (int) ids.getDouble(i);
2049+
arrayOfViews[i] = nativeViewHierarchyManager.resolveView(viewId);
2050+
}
2051+
Instabug.setViewsAsPrivate(arrayOfViews);
20562052
}
2057-
}
2053+
});
20582054
}
20592055

20602056
private InstabugCustomTextPlaceHolder.Key getStringToKeyConstant(String key) {

ios/Instabug.framework/Headers/IBGBugReporting.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
//
2-
// IBGBugReporting.h
3-
// InstabugBugReporting
4-
//
5-
// Created by Yousef Hamza on 5/17/18.
6-
// Copyright © 2018 Moataz. All rights reserved.
7-
//
1+
/*
2+
File: Instabug/IBGBugReporting.h
3+
4+
Contains: API for using Instabug's SDK.
5+
6+
Copyright: (c) 2013-2019 by Instabug, Inc., all rights reserved.
7+
8+
Version: 8.4
9+
*/
810

911
#import <Foundation/Foundation.h>
1012
#import "IBGTypes.h"

ios/Instabug.framework/Headers/IBGChats.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
//
2-
// IBGChats.h
3-
// InstabugChats
4-
//
5-
// Created by Hassaan El-Garem on 11/25/18.
6-
// Copyright © 2018 Moataz. All rights reserved.
7-
//
1+
/*
2+
File: Instabug/IBGChats.h
3+
4+
Contains: API for using Instabug's SDK.
5+
6+
Copyright: (c) 2013-2019 by Instabug, Inc., all rights reserved.
7+
8+
Version: 8.4
9+
*/
810

911
#import <Foundation/Foundation.h>
1012

ios/Instabug.framework/Headers/IBGCrashReporting.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
//
2-
// IBGCrashReporting.h
3-
// InstabugCrashReporting
4-
//
5-
// Created by Yousef Hamza on 5/17/18.
6-
// Copyright © 2018 Moataz. All rights reserved.
7-
//
1+
/*
2+
File: Instabug/IBGCrashReporting.h
3+
4+
Contains: API for using Instabug's SDK.
5+
6+
Copyright: (c) 2013-2019 by Instabug, Inc., all rights reserved.
7+
8+
Version: 8.4
9+
*/
810

911
#import <Foundation/Foundation.h>
1012

ios/Instabug.framework/Headers/IBGFeatureRequests.h

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,13 @@
1-
//
2-
// IBGFeatureRequests.h
3-
// Instabug
4-
//
5-
// Created by Yousef Hamza on 5/17/18.
6-
// Copyright © 2018 Moataz. All rights reserved.
7-
//
1+
/*
2+
File: Instabug/IBGFeatureRequests.h
3+
4+
Contains: API for using Instabug's SDK.
5+
6+
Copyright: (c) 2013-2019 by Instabug, Inc., all rights reserved.
7+
8+
Version: 8.4
9+
*/
10+
811

912
#import <Foundation/Foundation.h>
1013
#import "IBGTypes.h"

ios/Instabug.framework/Headers/IBGLog.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
//
2-
// IBGLog.h
3-
// InstabugI
4-
//
5-
// Created by Yousef Hamza on 5/17/18.
6-
// Copyright © 2018 Moataz. All rights reserved.
7-
//
1+
/*
2+
File: Instabug/IBGLog.h
3+
4+
Contains: API for using Instabug's SDK.
5+
6+
Copyright: (c) 2013-2019 by Instabug, Inc., all rights reserved.
7+
8+
Version: 8.4
9+
*/
810

911
#import <Foundation/Foundation.h>
1012
#import "InstabugCore.h"

ios/Instabug.framework/Headers/IBGNetworkLogger.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
//
2-
// IBGNetworkLogger.h
3-
// InstabugCore
4-
//
5-
// Created by Yousef Hamza on 5/17/18.
6-
// Copyright © 2018 Instabug. All rights reserved.
7-
//
1+
/*
2+
File: Instabug/IBGNetworkLogger.h
3+
4+
Contains: API for using Instabug's SDK.
5+
6+
Copyright: (c) 2013-2019 by Instabug, Inc., all rights reserved.
7+
8+
Version: 8.4
9+
*/
810

911
#import <Foundation/Foundation.h>
1012
#import "IBGTypes.h"

ios/Instabug.framework/Headers/IBGReplies.h

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,12 @@
1-
//
2-
// IBGReplies.h
3-
// InstabugChats
4-
//
5-
// Created by Hassaan El-Garem on 11/25/18.
6-
// Copyright © 2018 Moataz. All rights reserved.
7-
//
1+
/*
2+
File: Instabug/IBGReplies.h
3+
4+
Contains: API for using Instabug's SDK.
5+
6+
Copyright: (c) 2013-2019 by Instabug, Inc., all rights reserved.
7+
8+
Version: 8.4
9+
*/
810

911
#import <Foundation/Foundation.h>
1012

0 commit comments

Comments
 (0)