💎 Bumping native SDKs to 8.6.1

Author: alyezz

CHANGELOG.md

@@ -1,3 +1,7 @@
+## Master
+
+* Bump native SDKs to 8.6.1
+
 ## v8.5.6 (2019-08-21)
 
 * Fixes an issue that crashes the SDK when calling `Instabug.onReportSubmitHandler` on iOS.

InstabugSample/App.js

@@ -55,12 +55,12 @@ export default class App extends Component<{}> {
           <TouchableOpacity style={styles.button} onPress={()=>this.sendFeedback()}>
             <Text style={styles.text}> SEND FEEDBACK </Text>
           </TouchableOpacity>
+          <TouchableOpacity style={styles.button} onPress={()=>this.startNewConversation()}>
+            <Text style={styles.text}> ASK A QUESTION </Text>
+          </TouchableOpacity>
           <TouchableOpacity style={styles.button} onPress={()=>this.sendCrashReport()}>
             <Text style={styles.text}> THROW HANDLED EXCEPTION </Text>
           </TouchableOpacity>
-          <TouchableOpacity style={styles.button} onPress={()=>this.startNewConversation()}>
-            <Text style={styles.text}> START A NEW CONVERSATION </Text>
-          </TouchableOpacity>
           <TouchableOpacity style={styles.button} onPress={()=>this.showNpsSurvey()}>
             <Text style={styles.text}> SHOW NPS SURVEY </Text>
           </TouchableOpacity>
@@ -184,7 +184,7 @@ export default class App extends Component<{}> {
   }
 
   startNewConversation() {
-    Chats.show();
+    BugReporting.showWithOptions(BugReporting.reportType.question);
   }
 
   showUnreadMessagesCount() {

InstabugSample/ios/InstabugSampleTests/InstabugBugReportingTests.m

@@ -48,21 +48,6 @@ - (void) testgivenInvocationEvent$setInvocationEvents_whenQuery_thenShouldCallNa
   XCTAssertEqual(IBGBugReporting.invocationEvents, invocationEvents);
 }
 
-- (void)testgiven$invoke_whenQuery_thenShouldCallNativeApi {
-  id mock = OCMClassMock([IBGBugReporting class]);
-  
-  OCMStub([mock invoke]);
-  [self.instabugBridge invoke];
-  XCTestExpectation *expectation = [self expectationWithDescription:@"Test ME PLX"];
-  
-  [[NSRunLoop mainRunLoop] performBlock:^{
-    OCMVerify([mock invoke]);
-    [expectation fulfill];
-  }];
-  
-  [self waitForExpectationsWithTimeout:EXPECTATION_TIMEOUT handler:nil];
-}
-
 - (void) testgivenOptions$setOptions_whenQuery_thenShouldCallNativeApiWithArgs {
   NSArray *invocationOptionsArr = [NSArray arrayWithObjects:  @(IBGBugReportingInvocationOptionEmailFieldHidden), nil];
 
@@ -74,26 +59,6 @@ - (void) testgivenOptions$setOptions_whenQuery_thenShouldCallNativeApiWithArgs {
   XCTAssertEqual(IBGBugReporting.bugReportingOptions, invocationOptions);
 }
 
-- (void) testgivenInvocationModeAndOptiond$invokeWithModeOptions_whenQuery_thenShouldCallNativeApiWithArgs {
-  NSArray *invocationOptionsArr = [NSArray arrayWithObjects:  @(IBGBugReportingInvocationOptionEmailFieldHidden), nil];
-  IBGBugReportingInvocationOption invocationOptions = 0;
-  for (NSNumber *boxedValue in invocationOptionsArr) {
-    invocationOptions |= [boxedValue intValue];
-  }
-  IBGInvocationMode invocationMode = IBGInvocationModeNewBug;
-  id mock = OCMClassMock([IBGBugReporting class]);
-  OCMStub([mock invokeWithMode:invocationMode options:invocationOptions]);
-  [self.instabugBridge invokeWithInvocationModeAndOptions:invocationMode options:invocationOptionsArr];
-  XCTestExpectation *expectation = [self expectationWithDescription:@"Test ME PLX"];
-  
-  [[NSRunLoop mainRunLoop] performBlock:^{
-    OCMVerify([mock invokeWithMode:invocationMode options:invocationOptions]);
-    [expectation fulfill];
-  }];
-  
-  [self waitForExpectationsWithTimeout:EXPECTATION_TIMEOUT handler:nil];
-}
-
 - (void) testgivenHandler$setOnInvokeHandler_whenQuery_thenShouldCallNativeApi {
   id partialMock = OCMPartialMock(self.instabugBridge);
   RCTResponseSenderBlock callback = ^(NSArray *response) {};
@@ -142,15 +107,6 @@ - (void) testgivenHandlerADD_ATTACHMENT$setOnSDKDismissedHandler_whenQuery_thenS
   OCMVerify([partialMock sendEventWithName:@"IBGpostInvocationHandler" body:result]);
 }
 
-- (void) testgivenBooleans$setPromptOptionsEnabled_whenQuery_thenShouldCallNativeApi {
-  id mock = OCMClassMock([IBGBugReporting class]);
-  BOOL enabled = true;
-  IBGPromptOption promptOption = IBGPromptOptionNone + IBGPromptOptionChat + IBGPromptOptionBug + IBGPromptOptionFeedback;
-  OCMStub([mock setPromptOptions:promptOption]);
-  [self.instabugBridge setPromptOptionsEnabled:enabled feedback:enabled chat:enabled];
-  OCMVerify([mock setPromptOptions:promptOption]);
-}
-
 - (void) skip_testgivenDouble$setShakingThresholdForiPhone_whenQuery_thenShouldCallNativeApi {
   double threshold = 12;
   [self.instabugBridge setShakingThresholdForiPhone:threshold];

InstabugSample/ios/InstabugSampleTests/InstabugRepliesTests.m

@@ -85,6 +85,15 @@ - (void) testgivenBoolean$setInAppNotificationEnabled_whenQuery_thenShouldCallNa
   XCTAssertFalse(IBGReplies.inAppNotificationsEnabled);
 }
 
+- (void)testSetPushNotificationsEnabled {
+  id mock = OCMClassMock([IBGReplies class]);
+  BOOL isPushNotificationEnabled = true;
+  
+  OCMStub([mock setPushNotificationsEnabled:isPushNotificationEnabled]);
+  [self.instabugBridge setPushNotificationsEnabled:isPushNotificationEnabled];
+  OCMVerify([mock setPushNotificationsEnabled:isPushNotificationEnabled]);
+}
+
 
 @end
 

InstabugSample/ios/InstabugSampleTests/InstabugSampleTests.m

@@ -97,15 +97,6 @@ - (void)testSetSessionProfilerEnabled {
   OCMVerify([mock setSessionProfilerEnabled:sessionProfilerEnabled]);
 }
 
-- (void)testSetPushNotificationsEnabled {
-  id mock = OCMClassMock([Instabug class]);
-  BOOL isPushNotificationEnabled = true;
-  
-  OCMStub([mock setPushNotificationsEnabled:isPushNotificationEnabled]);
-  [self.instabugBridge setPushNotificationsEnabled:isPushNotificationEnabled];
-  OCMVerify([mock setPushNotificationsEnabled:isPushNotificationEnabled]);
-}
-
 - (void)testSetLocale {
   id<InstabugCPTestProtocol> mock = OCMClassMock([Instabug class]);
 

InstabugSample/package.json

@@ -9,7 +9,7 @@
   },
   "dependencies": {
     "react": "16.8.6",
-    "react-native": "0.60.0",
+    "react-native": "0.60.3",
     "instabug-reactnative": "../"
   },
   "devDependencies": {

InstabugSample/yarn.lock

@@ -2853,6 +2853,11 @@ has@^1.0.1, has@^1.0.3:
   dependencies:
     function-bind "^1.1.1"
 
+hermesvm@^0.1.0:
+  version "0.1.0"
+  resolved "https://registry.yarnpkg.com/hermesvm/-/hermesvm-0.1.0.tgz#4bfaf4ac682a2fd407b862ab641eb8deb232de83"
+  integrity sha512-GbP6dKaVW/V2QpB+DZPxcmhBhJVFa9cHS/xRX7FD1MGfa6Z1aHHD83VDCwo3SgcqNj5yHlVbe9UgrK1PFGCXpw==
+
 hosted-git-info@^2.1.4:
   version "2.7.1"
   resolved "https://registry.yarnpkg.com/hosted-git-info/-/hosted-git-info-2.7.1.tgz#97f236977bd6e125408930ff6de3eec6281ec047"
@@ -3001,7 +3006,7 @@ inquirer@^6.2.2:
     through "^2.3.6"
 
 instabug-reactnative@../:
-  version "8.4.4"
+  version "8.5.6"
 
 invariant@^2.2.4:
   version "2.2.4"
@@ -4184,6 +4189,29 @@ [email protected]:
     "@babel/types" "^7.0.0"
     source-map "^0.5.6"
 
+[email protected], metro-source-map@^0.55.0:
+  version "0.55.0"
+  resolved "https://registry.yarnpkg.com/metro-source-map/-/metro-source-map-0.55.0.tgz#1f6289905f08277c398f2b9b9c13e7e0e5a6f540"
+  integrity sha512-HZODA0KPl5onJNGIztfTHHWurR2nL6Je/X8wwj+bL4ZBB/hSMVeDk7rWReCAvO3twVz7Ztp8Si0jfMmmH4Ruuw==
+  dependencies:
+    "@babel/traverse" "^7.0.0"
+    "@babel/types" "^7.0.0"
+    invariant "^2.2.4"
+    metro-symbolicate "0.55.0"
+    ob1 "0.55.0"
+    source-map "^0.5.6"
+    vlq "^1.0.0"
+
+[email protected]:
+  version "0.55.0"
+  resolved "https://registry.yarnpkg.com/metro-symbolicate/-/metro-symbolicate-0.55.0.tgz#4086a2adae54b5e44a4911ca572d8a7b03c71fa1"
+  integrity sha512-3r3Gpv5L4U7rBGpIqw5S1nun5MelfUMLRiScJsPRGZVTX3WY1w+zpaQKlWBi5yuHf5dMQ+ZUVbhb02IdrfJ2Fg==
+  dependencies:
+    metro-source-map "0.55.0"
+    source-map "^0.5.6"
+    through2 "^2.0.1"
+    vlq "^1.0.0"
+
 [email protected], metro@^0.54.1:
   version "0.54.1"
   resolved "https://registry.yarnpkg.com/metro/-/metro-0.54.1.tgz#a629be00abee5a450a25a8f71c24745f70cc9b44"
@@ -4572,6 +4600,11 @@ oauth-sign@~0.9.0:
   resolved "https://registry.yarnpkg.com/oauth-sign/-/oauth-sign-0.9.0.tgz#47a7b016baa68b5fa0ecf3dee08a85c679ac6455"
   integrity sha512-fexhUFFPTGV8ybAtSIGbV6gOkSv8UtRbDBnAyLQw4QPKkgNlsH2ByPGtMUqdWkos6YCRmAqViwgZrJc/mRDzZQ==
 
+[email protected]:
+  version "0.55.0"
+  resolved "https://registry.yarnpkg.com/ob1/-/ob1-0.55.0.tgz#e393b4ae786ef442b3ef2a298ab70d6ec353dbdd"
+  integrity sha512-pfyiMVsUItl8WiRKMT15eCi662pCRAuYTq2+V3UpE+PpFErJI/TvRh/M/l/9TaLlbFr7krJ7gdl+FXJNcybmvw==
+
 object-assign@^4.0.1, object-assign@^4.1.0, object-assign@^4.1.1:
   version "4.1.1"
   resolved "https://registry.yarnpkg.com/object-assign/-/object-assign-4.1.1.tgz#2109adc7965887cfc05cbbd442cac8bfbb360863"
@@ -5066,10 +5099,10 @@ react-deep-force-update@^1.0.0:
   resolved "https://registry.yarnpkg.com/react-deep-force-update/-/react-deep-force-update-1.1.2.tgz#3d2ae45c2c9040cbb1772be52f8ea1ade6ca2ee1"
   integrity sha512-WUSQJ4P/wWcusaH+zZmbECOk7H5N2pOIl0vzheeornkIMhu+qrNdGFm0bDZLCb0hSF0jf/kH1SgkNGfBdTc4wA==
 
-react-devtools-core@^3.6.0:
-  version "3.6.1"
-  resolved "https://registry.yarnpkg.com/react-devtools-core/-/react-devtools-core-3.6.1.tgz#51af81ceada65209bbccb8b547a01187cd1cbf04"
-  integrity sha512-I/LSX+tpeTrGKaF1wXSfJ/kP+6iaP2JfshEjW8LtQBdz6c6HhzOJtjZXhqOUrAdysuey8M1/JgPY1flSVVt8Ig==
+react-devtools-core@^3.6.1:
+  version "3.6.3"
+  resolved "https://registry.yarnpkg.com/react-devtools-core/-/react-devtools-core-3.6.3.tgz#977d95b684c6ad28205f0c62e1e12c5f16675814"
+  integrity sha512-+P+eFy/yo8Z/UH9J0DqHZuUM5+RI2wl249TNvMx3J2jpUomLQa4Zxl56GEotGfw3PIP1eI+hVf1s53FlUONStQ==
   dependencies:
     shell-quote "^1.6.1"
     ws "^3.3.1"
@@ -5079,10 +5112,10 @@ react-is@^16.8.1, react-is@^16.8.4, react-is@^16.8.6:
   resolved "https://registry.yarnpkg.com/react-is/-/react-is-16.8.6.tgz#5bbc1e2d29141c9fbdfed456343fe2bc430a6a16"
   integrity sha512-aUk3bHfZ2bRSVFFbbeVS4i+lNPZr3/WM5jT2J5omUVV1zzcs1nAaf3l51ctA5FFvCRbhrH0bdAsRRQddFJZPtA==
 
-[email protected].0:
-  version "0.60.0"
-  resolved "https://registry.yarnpkg.com/react-native/-/react-native-0.60.0.tgz#f5302b6efe797c5f5fbdfebaba2ff174fc433890"
-  integrity sha512-Leo1MfUpQFCLchr60HCDZAk7M6Bd2yPplSDBuCrC9gUtsRO2P4nLxwrX6P+vbjF7Td2sQbcGqW2E809Oi41K0g==
+[email protected].3:
+  version "0.60.3"
+  resolved "https://registry.yarnpkg.com/react-native/-/react-native-0.60.3.tgz#da010bc5b63201166562ddeff1cd3e07da34d1de"
+  integrity sha512-rUUUGYIzWwMkedfB8XxZ5TIt+qorQ70mJ08vsDTenQ16xalawOFqV34Jisdi4LgRGfQomdNWeY1Bd+H1A/dyBg==
   dependencies:
     "@babel/runtime" "^7.0.0"
     "@react-native-community/cli" "^2.0.1"
@@ -5097,15 +5130,17 @@ [email protected]:
     event-target-shim "^5.0.1"
     fbjs "^1.0.0"
     fbjs-scripts "^1.1.0"
+    hermesvm "^0.1.0"
     invariant "^2.2.4"
     jsc-android "245459.0.0"
     metro-babel-register "0.54.1"
     metro-react-native-babel-transformer "0.54.1"
+    metro-source-map "^0.55.0"
     nullthrows "^1.1.0"
     pretty-format "^24.7.0"
     promise "^7.1.1"
     prop-types "^15.7.2"
-    react-devtools-core "^3.6.0"
+    react-devtools-core "^3.6.1"
     regenerator-runtime "^0.13.2"
     scheduler "0.14.0"
     stacktrace-parser "^0.1.3"
@@ -5942,7 +5977,7 @@ throat@^4.0.0, throat@^4.1.0:
   resolved "https://registry.yarnpkg.com/throat/-/throat-4.1.0.tgz#89037cbc92c56ab18926e6ba4cbb200e15672a6a"
   integrity sha1-iQN8vJLFarGJJua6TLsgDhVnKmo=
 
-through2@^2.0.0:
+through2@^2.0.0, through2@^2.0.1:
   version "2.0.5"
   resolved "https://registry.yarnpkg.com/through2/-/through2-2.0.5.tgz#01c1e39eb31d07cb7d03a96a70823260b23132cd"
   integrity sha512-/mrRod8xqpA+IHSLyGCQ2s8SPHiCDEeQJSep1jqLYeEUClOFG2Qsh+4FU6G9VeqpZnGW/Su8LQGc4YKni5rYSQ==
@@ -6220,6 +6255,11 @@ [email protected]:
     core-util-is "1.0.2"
     extsprintf "^1.2.0"
 
+vlq@^1.0.0:
+  version "1.0.1"
+  resolved "https://registry.yarnpkg.com/vlq/-/vlq-1.0.1.tgz#c003f6e7c0b4c1edd623fd6ee50bbc0d6a1de468"
+  integrity sha512-gQpnTgkubC6hQgdIcRdYGDSDc+SaujOdyesZQMv6JlfQee/9Mp0Qhnys6WxDWvQnL5WZdT7o2Ul187aSt0Rq+w==
+
 w3c-hr-time@^1.0.1:
   version "1.0.1"
   resolved "https://registry.yarnpkg.com/w3c-hr-time/-/w3c-hr-time-1.0.1.tgz#82ac2bff63d950ea9e3189a58a65625fedf19045"

__tests__/bugReporting.spec.js

@@ -226,20 +226,6 @@ describe('Testing BugReporting Module', () => {
 
   });
 
-  it('should invoke callback on emitting the event IBGDidSelectPromptOptionHandler', (done) => {
-
-    Platform.OS = 'ios';
-    const payload = { promptOption: Instabug.promptOption.bug };
-    const callback = (promptOption) => {
-      expect(promptOption).toBe(payload.promptOption);
-      done();
-    }
-    BugReporting.setDidSelectPromptOptionHandler(callback);
-    IBGEventEmitter.emit(IBGConstants.DID_SELECT_PROMPT_OPTION_HANDLER, payload);
-
-    expect(IBGEventEmitter.getListeners(IBGConstants.DID_SELECT_PROMPT_OPTION_HANDLER).length).toEqual(1);
-  });
-
   it('should return on calling setDidSelectPromptOptionHandler when Platform is android', () => {
 
     Platform.OS = 'android';

__tests__/index.spec.js

@@ -24,7 +24,7 @@ describe('Instabug Module', () => {
   const setTrackUserSteps = sinon.spy(NativeModules.Instabug, 'setTrackUserSteps');
   const setIBGLogPrintsToConsole = sinon.spy(NativeModules.Instabug, 'setIBGLogPrintsToConsole');
   const setSessionProfilerEnabled = sinon.spy(NativeModules.Instabug, 'setSessionProfilerEnabled');
-  const setPushNotificationsEnabled = sinon.spy(NativeModules.Instabug, 'setPushNotificationsEnabled');
+  const setPushNotificationsEnabled = sinon.spy(NativeModules.IBGReplies, 'setPushNotificationsEnabled');
   const setFloatingButtonEdge = sinon.spy(NativeModules.IBGBugReporting, 'setFloatingButtonEdge');
   const setLocale = sinon.spy(NativeModules.Instabug, 'setLocale');
   const setColorTheme = sinon.spy(NativeModules.Instabug, 'setColorTheme');

__tests__/replies.spec.js

@@ -20,11 +20,13 @@ describe('Replies Module', () => {
   const getUnreadMessagesCount = sinon.spy(NativeModules.IBGReplies, 'getUnreadRepliesCount');
   const setChatNotificationEnabled = sinon.spy(NativeModules.IBGReplies, 'setInAppNotificationEnabled');
   const setEnableInAppNotificationSound = sinon.spy(NativeModules.IBGReplies, 'setInAppNotificationSound');
+  const setPushNotificationsEnabled = sinon.spy(NativeModules.IBGReplies, 'setPushNotificationsEnabled');
 
   beforeEach(() => {
     setOnNewReplyReceivedCallback.resetHistory();
     setEnableInAppNotificationSound.resetHistory();
     IBGEventEmitter.removeAllListeners();
+    setPushNotificationsEnabled.resetHistory();
   });
 
   it('should call the native method setRepliesEnabled', () => {
@@ -113,5 +115,24 @@ describe('Replies Module', () => {
 
   });
 
+  it('should call the native method setPushNotificationsEnabled', () => {
+
+    Platform.OS = 'ios';
+    Replies.setPushNotificationsEnabled(true);
+
+    expect(setPushNotificationsEnabled.calledOnceWithExactly(true)).toBe(true);
+
+  });
+
+
+  it('should not call the native method setPushNotificationsEnabled when platform is android', () => {
+
+    Platform.OS = 'android';
+    Replies.setPushNotificationsEnabled(true);
+
+    expect(setPushNotificationsEnabled.notCalled).toBe(true);
+
+  });
+
 
 });