Skip to content

Commit 1653494

Browse files
salmatarzisalmatarzi
authored
🤝 Merge pull request #20 from Instabug/fix/add_missing_welcome_message_strings
Fix/add missing welcome message strings
2 parents 1ae07db + e1a03fd commit 1653494

File tree

4 files changed

+62
-2
lines changed

4 files changed

+62
-2
lines changed

‎android/src/main/java/com/instabug/reactlibrary/RNInstabugReactnativeModule.java

Lines changed: 34 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,15 @@ public class RNInstabugReactnativeModule extends ReactContextBaseJavaModule {
178178
private final String REPORT_SUCCESSFULLY_SENT = "thankYouText";
179179
private final String THANK_YOU_ALERT_TEXT = "thankYouAlertText";
180180

181+
private final String WELCOME_MESSAGE_BETA_WELCOME_STEP_TITLE = "welcomeMessageBetaWelcomeStepTitle";
182+
private final String WELCOME_MESSAGE_BETA_WELCOME_STEP_CONTENT = "welcomeMessageBetaWelcomeStepContent";
183+
private final String WELCOME_MESSAGE_HOW_TO_REPORT_STEP_TITLE = "welcomeMessageBetaHowToReportStepTitle";
184+
private final String WELCOME_MESSAGE_HOW_TO_REPORT_STEP_CONTENT = "welcomeMessageBetaHowToReportStepContent";
185+
private final String WELCOME_MESSAGE_FINISH_STEP_TITLE = "welcomeMessageBetaFinishStepTitle";
186+
private final String WELCOME_MESSAGE_FINISH_STEP_CONTENT = "welcomeMessageBetaFinishStepContent";
187+
private final String WELCOME_MESSAGE_LIVE_WELCOME_STEP_TITLE = "welcomeMessageLiveWelcomeStepTitle";
188+
private final String WELCOME_MESSAGE_LIVE_WELCOME_STEP_CONTENT = "welcomeMessageLiveWelcomeStepContent";
189+
181190
private final String VIDEO_PLAYER_TITLE = "video";
182191

183192
private final String CONVERSATION_TEXT_FIELD_HINT = "conversationTextFieldHint";
@@ -2022,6 +2031,22 @@ private InstabugCustomTextPlaceHolder.Key getStringToKeyConstant(String key) {
20222031
return InstabugCustomTextPlaceHolder.Key.VIDEO_PLAYER_TITLE;
20232032
case THANK_YOU_ALERT_TEXT:
20242033
return InstabugCustomTextPlaceHolder.Key.REPORT_SUCCESSFULLY_SENT;
2034+
case WELCOME_MESSAGE_BETA_WELCOME_STEP_TITLE:
2035+
return InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_WELCOME_STEP_TITLE;
2036+
case WELCOME_MESSAGE_BETA_WELCOME_STEP_CONTENT:
2037+
return InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_WELCOME_STEP_CONTENT;
2038+
case WELCOME_MESSAGE_HOW_TO_REPORT_STEP_TITLE:
2039+
return InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_HOW_TO_REPORT_STEP_TITLE;
2040+
case WELCOME_MESSAGE_HOW_TO_REPORT_STEP_CONTENT:
2041+
return InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_HOW_TO_REPORT_STEP_CONTENT;
2042+
case WELCOME_MESSAGE_FINISH_STEP_TITLE:
2043+
return InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_FINISH_STEP_TITLE;
2044+
case WELCOME_MESSAGE_FINISH_STEP_CONTENT:
2045+
return InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_FINISH_STEP_CONTENT;
2046+
case WELCOME_MESSAGE_LIVE_WELCOME_STEP_TITLE:
2047+
return InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_TITLE;
2048+
case WELCOME_MESSAGE_LIVE_WELCOME_STEP_CONTENT:
2049+
return InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_CONTENT;
20252050
default:
20262051
return null;
20272052
}
@@ -2208,6 +2233,15 @@ public Map<String, Object> getConstants() {
22082233
constants.put("conversationTextFieldHint", CONVERSATION_TEXT_FIELD_HINT);
22092234
constants.put("thankYouAlertText", THANK_YOU_ALERT_TEXT);
22102235

2236+
constants.put("welcomeMessageBetaWelcomeStepTitle", WELCOME_MESSAGE_BETA_WELCOME_STEP_TITLE);
2237+
constants.put("welcomeMessageBetaWelcomeStepContent", WELCOME_MESSAGE_BETA_WELCOME_STEP_CONTENT);
2238+
constants.put("welcomeMessageBetaHowToReportStepTitle", WELCOME_MESSAGE_HOW_TO_REPORT_STEP_TITLE);
2239+
constants.put("welcomeMessageBetaHowToReportStepContent", WELCOME_MESSAGE_HOW_TO_REPORT_STEP_CONTENT);
2240+
constants.put("welcomeMessageBetaFinishStepTitle", WELCOME_MESSAGE_FINISH_STEP_TITLE);
2241+
constants.put("welcomeMessageBetaFinishStepContent", WELCOME_MESSAGE_FINISH_STEP_CONTENT);
2242+
constants.put("welcomeMessageLiveWelcomeStepTitle", WELCOME_MESSAGE_LIVE_WELCOME_STEP_TITLE);
2243+
constants.put("welcomeMessageLiveWelcomeStepContent", WELCOME_MESSAGE_LIVE_WELCOME_STEP_CONTENT);
2244+
22112245
return constants;
22122246
}
22132247
}

‎index.js

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1316,6 +1316,15 @@ const InstabugModule = {
13161316
conversationTextFieldHint: Instabug.conversationTextFieldHint,
13171317
collectingDataText: Instabug.collectingDataText,
13181318
thankYouAlertText: Instabug.thankYouAlertText,
1319+
welcomeMessageBetaWelcomeStepTitle: Instabug.welcomeMessageBetaWelcomeStepTitle,
1320+
welcomeMessageBetaWelcomeStepContent: Instabug.welcomeMessageBetaWelcomeStepContent,
1321+
welcomeMessageBetaHowToReportStepTitle: Instabug.welcomeMessageBetaHowToReportStepTitle,
1322+
welcomeMessageBetaHowToReportStepContent: Instabug.welcomeMessageBetaHowToReportStepContent,
1323+
welcomeMessageBetaFinishStepTitle: Instabug.welcomeMessageBetaFinishStepTitle,
1324+
welcomeMessageBetaFinishStepContent: Instabug.welcomeMessageBetaFinishStepContent,
1325+
welcomeMessageLiveWelcomeStepTitle: Instabug.welcomeMessageLiveWelcomeStepTitle,
1326+
welcomeMessageLiveWelcomeStepContent: Instabug.welcomeMessageLiveWelcomeStepContent
1327+
13191328
}
13201329
};
13211330

‎ios/RNInstabug/InstabugReactBridge.m

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,16 @@ - (NSDictionary *)constantsToExport
699699
@"surveyEnterYourAnswer": @(IBGStringSurveyEnterYourAnswerPlaceholder),
700700
@"videPressRecord": @(IBGStringVideoPressRecordTitle),
701701
@"collectingDataText": @(IBGStringCollectingDataText),
702-
@"thankYouAlertText": @(IBGStringThankYouAlertText)
702+
@"thankYouAlertText": @(IBGStringThankYouAlertText),
703+
704+
@"welcomeMessageBetaWelcomeStepTitle": @(IBGBetaWelcomeMessageWelcomeStepTitle),
705+
@"welcomeMessageBetaWelcomeStepContent": @(IBGBetaWelcomeMessageWelcomeStepContent),
706+
@"welcomeMessageBetaHowToReportStepTitle": @(IBGBetaWelcomeMessageHowToReportStepTitle),
707+
@"welcomeMessageBetaHowToReportStepContent": @(IBGBetaWelcomeMessageHowToReportStepMessage),
708+
@"welcomeMessageBetaFinishStepTitle": @(IBGBetaWelcomeMessageFinishStepTitle),
709+
@"welcomeMessageBetaFinishStepContent": @(IBGBetaWelcomeMessageFinishStepContent),
710+
@"welcomeMessageLiveWelcomeStepTitle": @(IBGLiveWelcomeMessageTitle),
711+
@"welcomeMessageLiveWelcomeStepContent": @(IBGLiveWelcomeMessageMessage)
703712
};
704713
};
705714

‎ios/RNInstabug/RCTConvert+InstabugEnums.m

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,14 @@ @implementation RCTConvert (InstabugEnums)
158158
@"surveyEnterYourAnswer": @(IBGStringSurveyEnterYourAnswerPlaceholder),
159159
@"videPressRecord": @(IBGStringVideoPressRecordTitle),
160160
@"collectingDataText": @(IBGStringCollectingDataText),
161-
@"thankYouAlertText": @(IBGStringThankYouAlertText)
161+
@"thankYouAlertText": @(IBGStringThankYouAlertText),
162+
@"welcomeMessageBetaWelcomeStepTitle": @(IBGBetaWelcomeMessageWelcomeStepTitle),
163+
@"welcomeMessageBetaWelcomeStepContent": @(IBGBetaWelcomeMessageWelcomeStepContent),
164+
@"welcomeMessageBetaHowToReportStepTitle": @(IBGBetaWelcomeMessageHowToReportStepTitle),
165+
@"welcomeMessageBetaHowToReportStepContent": @(IBGBetaWelcomeMessageHowToReportStepMessage),
166+
@"welcomeMessageBetaFinishStepTitle": @(IBGBetaWelcomeMessageFinishStepTitle),
167+
@"welcomeMessageBetaFinishStepContent": @(IBGBetaWelcomeMessageFinishStepContent),
168+
@"welcomeMessageLiveWelcomeStepTitle": @(IBGLiveWelcomeMessageTitle),
169+
@"welcomeMessageLiveWelcomeStepContent": @(IBGLiveWelcomeMessageMessage)
162170
}), IBGStringShakeHint, integerValue);
163171
@end

0 commit comments

Comments
 (0)