Skip to content

Commit 0b4d7ea

Browse files
authored
📝 Adjusting package linking to the new android initialization
1 parent 5c38167 commit 0b4d7ea

File tree

3 files changed

+11
-4
lines changed

3 files changed

+11
-4
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## v8.6.4 (2019-09-12)
2+
3+
**If you are on React Native pre 0.60, please follow the steps [here](https://github.com/Instabug/Instabug-React-Native/blob/master/README.md#updating-to-version-864)**
4+
* Fixes an issue on Android that would result in a build error with the message `null is not an object (evaluating u.invocationEventNone)`
5+
16
## v8.6.3 (2019-08-29)
27

38
* **⚠️ If you are using Android, please make sure to follow the migration guide [here](https://github.com/Instabug/Instabug-React-Native/blob/master/README.md#updating-to-version-863)**

README.md

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ npm install instabug-reactnative
150150
react-native add-instabug
151151
```
152152

153-
### Updating to version 8.6.3
153+
### Updating to version 8.6.4
154154

155-
Starting 8.6.3, starting the SDK on Android can now be done from the JS side and no longer requires the integration code inside Android's `MainApplication.java`.
155+
Starting the SDK on Android can now be done from the JS side and no longer requires the integration code inside Android's `MainApplication.java`.
156156

157157
1) Remove the android integration code from your `MainApplication.java`, it should look something like this:
158158

@@ -162,7 +162,9 @@ new RNInstabugReactnativePackage.Builder("YOUR_APP_TOKEN", MainApplication.this)
162162
.build();
163163
```
164164

165-
2. Then initialize it in the `constructor` or `componentWillMount`. This line will let the Instabug SDK work with the default behavior. The SDK will be invoked when the device is shaken. You can customize this behavior through the APIs.
165+
2. If you are on React Native < 0.60, unlink instabug using `react-native unlink instabug-reactnative` then link again using `react-native link instabug-reactnative`.
166+
167+
3. Then initialize it in the `constructor` or `componentWillMount`. This line will let the Instabug SDK work with the default behavior. The SDK will be invoked when the device is shaken. You can customize this behavior through the APIs.
166168

167169
```javascript
168170
Instabug.start('APP_TOKEN', [Instabug.invocationEvent.shake]);

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
"preunlink": "node node_modules/instabug-reactnative/unlink_bridge.js"
2929
},
3030
"android": {
31-
"packageInstance": "\t\tnew RNInstabugReactnativePackage.Builder(\"YOUR_ANDROID_APPLICATION_TOKEN\",MainApplication.this)\n\t\t\t\t\t\t\t.setInvocationEvent(\"shake\")\n\t\t\t\t\t\t\t.setPrimaryColor(\"#1D82DC\")\n\t\t\t\t\t\t\t.setFloatingEdge(\"left\")\n\t\t\t\t\t\t\t.setFloatingButtonOffsetFromTop(250)\n\t\t\t\t\t\t\t.build()"
31+
"packageInstance": "\t\tnew RNInstabugReactnativePackage()"
3232
}
3333
},
3434
"devDependencies": {

0 commit comments

Comments
 (0)