Skip to content

Commit 027d03e

Browse files
authored
* 💎 Bump to version 8.4.3
1 parent 2bf0f1e commit 027d03e

File tree

4 files changed

+45
-20
lines changed

4 files changed

+45
-20
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## v8.4.3 (2019-07-03)
2+
3+
* Fixes an issue that caused Android release builds to fail when building on a Windows machine.
4+
* Fixes an issue that caused apps to freeze when `onReportSubmitHandler` is called in certain cases.
5+
16
## v8.4.2 (2019-06-19)
27

38
* Fixes valid email written but gets enter valid email error message on Android.

android/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ dependencies {
3636
import org.apache.tools.ant.taskdefs.condition.Os
3737
task upload_sourcemap(type: Exec) {
3838
if (Os.isFamily(Os.FAMILY_WINDOWS)) {
39-
commandLine 'echo', 'Automatic upload of sourcemap files is currently not available on Windows. Please generate the sourcemap files and upload them to the dashboard manually. For more information see https://docs.instabug.com/docs/react-native-symbolication-obfuscation'
4039
project.logger.lifecycle('Automatic Upload of sourcemap files is currently not available on windows, please generate the sourcemapfiles and upload them to the dashboard')
4140
} else {
4241
environment "INSTABUG_APP_TOKEN", "YOUR_APP_TOKEN"

ios/RNInstabug/InstabugReactBridge.m

Lines changed: 39 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,10 @@ - (dispatch_queue_t)methodQueue {
5050
for (NSNumber *boxedValue in invocationEventsArray) {
5151
invocationEvents |= [boxedValue intValue];
5252
}
53-
[Instabug startWithToken:token invocationEvents:invocationEvents];
53+
[[NSRunLoop mainRunLoop] performBlock:^{
54+
[Instabug startWithToken:token invocationEvents:invocationEvents];
55+
}];
56+
5457
RCTAddLogFunction(InstabugReactLogFunction);
5558
RCTSetLogThreshold(RCTLogLevelInfo);
5659

@@ -77,15 +80,19 @@ - (dispatch_queue_t)methodQueue {
7780
}
7881

7982
RCT_EXPORT_METHOD(invoke) {
80-
[IBGBugReporting invoke];
83+
[[NSRunLoop mainRunLoop] performBlock:^{
84+
[IBGBugReporting invoke];
85+
}];
8186
}
8287

8388
RCT_EXPORT_METHOD(invokeWithInvocationModeAndOptions:(IBGInvocationMode)invocationMode options:(NSArray*)options) {
84-
IBGBugReportingInvocationOption invocationOptions = 0;
85-
for (NSNumber *boxedValue in options) {
86-
invocationOptions |= [boxedValue intValue];
87-
}
88-
[IBGBugReporting invokeWithMode:invocationMode options:invocationOptions];
89+
[[NSRunLoop mainRunLoop] performBlock:^{
90+
IBGBugReportingInvocationOption invocationOptions = 0;
91+
for (NSNumber *boxedValue in options) {
92+
invocationOptions |= [boxedValue intValue];
93+
}
94+
[IBGBugReporting invokeWithMode:invocationMode options:invocationOptions];
95+
}];
8996
}
9097

9198
RCT_EXPORT_METHOD(setReproStepsMode:(IBGUserStepsMode)reproStepsMode) {
@@ -355,11 +362,15 @@ - (dispatch_queue_t)methodQueue {
355362
}
356363

357364
RCT_EXPORT_METHOD(setColorTheme:(IBGColorTheme)colorTheme) {
358-
[Instabug setColorTheme:colorTheme];
365+
[[NSRunLoop mainRunLoop] performBlock:^{
366+
[Instabug setColorTheme:colorTheme];
367+
}];
359368
}
360369

361370
RCT_EXPORT_METHOD(setPrimaryColor:(UIColor *)color) {
362-
Instabug.tintColor = color;
371+
[[NSRunLoop mainRunLoop] performBlock:^{
372+
Instabug.tintColor = color;
373+
}];
363374
}
364375

365376
RCT_EXPORT_METHOD(appendTags:(NSArray *)tags) {
@@ -562,7 +573,9 @@ - (dispatch_queue_t)methodQueue {
562573
}
563574

564575
RCT_EXPORT_METHOD(showFeatureRequests) {
565-
[IBGFeatureRequests show];
576+
[[NSRunLoop mainRunLoop] performBlock:^{
577+
[IBGFeatureRequests show];
578+
}];
566579
}
567580

568581
RCT_EXPORT_METHOD(setShouldShowSurveysWelcomeScreen:(BOOL)shouldShowWelcomeScreen) {
@@ -656,7 +669,9 @@ - (dispatch_queue_t)methodQueue {
656669
}
657670

658671
RCT_EXPORT_METHOD(show) {
659-
[Instabug show];
672+
[[NSRunLoop mainRunLoop] performBlock:^{
673+
[Instabug show];
674+
}];
660675
}
661676

662677
RCT_EXPORT_METHOD(setReportTypes:(NSArray*) types ) {
@@ -672,19 +687,23 @@ - (dispatch_queue_t)methodQueue {
672687
}
673688

674689
RCT_EXPORT_METHOD(showBugReportingWithReportTypeAndOptions:(IBGBugReportingReportType) type: (NSArray*) options) {
675-
IBGBugReportingOption parsedOptions = 0;
676-
for (NSNumber *boxedValue in options) {
677-
parsedOptions |= [boxedValue intValue];
678-
}
679-
[IBGBugReporting showWithReportType:type options:parsedOptions];
690+
[[NSRunLoop mainRunLoop] performBlock:^{
691+
IBGBugReportingOption parsedOptions = 0;
692+
for (NSNumber *boxedValue in options) {
693+
parsedOptions |= [boxedValue intValue];
694+
}
695+
[IBGBugReporting showWithReportType:type options:parsedOptions];
696+
}];
680697
}
681698

682699
RCT_EXPORT_METHOD(setChatsEnabled:(BOOL)isEnabled) {
683700
IBGChats.enabled = isEnabled;
684701
}
685702

686703
RCT_EXPORT_METHOD(showChats) {
687-
[IBGChats show];
704+
[[NSRunLoop mainRunLoop] performBlock:^{
705+
[IBGChats show];
706+
}];
688707
}
689708

690709
RCT_EXPORT_METHOD(setRepliesEnabled:(BOOL) isEnabled) {
@@ -698,7 +717,9 @@ - (dispatch_queue_t)methodQueue {
698717
}
699718

700719
RCT_EXPORT_METHOD(showReplies) {
701-
[IBGReplies show];
720+
[[NSRunLoop mainRunLoop] performBlock:^{
721+
[IBGReplies show];
722+
}];
702723
}
703724

704725
RCT_EXPORT_METHOD(setOnNewReplyReceivedCallback:(RCTResponseSenderBlock) callback) {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "instabug-reactnative",
3-
"version": "8.4.2",
3+
"version": "8.4.3",
44
"description": "React Native plugin for integrating the Instabug SDK",
55
"main": "index.js",
66
"types": "index.d.ts",

0 commit comments

Comments
 (0)