[MOB-10950] Make ArgsRegistry Type-safe on Android (#296)

The two ArgsRegistry methods getDeserializedValue and getRawValue were 
not type safe at runtime. This PR provide a type-safe way to achieve 
enum resolution on Android.

Author: TheBuggedYRN

android/src/main/java/com/instabug/flutter/modules/ApmApi.java

@@ -59,10 +59,8 @@ public void setAutoUITraceEnabled(@NonNull Boolean isEnabled) {
     @Override
     public void setLogLevel(@NonNull String level) {
         try {
-            if (ArgsRegistry.getDeserializedValue(level) == null) {
-                return;
-            }
-            APM.setLogLevel((int) ArgsRegistry.getRawValue(level));
+            final int resolvedLevel = ArgsRegistry.logLevels.get(level);
+            APM.setLogLevel(resolvedLevel);
         } catch (Exception e) {
             e.printStackTrace();
         }

android/src/main/java/com/instabug/flutter/modules/BugReportingApi.java

@@ -1,5 +1,7 @@
 package com.instabug.flutter.modules;
 
+import android.annotation.SuppressLint;
+
 import androidx.annotation.NonNull;
 import androidx.annotation.Nullable;
 
@@ -40,13 +42,14 @@ public void setEnabled(@NonNull Boolean isEnabled) {
         }
     }
 
+    @SuppressLint("WrongConstant")
     @Override
     public void show(@NonNull String reportType, @Nullable List<String> invocationOptions) {
         int[] options = new int[invocationOptions.size()];
         for (int i = 0; i < invocationOptions.size(); i++) {
-            options[i] = ArgsRegistry.getDeserializedValue(invocationOptions.get(i));
+            options[i] = ArgsRegistry.invocationOptions.get(invocationOptions.get(i));
         }
-        int reportTypeInt = ArgsRegistry.getDeserializedValue(reportType);
+        int reportTypeInt = ArgsRegistry.reportTypes.get(reportType);
         BugReporting.show(reportTypeInt, options);
     }
 
@@ -56,49 +59,51 @@ public void setInvocationEvents(@NonNull List<String> events) {
 
         for (int i = 0; i < events.size(); i++) {
             String key = events.get(i);
-            invocationEventsArray[i] = ArgsRegistry.getDeserializedValue(key);
+            invocationEventsArray[i] = ArgsRegistry.invocationEvents.get(key);
         }
 
         BugReporting.setInvocationEvents(invocationEventsArray);
     }
 
+    @SuppressLint("WrongConstant")
     @Override
     public void setReportTypes(@NonNull List<String> types) {
         int[] reportTypesArray = new int[types.size()];
 
         for (int i = 0; i < types.size(); i++) {
             String key = types.get(i);
-            reportTypesArray[i] = ArgsRegistry.getDeserializedValue(key);
+            reportTypesArray[i] = ArgsRegistry.reportTypes.get(key);
         }
 
         BugReporting.setReportTypes(reportTypesArray);
     }
 
     @Override
     public void setExtendedBugReportMode(@NonNull String mode) {
-        final ExtendedBugReport.State resolvedMode = ArgsRegistry.getDeserializedValue(mode);
+        final ExtendedBugReport.State resolvedMode = ArgsRegistry.extendedBugReportStates.get(mode);
         BugReporting.setExtendedBugReportState(resolvedMode);
     }
 
+    @SuppressLint("WrongConstant")
     @Override
     public void setInvocationOptions(@NonNull List<String> options) {
         int[] resolvedOptions = new int[options.size()];
         for (int i = 0; i < options.size(); i++) {
-            resolvedOptions[i] = ArgsRegistry.getDeserializedValue(options.get(i));
+            resolvedOptions[i] = ArgsRegistry.invocationOptions.get(options.get(i));
         }
         BugReporting.setOptions(resolvedOptions);
     }
 
     @Override
     public void setFloatingButtonEdge(@NonNull String edge, @NonNull Long offset) {
-        final InstabugFloatingButtonEdge resolvedEdge = ArgsRegistry.getDeserializedValue(edge);
+        final InstabugFloatingButtonEdge resolvedEdge = ArgsRegistry.floatingButtonEdges.get(edge);
         BugReporting.setFloatingButtonEdge(resolvedEdge);
         BugReporting.setFloatingButtonOffset(offset.intValue());
     }
 
     @Override
     public void setVideoRecordingFloatingButtonPosition(@NonNull String position) {
-        final InstabugVideoRecordingButtonPosition resolvedPosition = ArgsRegistry.getDeserializedValue(position);
+        final InstabugVideoRecordingButtonPosition resolvedPosition = ArgsRegistry.recordButtonPositions.get(position);
         BugReporting.setVideoRecordingFloatingButtonPosition(resolvedPosition);
     }
 
@@ -155,13 +160,14 @@ public void setDisclaimerText(@NonNull String text) {
         BugReporting.setDisclaimerText(text);
     }
 
+    @SuppressLint("WrongConstant")
     @Override
     public void setCommentMinimumCharacterCount(@NonNull Long limit, @Nullable List<String> reportTypes) {
         int[] reportTypesArray = reportTypes == null ? new int[0] : new int[reportTypes.size()];
         if(reportTypes != null){
         for (int i = 0; i < reportTypes.size(); i++) {
             String key = reportTypes.get(i);
-            reportTypesArray[i] = ArgsRegistry.getDeserializedValue(key);
+            reportTypesArray[i] = ArgsRegistry.reportTypes.get(key);
         }
     }
         BugReporting.setCommentMinimumCharacterCount(limit.intValue(), reportTypesArray);

android/src/main/java/com/instabug/flutter/modules/FeatureRequestsApi.java

@@ -1,5 +1,7 @@
 package com.instabug.flutter.modules;
 
+import android.annotation.SuppressLint;
+
 import androidx.annotation.NonNull;
 
 import com.instabug.featuresrequest.FeatureRequests;
@@ -22,11 +24,12 @@ public void show() {
         FeatureRequests.show();
     }
 
+    @SuppressLint("WrongConstant")
     @Override
     public void setEmailFieldRequired(@NonNull Boolean isRequired, @NonNull List<String> actionTypes) {
         int[] actions = new int[actionTypes.size()];
         for (int i = 0; i < actionTypes.size(); i++) {
-            actions[i] = ArgsRegistry.getDeserializedValue(actionTypes.get(i));
+            actions[i] = ArgsRegistry.actionTypes.get(actionTypes.get(i));
         }
 
         FeatureRequests.setEmailFieldRequired(isRequired, actions);

android/src/main/java/com/instabug/flutter/modules/InstabugApi.java

@@ -12,17 +12,18 @@
 
 import com.instabug.flutter.util.ArgsRegistry;
 import com.instabug.flutter.generated.InstabugPigeon;
-import com.instabug.flutter.util.ArgsRegistry;
 import com.instabug.flutter.util.Reflection;
 import com.instabug.flutter.util.ThreadManager;
 import com.instabug.library.Feature;
 import com.instabug.library.Instabug;
 import com.instabug.library.InstabugColorTheme;
 import com.instabug.library.InstabugCustomTextPlaceHolder;
 import com.instabug.library.Platform;
+import com.instabug.library.internal.module.InstabugLocale;
 import com.instabug.library.invocation.InstabugInvocationEvent;
 import com.instabug.library.model.NetworkLog;
 import com.instabug.library.ui.onboarding.WelcomeMessage;
+import com.instabug.library.visualusersteps.State;
 
 import org.json.JSONObject;
 
@@ -87,7 +88,7 @@ public void start(@NonNull String token, @NonNull List<String> invocationEvents)
         InstabugInvocationEvent[] invocationEventsArray = new InstabugInvocationEvent[invocationEvents.size()];
         for (int i = 0; i < invocationEvents.size(); i++) {
             String key = invocationEvents.get(i);
-            invocationEventsArray[i] = ArgsRegistry.getDeserializedValue(key);
+            invocationEventsArray[i] = ArgsRegistry.invocationEvents.get(key);
         }
 
         final Application application = (Application) context;
@@ -104,8 +105,8 @@ public void show() {
 
     @Override
     public void showWelcomeMessageWithMode(@NonNull String mode) {
-        WelcomeMessage.State resolvedWelcomeMessageMode = ArgsRegistry.getDeserializedValue(mode);
-        Instabug.showWelcomeMessage(resolvedWelcomeMessageMode);
+        WelcomeMessage.State resolvedMode = ArgsRegistry.welcomeMessageStates.get(mode);
+        Instabug.showWelcomeMessage(resolvedMode);
     }
 
     @Override
@@ -130,22 +131,20 @@ public void logOut() {
 
     @Override
     public void setLocale(@NonNull String locale) {
-        Locale resolvedLocale = ArgsRegistry.getDeserializedValue(locale);
-        Instabug.setLocale(resolvedLocale);
+        final InstabugLocale resolvedLocale = ArgsRegistry.locales.get(locale);
+        Instabug.setLocale(new Locale(resolvedLocale.getCode(), resolvedLocale.getCountry()));
     }
 
     @Override
     public void setColorTheme(@NonNull String theme) {
-        InstabugColorTheme resolvedTheme = ArgsRegistry.getDeserializedValue(theme);
-        if (resolvedTheme != null) {
-            Instabug.setColorTheme(resolvedTheme);
-        }
+        InstabugColorTheme resolvedTheme = ArgsRegistry.colorThemes.get(theme);
+        Instabug.setColorTheme(resolvedTheme);
     }
 
     @Override
     public void setWelcomeMessageMode(@NonNull String mode) {
-        WelcomeMessage.State resolvedWelcomeMessageMode = ArgsRegistry.getDeserializedValue(mode);
-        Instabug.setWelcomeMessageState(resolvedWelcomeMessageMode);
+        WelcomeMessage.State resolvedMode = ArgsRegistry.welcomeMessageStates.get(mode);
+        Instabug.setWelcomeMessageState(resolvedMode);
     }
 
     @Override
@@ -164,7 +163,7 @@ public void setSessionProfilerEnabled(@NonNull Boolean enabled) {
 
     @Override
     public void setValueForStringWithKey(@NonNull String value, @NonNull String key) {
-        InstabugCustomTextPlaceHolder.Key resolvedKey = ArgsRegistry.getDeserializedValue(key);
+        InstabugCustomTextPlaceHolder.Key resolvedKey = ArgsRegistry.placeholders.get(key);
         placeHolder.set(resolvedKey, value);
         Instabug.setCustomTextPlaceHolders(placeHolder);
     }
@@ -254,7 +253,8 @@ public void setSdkDebugLogsLevel(@NonNull String level) {
     @Override
     public void setReproStepsMode(@NonNull String mode) {
         try {
-            Instabug.setReproStepsState(ArgsRegistry.getDeserializedValue(mode));
+            final State resolvedMode = ArgsRegistry.reproStates.get(mode);
+            Instabug.setReproStepsState(resolvedMode);
         } catch (Exception e) {
             e.printStackTrace();
         }