Skip to content

Commit c2a24cf

Browse files
Merge pull request #543 from Instabug/fix/set-repro-steps-config
2 parents 19a600b + 0d7d526 commit c2a24cf

File tree

6 files changed

+13
-7
lines changed

6 files changed

+13
-7
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,9 @@
11
# Changelog
2+
## [Unreleased](https://github.com/Instabug/Instabug-Flutter/compare/v14.1.0...dev)
3+
4+
### Fixed
5+
6+
- Fixed an issue with `SetReproStepsConfig` on Android platform ([#543](https://github.com/Instabug/Instabug-Flutter/pull/543)).
27

38
## [14.1.0](https://github.com/Instabug/Instabug-Flutter/compare/v14.0.0...v14.1.0) (January 2, 2025)
49

android/src/main/java/com/instabug/flutter/modules/InstabugApi.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
import com.instabug.flutter.util.ArgsRegistry;
1414
import com.instabug.flutter.util.Reflection;
1515
import com.instabug.flutter.util.ThreadManager;
16+
import com.instabug.library.ReproMode;
1617
import com.instabug.library.internal.crossplatform.CoreFeature;
1718
import com.instabug.library.internal.crossplatform.CoreFeaturesState;
1819
import com.instabug.library.internal.crossplatform.FeaturesStateListener;
@@ -334,7 +335,7 @@ public void setReproStepsConfig(@Nullable String bugMode, @Nullable String crash
334335

335336
if (crashMode != null) {
336337
final Integer resolvedCrashMode = ArgsRegistry.reproModes.get(crashMode);
337-
builder.setIssueMode(IssueType.Crash, resolvedCrashMode);
338+
builder.setIssueMode(IssueType.AllCrashes, resolvedCrashMode);
338339
}
339340

340341
if (sessionReplayMode != null) {

android/src/test/java/com/instabug/flutter/InstabugApiTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ public void testSetReproStepsConfig() {
460460
ReproConfigurations.Builder builder = mReproConfigurationsBuilder.constructed().get(0);
461461

462462
verify(builder).setIssueMode(IssueType.Bug, ReproMode.EnableWithScreenshots);
463-
verify(builder).setIssueMode(IssueType.Crash, ReproMode.Disable);
463+
verify(builder).setIssueMode(IssueType.AllCrashes, ReproMode.Disable);
464464
verify(builder).setIssueMode(IssueType.SessionReplay, ReproMode.Disable);
465465
verify(builder).build();
466466

example/ios/InstabugTests/InstabugApiTests.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,7 @@ - (void)testSetReproStepsConfig {
325325
[self.api setReproStepsConfigBugMode:bugMode crashMode:crashMode sessionReplayMode:sessionReplayMode error:&error];
326326

327327
OCMVerify([self.mInstabug setReproStepsFor:IBGIssueTypeBug withMode:IBGUserStepsModeEnable]);
328-
OCMVerify([self.mInstabug setReproStepsFor:IBGIssueTypeCrash withMode:IBGUserStepsModeDisable]);
328+
OCMVerify([self.mInstabug setReproStepsFor:IBGIssueTypeAllCrashes withMode:IBGUserStepsModeDisable]);
329329
OCMVerify([self.mInstabug setReproStepsFor:IBGIssueTypeSessionReplay withMode:IBGUserStepsModeDisable]);
330330
}
331331

ios/Classes/Modules/InstabugApi.m

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ - (void)setReproStepsConfigBugMode:(nullable NSString *)bugMode crashMode:(nulla
163163

164164
if (crashMode != nil) {
165165
IBGUserStepsMode resolvedCrashMode = ArgsRegistry.reproModes[crashMode].integerValue;
166-
[Instabug setReproStepsFor:IBGIssueTypeCrash withMode:resolvedCrashMode];
166+
[Instabug setReproStepsFor:IBGIssueTypeAllCrashes withMode:resolvedCrashMode];
167167
}
168168

169169
if (sessionReplayMode != nil) {

lib/src/modules/instabug.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -449,9 +449,9 @@ class Instabug {
449449
}
450450

451451
return _host.setReproStepsConfig(
452-
bugMode.toString(),
453-
crashMode.toString(),
454-
sessionReplayMode.toString(),
452+
bugMode?.toString(),
453+
crashMode?.toString(),
454+
sessionReplayMode?.toString(),
455455
);
456456
}
457457

0 commit comments

Comments
 (0)