Merge pull request #170 from Instabug/fix/android-start-api

[MOB-4959] Fix Instabug.start API when called on Android

Author: Ali Abdelfattah

.gitignore

@@ -30,6 +30,7 @@
 .pub/
 pubspec.lock
 build/
+coverage/
 
 # Android related
 **/android/**/gradle-wrapper.jar

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## master
 
 * Change all `void ... async` methods to `Future<void> ... async` so that callers can use `await`.
+* Fixes a crash when Instabug.start API is called on Android.
 
 ## v9.1.9 (2021-05-11)
 

lib/Instabug.dart

@@ -6,6 +6,7 @@ import 'dart:typed_data';
 import 'dart:ui';
 
 import 'package:flutter/services.dart';
+import 'package:instabug_flutter/utils/platform_manager.dart';
 
 enum InvocationEvent {
   shake,
@@ -102,11 +103,13 @@ class Instabug {
   /// the SDK's UI.
   static Future<void> start(
       String token, List<InvocationEvent> invocationEvents) async {
-    final List<String> invocationEventsStrings =
-        invocationEvents.map((e) => e.toString()).toList(growable: false);
-    final List<dynamic> params = <dynamic>[token, invocationEventsStrings];
-    await _channel.invokeMethod<Object>(
-        'startWithToken:invocationEvents:', params);
+    if (PlatformManager.instance.isIOS()) {
+      final List<String> invocationEventsStrings =
+          invocationEvents.map((e) => e.toString()).toList(growable: false);
+      final List<dynamic> params = <dynamic>[token, invocationEventsStrings];
+      await _channel.invokeMethod<Object>(
+          'startWithToken:invocationEvents:', params);
+    }
   }
 
   /// Shows the welcome message in a specific mode.

lib/utils/platform_manager.dart

@@ -0,0 +1,15 @@
+
+import 'dart:io';
+
+class PlatformManager {
+  static PlatformManager _platform = PlatformManager();
+
+  static PlatformManager get instance => _platform;
+
+  static void setPlatformInstance(PlatformManager platform) {
+    _platform = platform;
+  }
+
+  bool isAndroid() => Platform.isAndroid;
+  bool isIOS() => Platform.isIOS;
+}

test/instabug_flutter_test.dart

@@ -16,8 +16,16 @@ import 'package:instabug_flutter/Replies.dart';
 import 'package:instabug_flutter/Surveys.dart';
 import 'package:instabug_flutter/models/crash_data.dart';
 import 'package:instabug_flutter/models/exception_data.dart';
+import 'package:instabug_flutter/utils/platform_manager.dart';
+import 'package:mockito/annotations.dart';
+import 'package:mockito/mockito.dart';
 import 'package:stack_trace/stack_trace.dart';
 
+import 'instabug_flutter_test.mocks.dart';
+
+@GenerateMocks([
+  PlatformManager,
+])
 void main() {
   WidgetsFlutterBinding.ensureInitialized();
   final List<MethodCall> log = <MethodCall>[];
@@ -32,6 +40,7 @@ void main() {
   const Map<String, String> userAttributePair = <String, String>{
     'gender': 'female'
   };
+  late MockPlatformManager mockPlatform;
 
   setUpAll(() async {
     const MethodChannel('instabug_flutter')
@@ -50,11 +59,19 @@ void main() {
     });
   });
 
+  setUp(() {
+    mockPlatform = MockPlatformManager();
+    PlatformManager.setPlatformInstance(mockPlatform);
+  });
+
   tearDown(() async {
     log.clear();
   });
 
-  test('startWithToken:invocationEvents: Test', () async {
+  test('startWithToken:invocationEvents: should be called on iOS',
+      () async {
+    when(mockPlatform.isIOS()).thenAnswer((_) => true);
+
     Instabug.start(appToken, invocationEvents);
     final List<dynamic> args = <dynamic>[
       appToken,

test/instabug_flutter_test.mocks.dart

@@ -0,0 +1,30 @@
+// Mocks generated by Mockito 5.0.10 from annotations
+// in instabug_flutter/example/ios/.symlinks/plugins/instabug_flutter/test/instabug_flutter_test.dart.
+// Do not manually edit this file.
+
+import 'package:instabug_flutter/utils/platform_manager.dart' as _i2;
+import 'package:mockito/mockito.dart' as _i1;
+
+// ignore_for_file: avoid_redundant_argument_values
+// ignore_for_file: comment_references
+// ignore_for_file: invalid_use_of_visible_for_testing_member
+// ignore_for_file: prefer_const_constructors
+// ignore_for_file: unnecessary_parenthesis
+
+/// A class which mocks [PlatformManager].
+///
+/// See the documentation for Mockito's code generation for more information.
+class MockPlatformManager extends _i1.Mock implements _i2.PlatformManager {
+  MockPlatformManager() {
+    _i1.throwOnMissingStub(this);
+  }
+
+  @override
+  bool isAndroid() =>
+      (super.noSuchMethod(Invocation.method(#isAndroid, []), returnValue: false)
+          as bool);
+  @override
+  bool isIOS() =>
+      (super.noSuchMethod(Invocation.method(#isIOS, []), returnValue: false)
+          as bool);
+}