Skip to content

Commit 2db4a27

Browse files
Add missing keys for Replies notification
repliesNotificationTeamName repliesNotificationReplyButton repliesNotificationDismissButton
1 parent bb9717f commit 2db4a27

File tree

4 files changed

+17
-1
lines changed

4 files changed

+17
-1
lines changed

android/src/main/java/com/instabug/instabugflutter/ArgsRegistry.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,9 @@ static void registerCustomTextPlaceHolderKeysArgs(Map<String, Object> args) {
189189
args.put("CustomTextPlaceHolderKey.betaWelcomeMessageFinishStepContent", InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_FINISH_STEP_CONTENT);
190190
args.put("CustomTextPlaceHolderKey.liveWelcomeMessageTitle", InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_TITLE);
191191
args.put("CustomTextPlaceHolderKey.liveWelcomeMessageContent", InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_CONTENT);
192+
args.put("CustomTextPlaceHolderKey.repliesNotificationTeamName", InstabugCustomTextPlaceHolder.Key.CHATS_TEAM_STRING_NAME);
193+
args.put("CustomTextPlaceHolderKey.repliesNotificationReplyButton", InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_REPLY_BUTTON);
194+
args.put("CustomTextPlaceHolderKey.repliesNotificationDismissButton", InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_DISMISS_BUTTON);
192195
}
193196

194197
static void registerInstabugReportTypesArgs(Map<String, Object> args) {

android/src/test/java/com/instabug/instabugflutter/ArgsRegistryTest.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,9 @@ private List<InstabugCustomTextPlaceHolder.Key> getCurrentlySupportedKeysBySDK()
283283
keys.add(InstabugCustomTextPlaceHolder.Key.BETA_WELCOME_MESSAGE_FINISH_STEP_CONTENT);
284284
keys.add(InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_TITLE);
285285
keys.add(InstabugCustomTextPlaceHolder.Key.LIVE_WELCOME_MESSAGE_CONTENT);
286+
keys.add(InstabugCustomTextPlaceHolder.Key.CHATS_TEAM_STRING_NAME);
287+
keys.add(InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_REPLY_BUTTON);
288+
keys.add(InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_DISMISS_BUTTON);
286289
return keys;
287290
}
288291

@@ -329,6 +332,9 @@ private List<InstabugCustomTextPlaceHolder.Key> getAllCustomTextPlaceHolderKeys(
329332
keys.add(InstabugCustomTextPlaceHolder.Key.SURVEYS_WELCOME_SCREEN_SUBTITLE);
330333
keys.add(InstabugCustomTextPlaceHolder.Key.SURVEYS_WELCOME_SCREEN_BUTTON);
331334
keys.add(InstabugCustomTextPlaceHolder.Key.REQUEST_FEATURE);
335+
keys.add(InstabugCustomTextPlaceHolder.Key.CHATS_TEAM_STRING_NAME);
336+
keys.add(InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_REPLY_BUTTON);
337+
keys.add(InstabugCustomTextPlaceHolder.Key.REPLIES_NOTIFICATION_DISMISS_BUTTON);
332338
return keys;
333339
}
334340
}

ios/Classes/InstabugFlutterPlugin.m

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -900,6 +900,10 @@ + (NSDictionary *)constants {
900900
@"CustomTextPlaceHolderKey.liveWelcomeMessageTitle": kIBGLiveWelcomeMessageTitle,
901901
@"CustomTextPlaceHolderKey.liveWelcomeMessageContent": kIBGLiveWelcomeMessageContent,
902902

903+
@"CustomTextPlaceHolderKey.repliesNotificationTeamName": kIBGTeamStringName,
904+
@"CustomTextPlaceHolderKey.repliesNotificationReplyButton": kIBGReplyButtonTitleStringName,
905+
@"CustomTextPlaceHolderKey.repliesNotificationDismissButton": kIBGDismissButtonTitleStringName,
906+
903907
@"ReportType.bug": @(IBGBugReportingReportTypeBug),
904908
@"ReportType.feedback": @(IBGBugReportingReportTypeFeedback),
905909
@"ReportType.question": @(IBGBugReportingReportTypeQuestion),

lib/Instabug.dart

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,10 @@ enum CustomTextPlaceHolderKey {
7676
betaWelcomeMessageFinishStepTitle,
7777
betaWelcomeMessageFinishStepContent,
7878
liveWelcomeMessageTitle,
79-
liveWelcomeMessageContent
79+
liveWelcomeMessageContent,
80+
repliesNotificationTeamName,
81+
repliesNotificationReplyButton,
82+
repliesNotificationDismissButton
8083
}
8184

8285
enum ReproStepsMode { enabled, disabled, enabledWithNoScreenshots }

0 commit comments

Comments
 (0)