[MOB-10972] Fix setValueForStringWithKey null exceptions (#310)

* Add a check for string key existence on Android

* Add log message if a key doesn't exist on Android

* Add a check for string key existence on iOS

* Add log message if key doesn't exist on iOS

* Update CHANGELOG.md

Author: DavidMina96

CHANGELOG.md

@@ -1,6 +1,7 @@
 ## Unreleased
 
 * Removes redundant native logs
+* Fixes a NullPointerException when overriding a string key that doesn't exist on Android 
 
 ## 11.5.0 (2022-11-24)
 

android/src/main/java/com/instabug/flutter/modules/InstabugApi.java

@@ -163,9 +163,14 @@ public void setSessionProfilerEnabled(@NonNull Boolean enabled) {
 
     @Override
     public void setValueForStringWithKey(@NonNull String value, @NonNull String key) {
-        InstabugCustomTextPlaceHolder.Key resolvedKey = ArgsRegistry.placeholders.get(key);
-        placeHolder.set(resolvedKey, value);
-        Instabug.setCustomTextPlaceHolders(placeHolder);
+        if(ArgsRegistry.placeholders.containsKey(key)) {
+            InstabugCustomTextPlaceHolder.Key resolvedKey = ArgsRegistry.placeholders.get(key);
+            placeHolder.set(resolvedKey, value);
+            Instabug.setCustomTextPlaceHolders(placeHolder);
+        }
+        else {
+            Log.i(TAG, "Instabug: " + key +  " is only relevant to iOS.");
+        }
     }
 
     @Override

ios/Classes/Modules/InstabugApi.m

@@ -90,8 +90,14 @@ - (void)setSessionProfilerEnabledEnabled:(NSNumber *)enabled error:(FlutterError
 }
 
 - (void)setValueForStringWithKeyValue:(NSString *)value key:(NSString *)key error:(FlutterError *_Nullable *_Nonnull)error {
-    NSString *resolvedKey = ArgsRegistry.placeholders[key];
-    [Instabug setValue:value forStringWithKey:resolvedKey];
+    if ([ArgsRegistry.placeholders objectForKey:key]) {
+        NSString *resolvedKey = ArgsRegistry.placeholders[key];
+        [Instabug setValue:value forStringWithKey:resolvedKey];
+    }
+    else {
+        NSString *logMessage = [NSString stringWithFormat: @"%@%@%@", @"Instabug: ", key,  @" is only relevant to Android."];
+        NSLog(@"%@", logMessage);
+    }
 }
 
 - (void)appendTagsTags:(NSArray<NSString *> *)tags error:(FlutterError *_Nullable *_Nonnull)error {