📝 register instabug app class in manifest only if there is no other class registered and remove it from manifest on uninstalling instabug

Author: salmamali

plugin.xml

@@ -83,6 +83,7 @@
         <source-file src="src/android/IBGPlugin.java" target-dir="src/com/instabug/cordova/plugin"/>
         <source-file src="src/android/MyApplication.java" target-dir="src/com/instabug/cordova/plugin"/>
         <hook type="before_plugin_install" src="scripts/android/before_plugin_install.js"/>
+        <hook type="before_plugin_uninstall" src="scripts/android/before_plugin_uninstall.js"/>
     </platform>
 
     <!-- ios -->

scripts/android/before_plugin_install.js

@@ -54,6 +54,6 @@ module.exports = function(ctx) {
       );
       writeIbgBuildGradle(buildGradle);
     }
-    return editManist(ctx);
+    return editManist(ctx, true);
   }
 };

scripts/android/before_plugin_uninstall.js

@@ -0,0 +1,4 @@
+const editManifest = require('./edit_manifest');
+module.exports = (ctx) => {
+    return editManifest(ctx, false);
+}

scripts/android/edit_manifest.js

@@ -1,37 +1,45 @@
-module.exports = function(ctx) {
-    console.log('INNN');
-    const fs = ctx.requireCordovaModule('fs');
-    const path = ctx.requireCordovaModule('path');
-    const Q = ctx.requireCordovaModule('q');
-    const xml = ctx.requireCordovaModule('cordova-common').xmlHelpers;
+module.exports = (ctx, isInstalling) => {
+  const fs = ctx.requireCordovaModule('fs');
+  const path = ctx.requireCordovaModule('path');
+  const Q = ctx.requireCordovaModule('q');
+  const xml = ctx.requireCordovaModule('cordova-common').xmlHelpers;
 
-    const deferred = Q.defer();
-    const platformPath = path.join(ctx.opts.projectRoot, './platforms/android');
-    const manifestPaths = [
-        path.join(platformPath, './AndroidManifest.xml'),
-        path.join(platformPath, './app/src/main/AndroidManifest.xml'),
-    ];
+  const deferred = Q.defer();
+  const platformPath = path.join(ctx.opts.projectRoot, './platforms/android');
+  const manifestPaths = [
+    path.join(platformPath, './AndroidManifest.xml'),
+    path.join(platformPath, './app/src/main/AndroidManifest.xml')
+  ];
 
-    const manifestPath = manifestPaths.find((filepath) => {
-        try {
-            fs.accessSync(filepath, fs.constants.F_OK)
-            return true
-        } catch (err) {
-            return false
-        }
-    });
+  const manifestPath = manifestPaths.find(filepath => {
+    try {
+      fs.accessSync(filepath, fs.constants.F_OK);
+      return true;
+    } catch (err) {
+      return false;
+    }
+  });
 
-    var doc;
+  if (manifestPath != null) {
+    const appName = 'com.instabug.cordova.plugin.MyApplication';
+    let doc = xml.parseElementtreeSync(manifestPath);
+    let appAttr = doc.getroot().find('./application').attrib['android:name'];
 
-    if (manifestPath != null) {
-        doc = xml.parseElementtreeSync(manifestPath)
-        doc.getroot().find('./application').attrib['android:name'] =
-            'com.instabug.cordova.plugin.MyApplication'
-        fs.writeFileSync(manifestPath, doc.write({ indent: 4 }))
-        deferred.resolve()
+    if (isInstalling) {
+      if (!appAttr) {
+        doc.getroot().find('./application').attrib['android:name'] = appName;
+      }
     } else {
-        deferred.reject(new Error("Can't find AndroidManifest.xml"))
+      if (appAttr === appName) {
+        delete doc.getroot().find('./application').attrib['android:name'];
+      }
     }
+    
+    fs.writeFileSync(manifestPath, doc.write({ indent: 4 }));
+    deferred.resolve();
+  } else {
+    deferred.reject(new Error("Can't find AndroidManifest.xml"));
+  }
 
-    return deferred.promise
-}
+  return deferred.promise;
+};