Skip to content

Commit 7ff42b1

Browse files
DavidMina96HeshamMegid
authored andcommitted
[MOB-11723] Add more String Keys (#177)
Adds new string keys and missing mappings on Android.
1 parent afbc511 commit 7ff42b1

File tree

4 files changed

+24
-3
lines changed

4 files changed

+24
-3
lines changed

CHANGELOG.md

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,15 @@
1313
* portuguesePortugal
1414
* romanian
1515
* slovak
16-
16+
* Adds new string keys:
17+
* insufficientContentMessage
18+
* insufficientContentTitle (iOS)
19+
* screenRecording
20+
* Adds missing mapping for the below string keys on Android:
21+
* audio
22+
* image
23+
* messagesNotificationAndOthers
24+
* okButtonTitle
1725
## 11.3.0 (2022-10-05)
1826

1927
* Bumps Instabug Android SDK to v11.5.1

src/android/util/ArgsRegistry.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ public ArrayList<T> getAll(ArrayList<String> keys) {
6969
put("reportBug", Key.REPORT_BUG);
7070
put("reportFeedback", Key.REPORT_FEEDBACK);
7171
put("conversationsHeaderTitle", Key.CONVERSATIONS_LIST_TITLE);
72+
put("okButtonTitle", Key.BUG_ATTACHMENT_DIALOG_OK_BUTTON);
7273
put("addVoiceMessage", Key.ADD_VOICE_MESSAGE);
7374
put("addImageFromGallery", Key.ADD_IMAGE_FROM_GALLERY);
7475
put("addExtraScreenshot", Key.ADD_EXTRA_SCREENSHOT);
@@ -77,6 +78,10 @@ public ArrayList<T> getAll(ArrayList<String> keys) {
7778
put("recordingMessageToHoldText", Key.VOICE_MESSAGE_PRESS_AND_HOLD_TO_RECORD);
7879
put("recordingMessageToReleaseText", Key.VOICE_MESSAGE_RELEASE_TO_ATTACH);
7980
put("thankYouText", Key.SUCCESS_DIALOG_HEADER);
81+
put("audio", Key.CHATS_TYPE_AUDIO);
82+
put("image", Key.CHATS_TYPE_IMAGE);
83+
put("screenRecording", Key.CHATS_TYPE_VIDEO);
84+
put("messagesNotificationAndOthers", Key.CHATS_MULTIPLE_MESSAGE_NOTIFICATION);
8085
put("videoPressRecord", Key.VIDEO_RECORDING_FAB_BUBBLE_HINT);
8186
put("conversationTextFieldHint", Key.CONVERSATION_TEXT_FIELD_HINT);
8287
put("thankYouAlertText", Key.REPORT_SUCCESSFULLY_SENT);
@@ -111,6 +116,8 @@ public ArrayList<T> getAll(ArrayList<String> keys) {
111116
put("reproStepsListDescription", Key.REPRO_STEPS_LIST_DESCRIPTION);
112117
put("reproStepsListEmptyStateDescription", Key.REPRO_STEPS_LIST_EMPTY_STATE_DESCRIPTION);
113118
put("reproStepsListItemTitle", Key.REPRO_STEPS_LIST_ITEM_NUMBERING_TITLE);
119+
120+
put("insufficientContentMessage", Key.COMMENT_FIELD_INSUFFICIENT_CONTENT);
114121
}};
115122

116123
public static final ArgsMap<State> reproStepsModes = new ArgsMap<State>() {{

src/ios/util/ArgsRegistry.m

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -70,8 +70,8 @@ + (ArgsDictionary *) floatingButtonEdges {
7070
@"cancelButtonTitle": kIBGCancelButtonTitleStringName,
7171
@"thankYouText": kIBGThankYouAlertTitleStringName,
7272
@"audio": kIBGAudioStringName,
73-
@"screenRecording": kIBGScreenRecordingStringName,
7473
@"image": kIBGImageStringName,
74+
@"screenRecording": kIBGScreenRecordingStringName,
7575
@"surveyEnterYourAnswer": kIBGSurveyEnterYourAnswerTextPlaceholder,
7676
@"videoPressRecord": kIBGVideoPressRecordTitle,
7777
@"collectingDataText": kIBGCollectingDataText,
@@ -106,7 +106,10 @@ + (ArgsDictionary *) floatingButtonEdges {
106106
@"reproStepsListHeader": kIBGReproStepsListTitle,
107107
@"reproStepsListDescription": kIBGReproStepsListHeader,
108108
@"reproStepsListEmptyStateDescription": kIBGReproStepsListEmptyStateLabel,
109-
@"reproStepsListItemTitle": kIBGReproStepsListItemName
109+
@"reproStepsListItemTitle": kIBGReproStepsListItemName,
110+
111+
@"insufficientContentMessage": kIBGInsufficientContentMessageStringName,
112+
@"insufficientContentTitle": kIBGInsufficientContentTitleStringName,
110113
};
111114
}
112115

src/modules/ArgsRegistry.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ namespace ArgsRegistry {
5757
thankYouText = "thankYouText",
5858
audio = "audio",
5959
image = "image",
60+
screenRecording = "screenRecording",
6061
team = "team",
6162
messagesNotification = "messagesNotification",
6263
messagesNotificationAndOthers = "messagesNotificationAndOthers",
@@ -89,6 +90,8 @@ namespace ArgsRegistry {
8990
reproStepsListDescription = "reproStepsListDescription",
9091
reproStepsListEmptyStateDescription = "reproStepsListEmptyStateDescription",
9192
reproStepsListItemTitle = "reproStepsListItemTitle",
93+
insufficientContentMessage = "insufficientContentMessage",
94+
insufficientContentTitle = "insufficientContentTitle",
9295
}
9396

9497
export enum reproStepsMode {

0 commit comments

Comments
 (0)