Skip to content

Commit 2c2a992

Browse files
authored
🤝 Merge pull request #7 from Instabug/feature/1.12_release
Feature/1.12 release
2 parents 91380da + 676a389 commit 2c2a992

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

51 files changed

+221
-127
lines changed

build.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,6 @@ android {
2121
}
2222

2323
dependencies {
24-
compile 'com.instabug.library:instabug:4.13.3'
24+
compile 'com.instabug.library:instabug:4.13.5'
2525
compile 'com.android.support:multidex:1.0.0'
2626
}

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "instabug-cordova",
3-
"version": "1.11.0",
3+
"version": "1.11.2",
44
"description": "The purpose of this plugin is to simplify the process of integrating the Instabug SDK in a hybrid application, as well as to provide an interface to interfacing with the SDK through JavaScript.",
55
"main": "index.js",
66
"repository": {

src/android/IBGPlugin.java

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,12 @@ public boolean execute(final String action, JSONArray args, final CallbackContex
181181
} else if ("setThresholdForReshowingSurveyAfterDismiss".equals(action)) {
182182
setThresholdForReshowingSurveyAfterDismiss(callbackContext, args.optInt(0), args.optInt(1));
183183

184+
} else if ("showFeatureRequests".equals(action)) {
185+
showFeatureRequests(callbackContext);
186+
187+
} else if ("setShouldShowSurveysWelcomeScreen".equals(action)) {
188+
setShouldShowSurveysWelcomeScreen(callbackContext, args.optInt(0));
189+
184190
} else {
185191
// Method not found.
186192
return false;
@@ -789,6 +795,39 @@ private void setThresholdForReshowingSurveyAfterDismiss(final CallbackContext ca
789795
} else callbackContext.error("Session count and days count must be provided.");
790796
}
791797

798+
/**
799+
* Shows the UI for feature requests list
800+
*
801+
* @param callbackContext
802+
* Used when calling back into JavaScript
803+
*/
804+
private void showFeatureRequests(final CallbackContext callbackContext) {
805+
try {
806+
Instabug.showFeatureRequests();
807+
callbackContext.success();
808+
} catch (IllegalStateException e) {
809+
callbackContext.error(errorMsg);
810+
}
811+
}
812+
813+
/**
814+
* Set Surveys welcome screen enabled, default value is false
815+
*
816+
*
817+
* @param shouldShow whether should show welcome screen Surveys before surveys or not
818+
*
819+
* @param callbackContext
820+
* Used when calling back into JavaScript
821+
*/
822+
private void setShouldShowSurveysWelcomeScreen(final CallbackContext callbackContext, boolean shouldShow) {
823+
try {
824+
Instabug.setShouldShowSurveysWelcomeScreen(shouldShow);
825+
callbackContext.success();
826+
} catch (IllegalStateException e) {
827+
callbackContext.error(errorMsg);
828+
}
829+
}
830+
792831
/**
793832
* Adds intent extras for all options passed to activate().
794833
*/

src/ios/IBGPlugin.m

Lines changed: 36 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -719,6 +719,42 @@ - (void) setAutoShowingSurveysEnabled:(CDVInvokedUrlCommand*)command
719719
[self.commandDelegate sendPluginResult:result callbackId:[command callbackId]];
720720
}
721721

722+
/**
723+
* Shows the UI for feature requests list
724+
*
725+
* @param {CDVInvokedUrlCommand*} command
726+
* The command sent from JavaScript
727+
*/
728+
- (void) showFeatureRequests:(CDVInvokedUrlCommand*)command
729+
{
730+
[Instabug showFeatureRequests];
731+
[self sendSuccessResult:command];
732+
}
733+
734+
/**
735+
* Sets a threshold for numbers of sessions and another for number of days
736+
* required before a survey, that has been dismissed once, would show again.
737+
*
738+
* @param {CDVInvokedUrlCommand*} command
739+
* The command sent from JavaScript
740+
*/
741+
- (void) setShouldShowSurveysWelcomeScreen:(CDVInvokedUrlCommand*)command
742+
{
743+
CDVPluginResult* result;
744+
745+
BOOL shouldShowWelcomeScreen = [command argumentAtIndex:0];
746+
747+
if (shouldShowWelcomeScreen) {
748+
[Instabug setShouldShowSurveysWelcomeScreen:[[command argumentAtIndex:0] boolValue]];
749+
result = [CDVPluginResult resultWithStatus:CDVCommandStatus_OK];
750+
} else {
751+
result = [CDVPluginResult resultWithStatus:CDVCommandStatus_ERROR
752+
messageAsString:@"A boolean value must be provided."];
753+
}
754+
755+
[self.commandDelegate sendPluginResult:result callbackId:[command callbackId]];
756+
}
757+
722758
/**
723759
* Wrapper method for applying all provided options.
724760
*

src/ios/Instabug.framework/Headers/Instabug.h

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
66
Copyright: (c) 2013-2018 by Instabug, Inc., all rights reserved.
77
8-
Version: 7.12.5
8+
Version: 7.12.7
99
*/
1010

1111
#import <Foundation/Foundation.h>
@@ -1266,6 +1266,17 @@ OBJC_EXTERN void IBGNSLogWithLevel(NSString *format, va_list args, IBGLogLevel l
12661266
*/
12671267
+ (void)setThresholdForReshowingSurveyAfterDismiss:(NSInteger)sessionCount daysCount:(NSInteger)daysCount;
12681268

1269+
/**
1270+
@brief Setting an option for all the surveys to show a welcome screen before the user starts taking the survey.
1271+
1272+
@discussion By enabling this option, any survey that appears to the user will have a welcome screen with a title, subtitle
1273+
and a button that if clicked, will take the user to the survey. All the strings in the welcome screen have a default value
1274+
and localized. They can also be modified using the strings API. The default value of this option is false.
1275+
1276+
@param shouldShowWelcomeScreen : Boolean for setting wether the welcome screen should show.
1277+
*/
1278+
+ (void)setShouldShowSurveysWelcomeScreen:(BOOL)shouldShowWelcomeScreen;
1279+
12691280
#pragma mark - Feature Requests
12701281
/// ------------------------
12711282
/// @name Feature Requests

src/ios/Instabug.framework/Info.plist

0 Bytes
Binary file not shown.

src/ios/Instabug.framework/Instabug

-80.3 KB
Binary file not shown.

src/ios/Instabug.framework/_CodeSignature/CodeResources

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,11 +6,11 @@
66
<dict>
77
<key>Headers/Instabug.h</key>
88
<data>
9-
wwOLwWc4iG8u5RCEgnEbViLJru4=
9+
SGNYZhDFT2EX7GCTETfClZTQXJY=
1010
</data>
1111
<key>Info.plist</key>
1212
<data>
13-
HPAveR0c+whbq5mPNp5qMyz1TnU=
13+
/nPkkrY39eMx9p9uHRbBsHajFMw=
1414
</data>
1515
<key>Modules/module.modulemap</key>
1616
<data>
@@ -23,11 +23,11 @@
2323
<dict>
2424
<key>hash</key>
2525
<data>
26-
wwOLwWc4iG8u5RCEgnEbViLJru4=
26+
SGNYZhDFT2EX7GCTETfClZTQXJY=
2727
</data>
2828
<key>hash2</key>
2929
<data>
30-
S/NXH4SJqkK91PzzkM9R0MiqjfoJgQeFjfAb7YuTmps=
30+
WKOlkyFQLVjgThj0Q+rMJ+iJKaRVVs+lV56Ly76ap58=
3131
</data>
3232
</dict>
3333
<key>Modules/module.modulemap</key>

src/ios/InstabugCore.framework/Headers/IBGTypes.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
66
Copyright: (c) 2013-2018 by Instabug, Inc., all rights reserved.
77
8-
Version: 7.12.5
8+
Version: 7.12.7
99
*/
1010

1111
#import <UIKit/UIKit.h>

src/ios/InstabugCore.framework/Headers/InstabugCore.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
66
Copyright: (c) 2013-2018 by Instabug, Inc., all rights reserved.
77
8-
Version: 7.12.5
8+
Version: 7.12.7
99
*/
1010

1111
#import <Foundation/Foundation.h>
Binary file not shown.
Binary file not shown.
Binary file not shown.
6 Bytes
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
-2 Bytes
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
0 Bytes
Binary file not shown.
-64 Bytes
Binary file not shown.

0 commit comments

Comments
 (0)