Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update clang-format version #4565

Closed
4 tasks
thewtex opened this issue Apr 8, 2024 · 2 comments · Fixed by #5015
Closed
4 tasks

Update clang-format version #4565

thewtex opened this issue Apr 8, 2024 · 2 comments · Fixed by #5015
Labels
Good first issue A good issue for community members new to contributing type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Style Style changes: no logic impact (indentation, comments, naming)

Comments

@thewtex
Copy link
Member

thewtex commented Apr 8, 2024 •
edited
Loading

Current clang-format is version 8, circa 2019. Update to a newer version to support system clang-format executables available in packages and also provide a ARM macOS binary.

  • Update the ITK/.clang-format style configuration file
  • Update CMake and shell scripts used for running clang-format: CMake/Clang.cmake*, Utilities/ClangFormat/DownloadClangFormat.cmake, Utilities/Maintenance/clang-format.bash, Utilities/Maintenance/git-clang-format.
  • Re-run on the source tree.
  • Update the module in ITKSphinxExamples
@thewtex thewtex added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots Good first issue A good issue for community members new to contributing type:Style Style changes: no logic impact (indentation, comments, naming) labels Apr 8, 2024
@blowekamp
Copy link
Member

I have recently been looking into use pre-commit with the clang-format hooks, which pulls clang-format from pypi

@thewtex
Copy link
Member Author

thewtex commented Apr 12, 2024

Yes, possibly we just go to pre-commit. Discussed more in #4235

@divital-coder divital-coder mentioned this issue Jun 10, 2024
Merged
This was referenced Dec 4, 2024
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue A good issue for community members new to contributing type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Style Style changes: no logic impact (indentation, comments, naming)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update to clang format 19 support hjmjohnson/ITK
2 participants
@thewtex @blowekamp