localdata/get_local_metadata - never used variable(s)

[tgrandje]

This block is flagged by pyflakes and I'm not sure what to make about it:

pynsee/pynsee/localdata/get_local_metadata.py

Lines 63 to 66 in 9dc111f

	list_files = os.listdir(insee_folder_local_metadata)
	list_files = [f for f in list_files if re.search("^doc_.*csv$", f)]
	test_file_available = [f not in list_files for f in all_files]

test_file_available is indeed not used to my knowledge, and list_files seems to be used only to produce that variable (there is a list_files later on, but it's a local variable built from all_files...).

[tgrandje]

The same is true about list_available_file in metadata there:

pynsee/pynsee/metadata/get_activity_list.py

Line 98 in 9dc111f

list_available_file = [not os.path.exists(f) for f in list_expected_files]

(Though list_expected_files is really used later.)

[tgrandje]

Also there for string and list_var_string:

pynsee/pynsee/sirene/search_sirene.py

Lines 253 to 254 in 9dc111f

	list_var_string = [str(b) for b in [kind, number]]
	string = "".join(list_var_string)

[hadrilec]

indeed the above mentioned variables should be removed as unused

[tfardet]

@tgrandje can we close this?