You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Overall requests.Session objects do not seem to be managed consistently (or sometimes even just properly) throughout the code.
Though I don't think it is likely to lead to severe issues, it could be made cleaner and generally more straightforward to understand if with statements were used systematically, together with actual benchmarks to see whether this improves performance.
The text was updated successfully, but these errors were encountered:
I agree using with everywhere in the package is the best option.
Normally, thanks to this commit 17ea1c7, all remaining open sessions should have been closed.
Overall
requests.Session
objects do not seem to be managed consistently (or sometimes even just properly) throughout the code.Though I don't think it is likely to lead to severe issues, it could be made cleaner and generally more straightforward to understand if
with
statements were used systematically, together with actual benchmarks to see whether this improves performance.The text was updated successfully, but these errors were encountered: