Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve session management #148

Open
tfardet opened this issue May 16, 2023 · 2 comments
Open

Improve session management #148

tfardet opened this issue May 16, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@tfardet
Copy link
Collaborator

tfardet commented May 16, 2023

Overall requests.Session objects do not seem to be managed consistently (or sometimes even just properly) throughout the code.
Though I don't think it is likely to lead to severe issues, it could be made cleaner and generally more straightforward to understand if with statements were used systematically, together with actual benchmarks to see whether this improves performance.

@tfardet tfardet added the enhancement New feature or request label May 16, 2023
@hadrilec
Copy link
Contributor

hadrilec commented May 20, 2023

I agree using with everywhere in the package is the best option.
Normally, thanks to this commit 17ea1c7, all remaining open sessions should have been closed.

@tfardet
Copy link
Collaborator Author

tfardet commented Aug 17, 2023

Once #162 is merged, store the session object in the config dict and use it throughout the code (cf. tgradje's comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants