Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data-target='modal2' button not working in demo #363

Closed
Matthew-Myers-Aveniros opened this issue Aug 30, 2017 · 1 comment
Closed

data-target='modal2' button not working in demo #363

Matthew-Myers-Aveniros opened this issue Aug 30, 2017 · 1 comment

Comments

@Matthew-Myers-Aveniros
Copy link

<button data-target="modal2" href='#modal2'class="btn" (click)='openModal2()'>Modal 2 (2)</button>

button 2 (2) not opening modal 2 in the Demo

Is this intended?
rubyboy added a commit that referenced this issue Sep 2, 2017
@rubyboy
docs: Fixed demo modal button
3082ab4 
#363
@rubyboy
Copy link
Contributor

rubyboy commented Sep 2, 2017

@Matthew-Myers-Aveniros thanks heaps for pointing this out. The demo was missing the modal-trigger class on the button (#335 (comment)). This is fixed now.

@rubyboy rubyboy closed this as completed Sep 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rubyboy @Matthew-Myers-Aveniros