Skip to content

Commit 9ac441e

Browse files
committed
Fix logging at level Logger::DEBUG
Previously setting the log level to Logger::DEBUG would have no effect as the log level of the Logger object was not changed. If you set: InfluxDB::Logging.log_level = Logger::DEBUG InfluxDB::Logging::log? would return true, allowing the log statement to proceed, but #log would not do anything because the Logger object was still at its default from initialization, Logger::INFO. By setting the log level directly on the Logger object and removing ::log? we allow the Logger object to determine if a log level needs to be logged or not. This allows debug-level log messages to be displayed.
1 parent 2f4b3fd commit 9ac441e

File tree

1 file changed

+5
-12
lines changed

1 file changed

+5
-12
lines changed

lib/influxdb/logging.rb

Lines changed: 5 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ module Logging # :nodoc:
66

77
class << self
88
attr_writer :logger
9-
attr_writer :log_level
109

1110
def logger
1211
return false if @logger == false
@@ -15,26 +14,20 @@ def logger
1514
end
1615

1716
def log_level
18-
@log_level || Logger::INFO
17+
logger&.level || Logger::INFO
1918
end
2019

21-
def log?(level)
22-
case level
23-
when :debug then log_level <= Logger::DEBUG
24-
when :info then log_level <= Logger::INFO
25-
when :warn then log_level <= Logger::WARN
26-
when :error then log_level <= Logger::ERROR
27-
when :fatal then log_level <= Logger::FATAL
28-
else true
29-
end
20+
def log_level=(level)
21+
return unless logger
22+
23+
logger.level = level
3024
end
3125
end
3226

3327
private
3428

3529
def log(level, message = nil, &block)
3630
return unless InfluxDB::Logging.logger
37-
return unless InfluxDB::Logging.log?(level)
3831

3932
if block_given?
4033
InfluxDB::Logging.logger.send(level.to_sym, PREFIX, &block)

0 commit comments

Comments
 (0)