From a7d1616b5036160bbe52fd7c854ab8e431880acc Mon Sep 17 00:00:00 2001
From: Diptesh Choudhuri <ignisda2001@gmail.com>
Date: Wed, 22 Jan 2025 12:12:57 +0530
Subject: [PATCH] feat(frontend): do not display buttons when no pending
 notifications

---
 apps/frontend/app/routes/_dashboard.tsx | 48 +++++++++++++------------
 1 file changed, 25 insertions(+), 23 deletions(-)

diff --git a/apps/frontend/app/routes/_dashboard.tsx b/apps/frontend/app/routes/_dashboard.tsx
index d75220bbd8..01de04bc30 100644
--- a/apps/frontend/app/routes/_dashboard.tsx
+++ b/apps/frontend/app/routes/_dashboard.tsx
@@ -986,31 +986,33 @@ const Footer = () => {
 				title={`You have ${userPendingNotificationsQuery.data?.length} pending notifications`}
 			>
 				<Stack ref={parent}>
-					{userPendingNotificationsQuery.data ? (
-						userPendingNotificationsQuery.data.map((n, idx) => (
-							<DisplayNotificationContent idx={idx} key={n.id} />
-						))
+					{userPendingNotificationsQuery.data?.map((n, idx) => (
+						<DisplayNotificationContent idx={idx} key={n.id} />
+					))}
+					{(userPendingNotificationsQuery.data?.length || 0) > 0 ? (
+						<Button
+							ta="right"
+							variant="subtle"
+							size="compact-md"
+							rightSection={<IconChecks />}
+							onClick={() => {
+								const ids = userPendingNotificationsQuery.data?.map(
+									(n) => n.id,
+								);
+								if (!ids) return;
+								notifications.show({
+									color: "green",
+									message: "All notifications will be marked as read",
+								});
+								markUserNotificationsAsAddressedMutation.mutate(ids);
+								setIsNotificationModalOpen(false);
+							}}
+						>
+							Mark all as read
+						</Button>
 					) : (
-						<Text>No notifications</Text>
+						<Text ta="center">No notifications</Text>
 					)}
-					<Button
-						ta="right"
-						variant="subtle"
-						size="compact-md"
-						rightSection={<IconChecks />}
-						onClick={() => {
-							const ids = userPendingNotificationsQuery.data?.map((n) => n.id);
-							if (!ids) return;
-							notifications.show({
-								color: "green",
-								message: "All notifications will be marked as read",
-							});
-							markUserNotificationsAsAddressedMutation.mutate(ids);
-							setIsNotificationModalOpen(false);
-						}}
-					>
-						Mark all as read
-					</Button>
 				</Stack>
 			</Modal>
 			<Container>