Separate invalid-uri error from invalid request and provide no error-url

Signed-off-by: Ivan Kanakarakis <[email protected]>

Author: c00kiemon5ter

src/pyop/exceptions.py

@@ -59,6 +59,11 @@ def to_error_url(self):
         return None
 
 
+class InvalidRedirectURI(InvalidAuthenticationRequest):
+    def to_error_url(self):
+        return None
+
+
 class InvalidTokenRequest(InvalidRequestError):
     def __init__(self, message, parsed_request, oauth_error='invalid_request'):
         super().__init__(message, parsed_request, oauth_error)

src/pyop/request_validator.py

@@ -3,7 +3,9 @@
 from oic.exception import MessageException
 from oic.oic import PREFERENCE2PROVIDER
 
-from .exceptions import InvalidClientRegistrationRequest, InvalidAuthenticationRequest
+from .exceptions import InvalidClientRegistrationRequest
+from .exceptions import InvalidAuthenticationRequest
+from .exceptions import InvalidRedirectURI
 from .util import is_allowed_response_type, find_common_values
 
 logger = logging.getLogger(__name__)
@@ -41,7 +43,7 @@ def redirect_uri_is_in_registered_redirect_uris(provider, authentication_request
     :param authentication_request: authentication request to verify
     :raise InvalidAuthenticationRequest: if the redirect uri is not registered
     """
-    error = InvalidAuthenticationRequest('Redirect uri is not registered',
+    error = InvalidRedirectURI('Redirect uri is not registered',
                                          authentication_request,
                                          oauth_error="invalid_request")
     try:
@@ -63,7 +65,7 @@ def response_type_is_in_registered_response_types(provider, authentication_reque
     :raise InvalidAuthenticationRequest: if the response type is not allowed
     """
     error = InvalidAuthenticationRequest('Response type is not registered',
-                                         authentication_request, 
+                                         authentication_request,
                                          oauth_error='invalid_request')
     try:
         allowed_response_types = provider.clients[authentication_request['client_id']]['response_types']