Skip to content

Commit 938d917

Browse files
committed
Fix icingaforwindows.pfx creation over WinRM and SSH
1 parent c17a5f2 commit 938d917

File tree

5 files changed

+10
-6
lines changed

5 files changed

+10
-6
lines changed

doc/100-General/10-Changelog.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ Released closed milestones can be found on [GitHub](https://github.com/Icinga/ic
2121
* [#710](https://github.com/Icinga/icinga-powershell-framework/pull/710) Fixes various console errors while running Icinga for Windows outside of an administrative shell
2222
* [#714](https://github.com/Icinga/icinga-powershell-framework/pull/714) Fixes missing service environment information during initial setup of Icinga for Windows v1.12 on some systems
2323
* [#715](https://github.com/Icinga/icinga-powershell-framework/pull/715) Fixes internal scheduled task handling and certificate renewal task by setting the user to `LocalSystem` instead of any administrative user or group, ensuring compatibility with all Windows versions as well as managing by using WinRM and SSH
24+
* [#716](https://github.com/Icinga/icinga-powershell-framework/pull/716) Fixes Icinga for Windows certificate creation while using WinRM or SSH for remote connections
2425

2526
## 1.12.0 (2024-03-26)
2627

lib/core/installer/Start-IcingaForWindowsInstallation.psm1

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,8 @@ function Start-IcingaForWindowsInstallation()
317317
}
318318

319319
# Always install the Icinga for Windows certificate
320-
Install-IcingaForWindowsCertificate;
320+
# We need to run the task renewal with our scheduled task to fix errors while using WinRM / SSH
321+
Start-IcingaWindowsScheduledTaskRenewCertificate;
321322
Restart-IcingaForWindows;
322323

323324
# Update configuration and clear swap

lib/core/installer/menu/manage/framework/ToogleFrameworkApiChecks.psm1

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,8 @@ function Invoke-IcingaForWindowsManagementConsoleToggleFrameworkApiChecks()
88
Add-IcingaRESTApiCommand -Command 'Invoke-IcingaCheck*' -Endpoint 'apichecks';
99
}
1010

11-
Install-IcingaForWindowsCertificate;
11+
# We need to run the task renewal with our scheduled task to fix errors while using WinRM / SSH
12+
Start-IcingaWindowsScheduledTaskRenewCertificate;
1213
Enable-IcingaFrameworkApiChecks;
1314
}
1415

lib/core/installer/menu/manage/settings/troubleshooting/Troubleshooting.psm1

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ function Show-IcingaForWindowsMenuManageTroubleshooting()
3737
'Command' = 'Show-IcingaWindowsManagementConsoleYesNoDialog';
3838
'Arguments' = @{
3939
'-Caption' = 'Install Icinga for Windows certificate';
40-
'-Command' = 'Install-IcingaForWindowsCertificate';
40+
'-Command' = 'Start-IcingaWindowsScheduledTaskRenewCertificate';
4141
}
4242
}
4343
},

lib/core/jea/Install-IcingaJeaProfile.psm1

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,11 +22,12 @@ function Install-IcingaJEAProfile()
2222
return;
2323
}
2424

25-
Write-IcingaConsoleNotice 'Writing Icinga for Windows environment information as JEA profile'
25+
Write-IcingaConsoleNotice 'Writing Icinga for Windows environment information as JEA profile';
2626
Write-IcingaJEAProfile -RebuildFramework:$RebuildFramework -AllowScriptBlocks:$AllowScriptBlocks;
27-
Write-IcingaConsoleNotice 'Registering Icinga for Windows JEA profile'
27+
Write-IcingaConsoleNotice 'Registering Icinga for Windows JEA profile';
2828
Register-IcingaJEAProfile -IcingaUser $IcingaUser -TestEnv:$TestEnv -ConstrainedLanguage:$ConstrainedLanguage;
29-
Install-IcingaForWindowsCertificate;
29+
# We need to run the task renewal with our scheduled task to fix errors while using WinRM / SSH
30+
Start-IcingaWindowsScheduledTaskRenewCertificate;
3031
}
3132

3233
Set-Alias -Name 'Update-IcingaJEAProfile' -Value 'Install-IcingaJEAProfile';

0 commit comments

Comments
 (0)