fix handling of multi day rotation entries that end the same day they started #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nilmerg
requested changes
Nov 5, 2025
Contributor
Author
|
When the rotation starts on the same weekday it ends and the start time is later the end time, the start will instead be 12 AM for the first entry. |
nilmerg
requested changes
Nov 6, 2025
Member
nilmerg
left a comment
nilmerg
left a comment
There was a problem hiding this comment.
The bug is fixed. But if you choose e.g. midnight on thursday as end time and today (thursday) as first handoff, the form pretends that the rotation will start immediately, which isn't true.
nilmerg
requested changes
Nov 10, 2025
nilmerg
requested changes
Nov 10, 2025
nilmerg
approved these changes
Nov 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #366
Rotations that have their start on the same day as their to-day, will now have their first entries created correctly.