[ESSI-2062] revise CollectionBrandingInfo model, specs

Author: aploshay

Diff for: app/models/collection_branding_info.rb

@@ -96,23 +96,18 @@ def find_local_dir_name(collection_id, role)
     end  
 
     def generate_image_path!
-      if image_path.blank? && file_set_versions.any?
-        return unless iiif_path_service.lookup_id
+      if image_path.blank? && iiif_path_service.lookup_id.present?
         self.image_path = iiif_path_service.iiif_image_url(size: ESSI.config.dig(:essi, :collection_banner_size))
         save
       end
     end  
 
-    def file_set_versions
-      file_set&.reload&.original_file&.versions || []
-    end
-
     def uploaded_files(uploaded_file_ids)
       return [] if uploaded_file_ids.empty?
       Hyrax::UploadedFile.find(uploaded_file_ids)
     end
 
     def iiif_path_service
-      @iiif_path_service ||= IIIFFileSetPathService.new(file_set)
+      @iiif_path_service ||= IIIFFileSetPathService.new(file_set || {})
     end
 end

Diff for: spec/models/collection_branding_info_spec.rb

@@ -3,9 +3,8 @@
 RSpec.describe CollectionBrandingInfo, type: :model do
   let(:banner) { FactoryBot.build(:collection_branding_banner) }
   let(:file_set) { FactoryBot.create(:file_set, id: 'file_set_id', uri: 'file_set_uri') }
-  let(:version) { double(uri: 'version_uri') }
-  let(:versions) { double(any?: true, all: self, last: version) }
-
+  let(:local_file) { File.open(RSpec.configuration.fixture_path + '/world.png') }
+  let(:local_file_set) { FactoryBot.create(:file_set, content: local_file) }
 
   describe '#initialize' do
     context 'with local_path value provided' do
@@ -101,24 +100,18 @@
         banner.send(:image_path=, nil)
       end
       context 'and unable to generate one' do
-        before do
-          allow(banner).to receive(:file_set_versions).and_return([])
-        end
         it 'returns nil' do
           expect(banner.file_set_image_path).to be_nil
         end
       end
       context 'but able to generate one' do
-        before do
-          allow(banner).to receive(:file_set_versions).and_return(versions)
-          allow(versions).to receive(:all).and_return(versions)
-        end
+        let(:banner) { FactoryBot.build(:collection_branding_banner, file_set_id: local_file_set.id) }
         it 'sets the image_path value' do
           expect(banner).to receive(:image_path=)
           banner.file_set_image_path
         end
         it 'returns the image_path value' do
-          expect(banner.file_set_image_path).to match version.uri
+          expect(banner.file_set_image_path).to match /^http/
         end
       end
     end