-
Notifications
You must be signed in to change notification settings - Fork 21
Deaccession Modal: fix form behavior and formatting #667
Copy link
Copy link
Closed
Labels
FY25 Sprint 22FY25 Sprint 22 (2025-04-23 - 2025-05-07)FY25 Sprint 22 (2025-04-23 - 2025-05-07)GREI Re-archGREI re-architecture-relatedGREI re-architecture-relatedOriginal size: 10SPA.Q2Not related to any specific Q2 featureNot related to any specific Q2 featureSize: 10A percentage of a sprint. 7 hours.A percentage of a sprint. 7 hours.bugSomething isn't workingSomething isn't working
Metadata
Metadata
Assignees
Labels
FY25 Sprint 22FY25 Sprint 22 (2025-04-23 - 2025-05-07)FY25 Sprint 22 (2025-04-23 - 2025-05-07)GREI Re-archGREI re-architecture-relatedGREI re-architecture-relatedOriginal size: 10SPA.Q2Not related to any specific Q2 featureNot related to any specific Q2 featureSize: 10A percentage of a sprint. 7 hours.A percentage of a sprint. 7 hours.bugSomething isn't workingSomething isn't working
What steps does it take to reproduce the issue?
There is not enough border in the modal. This can be fixed by rendering the form group as a column, for example
<Form.Group as={Col}>
If a dataset has a previous dataset version has been deaccessioned, it should not appear in the list of versions that can be deaccessioned.
When the deaccession modal is submitted, there is no loading indicator and button is not disabled while submitting. Instead, it should work like this example: https://github.com/IQSS/dataverse-frontend/blob/281cad0885b8ffcd68e95126c346ab0ef3[…]onfirm-delete-collection-modal/ConfirmDeleteCollectionModal.tsx
When does this issue occur?
Deaccession a Dataset after a previous dataset version has been Deaccessioned
Which page(s) does it occur on?
Deaccession Modal
What happens?
All versions are listed, rather than only non-deaccessioned versions. If there is only one non-deaccessioned version, then the list should not appear at all
When the form is submitted the submit button is not disabled