fixed spacing, removed comments, added test for undefined

Author: ekraffmiller

src/datasets/domain/models/DatasetVersionDiff.ts

@@ -1,5 +1,3 @@
-// Details API
-
 export interface DatasetVersionDiff {
   oldVersion: VersionSummary
   newVersion: VersionSummary

src/datasets/infra/repositories/transformers/datasetVersionDiffTransformers.ts

@@ -1,16 +1,6 @@
 import { AxiosResponse } from 'axios'
 import { DatasetVersionDiff } from '../../../domain/models/DatasetVersionDiff'
 
-/*
- oldVersion: VersionSummaryPayload
-  newVersion: VersionSummaryPayload
-  metadataChanges: MetadataBlockDiffPayload[]
-  filesAdded: FileSummaryPayload[]
-  filesRemoved: FileSummaryPayload[]
-  fileChanges: FileDiffPayload[]
-  filesReplaced: FileReplacementPayload[]
-  TermsOfAccess: FieldDiffPayload[]
- */
 export const transformDatasetVersionDiffResponseToDatasetVersionDiff = (
   response: AxiosResponse
 ): DatasetVersionDiff => {

test/integration/datasets/DatasetsRepository.test.ts

@@ -478,6 +478,7 @@ describe('DatasetsRepository', () => {
       await sut.publishDataset(testDatasetIds.numericId, VersionUpdateType.MAJOR)
       await waitForNoLocks(testDatasetIds.numericId, 10)
     })
+
     test('should return dataset metadata diff between two dataset versions', async () => {
       // Update dataset
       const metadataBlocksRepository = new MetadataBlocksRepository()
@@ -493,8 +494,10 @@ describe('DatasetsRepository', () => {
         '1.0',
         DatasetNotNumberedVersion.DRAFT
       )
+      expect(actual.metadataChanges[0]).not.toBeUndefined()
       expect(actual.metadataChanges[0].blockName).toEqual('Citation Metadata')
     })
+
     test('should return added file diff between two dataset versions', async () => {
       const fileMetadata = {
         description: 'test description',
@@ -528,6 +531,7 @@ describe('DatasetsRepository', () => {
       )
       expect(actual.filesAdded).toEqual(expectedFilesAdded)
     })
+
     test('should return  diff between :latestPublished and :draft', async () => {
       const fileMetadata = {
         description: 'test description',
@@ -561,6 +565,7 @@ describe('DatasetsRepository', () => {
       )
       expect(actual.filesAdded).toEqual(expectedFilesAdded)
     })
+
     afterEach(async () => {
       await deletePublishedDatasetViaApi(testDatasetIds.persistentId)
     })

test/unit/datasets/GetDatasetVersionDiff.test.ts

@@ -1,6 +1,5 @@
 import { ReadError } from '../../../src/core/domain/repositories/ReadError'
 import { IDatasetsRepository } from '../../../src/datasets/domain/repositories/IDatasetsRepository'
-
 import { createDatasetVersionDiff } from '../../testHelpers/datasets/datasetVersionDiffHelper'
 import { GetDatasetVersionDiff } from '../../../src/datasets/domain/useCases/GetDatasetVersionDiff'