Skip to content

bug: Several issues in retrieval.py — dead code, missing BQ timeout, inverted similarity score, stale class name #74

@QuantumByte-01

Description

@QuantumByte-01

Issues in backend/retrieval.py

  • Dead code: qtext = query if ... else query — both branches are identical, never does anything
  • No BQ timeout: .result() blocks indefinitely — use .result(timeout=10)
  • Undocumented negated similarity: -float(dist) is not explained anywhere, confusing for contributors
  • other_links never populated: field exists on RetrievedItem but is always []
  • BQ_LOCATION default mismatch: code defaults to "EU", docstring says "US" — causes BigQuery region errors

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions