Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should deleted and experimental plugins be linted? #792

Open
nexushoratio opened this issue Dec 19, 2024 · 2 comments
Open

Should deleted and experimental plugins be linted? #792

nexushoratio opened this issue Dec 19, 2024 · 2 comments

Comments

@nexushoratio
Copy link
Contributor

While manually playing around with some stuff, I noticed that some non-mainstream plugins are flagged with lint issues.

For example:
eqeqeq:

color = color == 'red' ? 'orange' : 'yellow';

spaced-comment:

marker.bringToFront = function(){}; //TEMP - until the rest of IITC code is changed to take account of non-path markers

I looked for, and could not find, a setting that explicitly disabled those directories.

Granted, I am using an old version of eslint for $REASON, but I was still surprised by a few things.

Maybe a document on how to run eslint from the CLI? I am looking at adding it to post_build in my localbuildsettings.py.

@McBen
Copy link
Contributor

McBen commented Dec 20, 2024

Should deleted and experimental plugins be linted

in fact they should be removed or moved to a experimental branch.
its dead code.

how to run eslint from the CLI

npx eslint <filename>
example: npx eslint ./core/total-conversion-build.js
(replace npx by yarn if you're using yarn package manager)

@nexushoratio
Copy link
Contributor Author

nexushoratio commented Dec 20, 2024

I've been doing eslint <directory>. As in eslint plugins, or more generally eslint .

I take it that is not how others typically run it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants