Remove unsupported args: warn parameter from command / shell module

Signed-off-by: Achim Christ <[email protected]>

Author: Achim Christ

roles/callhome_install/handlers/main.yml

@@ -2,5 +2,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-   warn: false

roles/callhome_install/tasks/zypper/install.yml

@@ -1,17 +1,12 @@
 ---
 - name: install | Disable repo metadata gpg check
   command: "zypper modifyrepo --gpgcheck-allow-unsigned-repo --all"
-  args:
-    warn: false
 
 - name: install | Install GPFS Callhome packages
   zypper:
-   name: "{{ scale_install_all_packages }}"
-   state: present
-   disable_gpg_check: no
+    name: "{{ scale_install_all_packages }}"
+    state: present
+    disable_gpg_check: no
 
 - name: install | Enable repo metadata gpg check
   command: "zypper modifyrepo --default-gpgcheck --all"
-  args:
-    warn: false 
-

roles/core_common/handlers/main.yml

@@ -3,5 +3,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-    warn: false

roles/core_common/tasks/check.yml

@@ -17,10 +17,9 @@
               available in a relative path to the specified directory.
 
         - name: check | Find available scale version
-          shell: rpm -qp "{{ scale_install_directory_pkg_path }}/gpfs.base-*.{{ scale_architecture }}.rpm"
-                 --qf '%{VERSION}.%{RELEASE}\n' | cut -d '.' -f -4
-          args:
-             warn: false
+          shell:
+            rpm -qp "{{ scale_install_directory_pkg_path }}/gpfs.base-*.{{ scale_architecture }}.rpm"
+            --qf '%{VERSION}.%{RELEASE}\n' | cut -d '.' -f -4
           register: scale_gpfsversion
           changed_when: false
 
@@ -42,8 +41,6 @@
 
         - name: check | Find available scale version
           shell: "echo {{ scale_package }} | cut -d '-' -f 2"
-          args:
-           warn: false
           register: scale_se_gpfsversion
           changed_when: false
 
@@ -118,7 +115,7 @@
     - rpm_key:
         state: present
         key: "{{ scale_gpgKey_dest }}/{{ scale_gpg_key_name }}"
-  when: ((ansible_distribution in scale_sles_distribution or ansible_distribution in scale_rhel_distribution)
+  when:
+    ((ansible_distribution in scale_sles_distribution or ansible_distribution in scale_rhel_distribution)
     and scale_enable_gpg_check and scale_version >= "5.0.5.0"
     and scale_install_repository_url is defined)
-

roles/core_install/handlers/main.yml

@@ -3,5 +3,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-    warn: false

roles/core_install/tasks/install_license_repository.yml

@@ -13,16 +13,14 @@
 
 - name: Find license package
   shell:
-   cmd: apt-cache show gpfs.license.*
+    cmd: apt-cache show gpfs.license.*
   register: package_name
   when:
-  - ansible_pkg_mgr == 'apt'
+    - ansible_pkg_mgr == 'apt'
 
 - name: install | Get license package
   shell:
-   cmd: zypper info gpfs.license.* | grep Name | cut -d ':' -f 2 | tr -d '[:space:]'
-  args:
-   warn: false
+    cmd: zypper info gpfs.license.* | grep Name | cut -d ':' -f 2 | tr -d '[:space:]'
   register: package_name_version_zypp
   when:
     - ansible_pkg_mgr == 'zypper'
@@ -46,15 +44,15 @@
 
 - name: install | Find GPFS License package
   set_fact:
-   scale_gpfs_license_package: "{{ package_name.stdout_lines.0[9:] }}"
+    scale_gpfs_license_package: "{{ package_name.stdout_lines.0[9:] }}"
   when:
-  - ansible_pkg_mgr == 'apt'
+    - ansible_pkg_mgr == 'apt'
 
 - name: install | Find GPFS License package
   set_fact:
-   scale_gpfs_license_package: "{{ package_name_version_zypp.stdout }}" 
+    scale_gpfs_license_package: "{{ package_name_version_zypp.stdout }}"
   when:
-  - ansible_pkg_mgr == 'zypper'
+    - ansible_pkg_mgr == 'zypper'
 
 - name: install | Add GPFS license packages to list
   set_fact:
@@ -63,12 +61,12 @@
     - "{{ scale_gpfs_license_package }}"
     - gpfs.adv
     - gpfs.crypto
-  when: 
+  when:
     - '"gpfs.license.std" not in scale_gpfs_license_package'
     - '"gpfs.license.da" not in scale_gpfs_license_package'
 
 - name: install | Add GPFS license packages to list
   set_fact:
     scale_install_license_packages: "{{ scale_gpfs_license_package }}"
-  when: "'gpfs.license.std' in scale_gpfs_license_package or  
-         'gpfs.license.da' in scale_gpfs_license_package"
+  when: "'gpfs.license.std' in scale_gpfs_license_package or
+    'gpfs.license.da' in scale_gpfs_license_package"

roles/core_install/tasks/upgrade.yml

@@ -9,16 +9,12 @@
 
 - name: update | Find current gpfs version
   shell: rpm -q gpfs.base --queryformat '%{VERSION}-%{RELEASE}\n'
-  args:
-    warn: false
   register: scale_current_version_gpfs
   changed_when: false
   failed_when: false
 
 - name: update | Find available version
   shell: rpm -qp "{{ scale_gpfs_path_url }}/gpfs.base-*.{{ scale_architecture }}.rpm" --qf '%{VERSION}-%{RELEASE}\n'
-  args:
-    warn: false
   register: scale_repo_gpfsversion
   when: scale_install_repository_url is undefined
   changed_when: false
@@ -29,7 +25,6 @@
     scale_repo_gpfsversion: "{{ scale_repo_gpfsversion.stdout }}"
   when: scale_install_repository_url is undefined
 
-
 - name: update | Get package version
   yum:
     list: gpfs.base
@@ -40,14 +35,13 @@
     package_name_version: "{{ package_name_version.results|selectattr('yumstate','match','available')|map(attribute='version')|list|first }}"
     package_name_release: "{{ package_name_version.results|selectattr('yumstate','match','available')|map(attribute='release')|list|first }}"
   when:
-     - "'available' in package_name_version.results | map(attribute='yumstate') | list"
+    - "'available' in package_name_version.results | map(attribute='yumstate') | list"
 
 - name: update | Set gpfs package version
   set_fact:
     package_gpfs_version: "{{ package_name_version }}-{{ package_name_release }}"
   when: scale_install_repository_url is defined
 
-
 - name: update | Check if node needs to be updated
   set_fact:
     scale_install_needsupdate: "{{ scale_current_version_gpfs.stdout != package_gpfs_version }}"
@@ -56,11 +50,11 @@
 
 - set_fact:
     scale_vars_update: "{{ ansible_play_hosts|
-                           map('extract', hostvars, 'scale_install_needsupdate')|
-                           list }}"
+      map('extract', hostvars, 'scale_install_needsupdate')|
+      list }}"
   run_once: true
 
-- block:  ## run_once: true
+- block: ## run_once: true
     - name: update | Check if any running node needs to be updated
       vars:
         msg: |-

roles/core_upgrade/handlers/main.yml

@@ -3,5 +3,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-    warn: false

roles/core_upgrade/tasks/install_repository.yml

@@ -6,7 +6,7 @@
 #
 - name: Initialize
   set_fact:
-   is_scale_java_pkg_installed: false
+    is_scale_java_pkg_installed: false
 
 - name: upgrade | Configure GPFS YUM repository
   yum_repository:
@@ -91,32 +91,28 @@
   register: is_gpfsjava_package_installed
   failed_when: no
   changed_when: no
-  args:
-    warn: false
   when: ansible_pkg_mgr == 'yum' or ansible_pkg_mgr == 'dnf' or ansible_pkg_mgr == 'zypper'
 
 - name: upgrade | Set if gpfs java package is installed
   set_fact:
     is_scale_java_pkg_installed: true
   when:
-     - ansible_pkg_mgr == 'yum' or ansible_pkg_mgr == 'dnf' or ansible_pkg_mgr == 'zypper'
-     - is_gpfsjava_package_installed.rc == 0
+    - ansible_pkg_mgr == 'yum' or ansible_pkg_mgr == 'dnf' or ansible_pkg_mgr == 'zypper'
+    - is_gpfsjava_package_installed.rc == 0
 
 - name: upgrade | Check if gpfs java package is installed
   shell: dpkg -l | grep gpfs.java | awk "{print $1}" |  grep ii
   register: is_gpfsjava_apt_package_installed
   failed_when: no
   changed_when: no
-  args:
-    warn: false
   when: ansible_pkg_mgr == 'apt'
 
 - name: upgrade | Set if gpfs java package installed
   set_fact:
     is_scale_java_pkg_installed: true
   when:
-     - ansible_pkg_mgr == 'apt'
-     - is_gpfsjava_apt_package_installed.rc == 0
+    - ansible_pkg_mgr == 'apt'
+    - is_gpfsjava_apt_package_installed.rc == 0
 
 - name: upgrade | Add GPFS java packages to list
   set_fact:

roles/ece_install/handlers/main.yml

@@ -2,5 +2,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-    warn: false

roles/ece_upgrade/handlers/main.yml

@@ -2,5 +2,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-    warn: false

roles/fal_upgrade/tasks/yum/install.yml

@@ -9,8 +9,6 @@
       register: gpfslibrdkafka_installed
       ignore_errors: true
       failed_when: false
-      args:
-        warn: false
 
     - name: upgrade | Set if gpfs librdkafka installed
       set_fact:
@@ -27,8 +25,8 @@
     state: latest
     disable_gpg_check: "{{ scale_disable_gpgcheck }}"
   when:
-     - ansible_pkg_mgr == 'yum'
-     - librdkafka_installed is not defined
+    - ansible_pkg_mgr == 'yum'
+    - librdkafka_installed is not defined
 
 - name: upgrade | Upgrade GPFS file audit logging packages
   yum:
@@ -37,8 +35,8 @@
     update_only: yes
     disable_gpg_check: "{{ scale_disable_gpgcheck }}"
   when:
-     - ansible_pkg_mgr == 'yum'
-     - librdkafka_installed is defined and librdkafka_installed | bool
+    - ansible_pkg_mgr == 'yum'
+    - librdkafka_installed is defined and librdkafka_installed | bool
 
 - name: upgrade | Upgrade GPFS file audit logging packages
   dnf:

roles/hdfs_install/handlers/main.yml

@@ -2,5 +2,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-    warn: false

roles/nfs_install/handlers/main.yml

@@ -2,5 +2,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-    warn: false

roles/nfs_upgrade/handlers/main.yml

@@ -2,5 +2,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-    warn: false

roles/obj_install/handlers/main.yml

@@ -2,5 +2,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-    warn: false

roles/obj_install/tasks/yum/install.yml

@@ -1,22 +1,20 @@
 ---
 - name: install | Install Scale object packages
   yum:
-   name: "{{ scale_install_all_packages }}"
-   state: present
-   disable_gpg_check: "{{ scale_disable_gpgcheck }}"
+    name: "{{ scale_install_all_packages }}"
+    state: present
+    disable_gpg_check: "{{ scale_disable_gpgcheck }}"
   when: inventory_hostname in scale_obj_nodes_list
 
 - name: install | Get installed spectrum-scale-object
   shell: rpm -qa | grep spectrum-scale-object
   register: scale_package_status
   when: inventory_hostname in scale_obj_nodes_list
   ignore_errors: true
-  args:
-    warn: false
 
 - name: install | Check if spectrum-scale-object package is installed
   assert:
     that:
-    - scale_package_status.rc == 0
+      - scale_package_status.rc == 0
     fail_msg: "spectrum-scale-object is not installed on {{ ansible_hostname }}"
   when: inventory_hostname in scale_obj_nodes_list

roles/obj_upgrade/handlers/main.yml

@@ -2,5 +2,3 @@
 # handlers file for node
 - name: yum-clean-metadata
   command: yum clean metadata
-  args:
-    warn: false