fix lint

Author: HugoDF

.gitignore

@@ -82,3 +82,4 @@ typings/
 
 # DynamoDB Local files
 .dynamodb/
+.DS_Store

bin/migrate.js

@@ -22,7 +22,7 @@ new Promise((resolve, reject) => {
         reject(new Error('Command is not a function'));
       }
 
-      set[command](err => {
+      set[command]((err) => {
         if (err) reject(err);
         resolve();
       });
@@ -34,7 +34,7 @@ new Promise((resolve, reject) => {
     // eslint-disable-next-line unicorn/no-process-exit
     process.exit(0);
   })
-  .catch(error => {
+  .catch((error) => {
     console.error(error.stack);
     // eslint-disable-next-line unicorn/no-process-exit
     process.exit(1);

server.js

@@ -9,8 +9,8 @@ const {SESSION_SECRET} = require('./config');
 const app = express();
 const api = require('./src/api');
 
-app.get('/', (req, res) => res.sendStatus(200));
-app.get('/health', (req, res) => res.sendStatus(200));
+app.get('/', (request, response) => response.sendStatus(200));
+app.get('/health', (request, response) => response.sendStatus(200));
 
 app.use(morgan('short'));
 app.use(express.json());

src/api/session.js

@@ -8,40 +8,41 @@ const sessionMiddleware = require('../middleware/session-middleware');
 
 const router = new Router();
 
-router.post('/', async (req, res) => {
+router.post('/', async (request, response) => {
   try {
-    const {email, password} = req.body;
+    const {email, password} = request.body;
+    // eslint-disable-next-line unicorn/no-fn-reference-in-iterator
     const user = await User.find(email);
     if (!user || !(await bcrypt.compare(password, user.password))) {
-      return res.status(403).json({});
+      return response.status(403).json({});
     }
 
     const sessionId = await Session.create(user.id);
-    req.session.id = sessionId;
-    res.status(201).json();
+    request.session.id = sessionId;
+    response.status(201).json();
   } catch (error) {
     console.error(
-      `POST session ({ email: ${req.body.email} }) >> ${error.stack})`
+      `POST session ({ email: ${request.body.email} }) >> ${error.stack})`
     );
-    res.status(500).json();
+    response.status(500).json();
   }
 });
 
-router.get('/', sessionMiddleware, (req, res) => {
-  res.json({userId: req.userId});
+router.get('/', sessionMiddleware, (request, response) => {
+  response.json({userId: request.userId});
 });
 
-router.delete('/', async (req, res) => {
+router.delete('/', async (request, response) => {
   try {
-    if (req.session.id) {
-      await Session.delete(req.session.id);
+    if (request.session.id) {
+      await Session.delete(request.session.id);
     }
 
-    req.session.id = null;
-    res.status(200).json();
+    request.session.id = null;
+    response.status(200).json();
   } catch (error) {
     console.error(`DELETE session >> ${error.stack}`);
-    res.status(500).json();
+    response.status(500).json();
   }
 });
 

src/api/user.js

@@ -3,26 +3,26 @@ const User = require('../persistence/users');
 
 const router = new Router();
 
-router.post('/', async (req, res) => {
+router.post('/', async (request, response) => {
   try {
-    const {email, password} = req.body;
+    const {email, password} = request.body;
     if (!email || !password) {
-      return res
+      return response
         .status(400)
         .json({message: 'email and password must be provided'});
     }
 
     const user = await User.create(email, password);
     if (!user) {
-      return res.status(400).json({message: 'User already exists'});
+      return response.status(400).json({message: 'User already exists'});
     }
 
-    return res.status(200).json(user);
+    return response.status(200).json(user);
   } catch (error) {
     console.error(
-      `createUser({ email: ${req.body.email} }) >> Error: ${error.stack}`
+      `createUser({ email: ${request.body.email} }) >> Error: ${error.stack}`
     );
-    res.status(500).json();
+    response.status(500).json();
   }
 });
 

src/middleware/session-middleware.js

@@ -1,24 +1,25 @@
 const Session = require('../persistence/sessions');
 
-const sessionMiddleware = async (req, res, next) => {
-  if (!req.session.id) {
-    return res.sendStatus(401);
+const sessionMiddleware = async (request, response, next) => {
+  if (!request.session.id) {
+    return response.sendStatus(401);
   }
 
   try {
-    const session = await Session.find(req.session.id);
+    // eslint-disable-next-line unicorn/no-fn-reference-in-iterator
+    const session = await Session.find(request.session.id);
     if (!session) {
-      req.session.id = null;
-      return res.sendStatus(401);
+      request.session.id = null;
+      return response.sendStatus(401);
     }
 
-    req.userId = session.userId;
+    request.userId = session.userId;
     next();
   } catch (error) {
     console.error(
-      `SessionMiddleware(${req.session.id}) >> Error: ${error.stack}`
+      `SessionMiddleware(${request.session.id}) >> Error: ${error.stack}`
     );
-    return res.sendStatus(500);
+    return response.sendStatus(500);
   }
 };
 

src/migrations/1550969025172-authentication.js

@@ -1,6 +1,6 @@
 const db = require('../persistence/db');
 
-module.exports.up = async function(next) {
+module.exports.up = async function (next) {
   const client = await db.connect();
 
   await client.query(`
@@ -26,7 +26,7 @@ module.exports.up = async function(next) {
   next();
 };
 
-module.exports.down = async function(next) {
+module.exports.down = async function (next) {
   const client = await db.connect();
 
   await client.query(`

src/persistence/postgres-state-storage.js

@@ -1,7 +1,7 @@
 const sql = require('sql-template-strings');
 const db = require('./db');
 
-const ensureMigrationsTable = db =>
+const ensureMigrationsTable = (db) =>
   db.query(
     'CREATE TABLE IF NOT EXISTS migrations (id integer PRIMARY KEY, data jsonb NOT NULL)'
   );

src/persistence/sessions.js

@@ -1,5 +1,5 @@
 const sql = require('sql-template-strings');
-const { v4: uuidv4 } = require('uuid');
+const {v4: uuidv4} = require('uuid');
 const db = require('./db');
 
 module.exports = {

src/persistence/users.js

@@ -1,5 +1,5 @@
 const sql = require('sql-template-strings');
-const { v4: uuidv4 } = require('uuid');
+const {v4: uuidv4} = require('uuid');
 const bcrypt = require('bcrypt');
 const db = require('./db');