Specify comparison rules for strings (npgsql#3993)

Closes npgsql#3992

Author: vonzshik

.editorconfig

@@ -52,6 +52,10 @@ csharp_indent_switch_labels = false
 
 # Reliability Rules
 
+[src/Npgsql/**.cs]
+# CA1310: Specify StringComparison for correctness
+dotnet_diagnostic.CA1310.severity = error
+
 # CA2016: Forward the 'CancellationToken' parameter to methods that take one
 dotnet_diagnostic.CA2016.severity = error
 

src/Npgsql/BackendMessages/AuthenticationMessages.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using Npgsql.Internal;
 using Npgsql.Logging;
 using Npgsql.Util;
@@ -143,11 +144,11 @@ internal static AuthenticationSCRAMServerFirstMessage Load(byte[] bytes)
 
             foreach (var part in data.Split(','))
             {
-                if (part.StartsWith("r="))
+                if (part.StartsWith("r=", StringComparison.Ordinal))
                     nonce = part.Substring(2);
-                else if (part.StartsWith("s="))
+                else if (part.StartsWith("s=", StringComparison.Ordinal))
                     salt = part.Substring(2);
-                else if (part.StartsWith("i="))
+                else if (part.StartsWith("i=", StringComparison.Ordinal))
                     iteration = int.Parse(part.Substring(2));
                 else
                     Log.Debug("Unknown part in SCRAM server-first message:" + part);
@@ -196,7 +197,7 @@ internal static AuthenticationSCRAMServerFinalMessage Load(byte[] bytes)
 
             foreach (var part in data.Split(','))
             {
-                if (part.StartsWith("v="))
+                if (part.StartsWith("v=", StringComparison.Ordinal))
                     serverSignature = part.Substring(2);
                 else
                     Log.Debug("Unknown part in SCRAM server-first message:" + part);

src/Npgsql/Internal/NpgsqlConnector.Auth.cs

@@ -168,7 +168,7 @@ async Task AuthenticateSASL(List<string> mechanisms, string username, bool async
             if (saslContinueMsg.AuthRequestType != AuthenticationRequestType.AuthenticationSASLContinue)
                 throw new NpgsqlException("[SASL] AuthenticationSASLContinue message expected");
             var firstServerMsg = AuthenticationSCRAMServerFirstMessage.Load(saslContinueMsg.Payload);
-            if (!firstServerMsg.Nonce.StartsWith(clientNonce))
+            if (!firstServerMsg.Nonce.StartsWith(clientNonce, StringComparison.Ordinal))
                 throw new NpgsqlException("[SCRAM] Malformed SCRAMServerFirst message: server nonce doesn't start with client nonce");
 
             var saltBytes = Convert.FromBase64String(firstServerMsg.Salt);

src/Npgsql/NpgsqlCommandBuilder.cs

@@ -303,10 +303,10 @@ public override string UnquoteIdentifier(string quotedIdentifier)
 
             var unquotedIdentifier = quotedIdentifier.Trim().Replace(QuotePrefix + QuotePrefix, QuotePrefix);
 
-            if (unquotedIdentifier.StartsWith(QuotePrefix))
+            if (unquotedIdentifier.StartsWith(QuotePrefix, StringComparison.Ordinal))
                 unquotedIdentifier = unquotedIdentifier.Remove(0, 1);
 
-            if (unquotedIdentifier.EndsWith(QuoteSuffix))
+            if (unquotedIdentifier.EndsWith(QuoteSuffix, StringComparison.Ordinal))
                 unquotedIdentifier = unquotedIdentifier.Remove(unquotedIdentifier.Length - 1, 1);
 
             return unquotedIdentifier;

src/Npgsql/NpgsqlConnection.cs

@@ -1146,7 +1146,7 @@ async Task<NpgsqlBinaryImporter> BeginBinaryImport(string copyFromCommand, bool
         {
             if (copyFromCommand == null)
                 throw new ArgumentNullException(nameof(copyFromCommand));
-            if (!copyFromCommand.TrimStart().ToUpper().StartsWith("COPY"))
+            if (!copyFromCommand.TrimStart().ToUpper().StartsWith("COPY", StringComparison.Ordinal))
                 throw new ArgumentException("Must contain a COPY FROM STDIN command!", nameof(copyFromCommand));
 
             CheckReady();
@@ -1200,7 +1200,7 @@ async Task<NpgsqlBinaryExporter> BeginBinaryExport(string copyToCommand, bool as
         {
             if (copyToCommand == null)
                 throw new ArgumentNullException(nameof(copyToCommand));
-            if (!copyToCommand.TrimStart().ToUpper().StartsWith("COPY"))
+            if (!copyToCommand.TrimStart().ToUpper().StartsWith("COPY", StringComparison.Ordinal))
                 throw new ArgumentException("Must contain a COPY TO STDOUT command!", nameof(copyToCommand));
 
             CheckReady();
@@ -1260,7 +1260,7 @@ async Task<TextWriter> BeginTextImport(string copyFromCommand, bool async, Cance
         {
             if (copyFromCommand == null)
                 throw new ArgumentNullException(nameof(copyFromCommand));
-            if (!copyFromCommand.TrimStart().ToUpper().StartsWith("COPY"))
+            if (!copyFromCommand.TrimStart().ToUpper().StartsWith("COPY", StringComparison.Ordinal))
                 throw new ArgumentException("Must contain a COPY FROM STDIN command!", nameof(copyFromCommand));
 
             CheckReady();
@@ -1321,7 +1321,7 @@ async Task<TextReader> BeginTextExport(string copyToCommand, bool async, Cancell
         {
             if (copyToCommand == null)
                 throw new ArgumentNullException(nameof(copyToCommand));
-            if (!copyToCommand.TrimStart().ToUpper().StartsWith("COPY"))
+            if (!copyToCommand.TrimStart().ToUpper().StartsWith("COPY", StringComparison.Ordinal))
                 throw new ArgumentException("Must contain a COPY TO STDOUT command!", nameof(copyToCommand));
 
             CheckReady();
@@ -1382,7 +1382,7 @@ async Task<NpgsqlRawCopyStream> BeginRawBinaryCopy(string copyCommand, bool asyn
         {
             if (copyCommand == null)
                 throw new ArgumentNullException(nameof(copyCommand));
-            if (!copyCommand.TrimStart().ToUpper().StartsWith("COPY"))
+            if (!copyCommand.TrimStart().ToUpper().StartsWith("COPY", StringComparison.Ordinal))
                 throw new ArgumentException("Must contain a COPY TO STDOUT OR COPY FROM STDIN command!", nameof(copyCommand));
 
             CheckReady();

src/Npgsql/NpgsqlTypes/NpgsqlTsVector.cs

@@ -29,7 +29,7 @@ internal NpgsqlTsVector(List<Lexeme> lexemes, bool noCheck = false)
 
             // Culture-specific comparisons doesn't really matter for the backend. It's sorting on its own if it detects an unsorted collection.
             // Only when a .NET user wants to print the sort order.
-            _lexemes.Sort((a, b) => a.Text.CompareTo(b.Text));
+            _lexemes.Sort((a, b) => string.Compare(a.Text, b.Text, StringComparison.CurrentCulture));
 
             var res = 0;
             var pos = 1;

src/Npgsql/PostgresErrorCodes.cs

@@ -1,5 +1,6 @@
 #pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
 
+using System;
 using System.Linq;
 
 namespace Npgsql
@@ -476,6 +477,6 @@ public static class PostgresErrorCodes
         };
 
         internal static bool IsCriticalFailure(PostgresException e)
-            => CriticalFailureCodes.Any(x => e.SqlState.StartsWith(x));
+            => CriticalFailureCodes.Any(x => e.SqlState.StartsWith(x, StringComparison.Ordinal));
     }
 }

src/Npgsql/Schema/DbColumnSchemaGenerator.cs

@@ -218,7 +218,7 @@ NpgsqlDbColumn LoadColumnDefinition(NpgsqlDataReader reader, NpgsqlDatabaseInfo
 
             column.IsAutoIncrement =
                 !oldQueryMode && reader.GetBoolean(reader.GetOrdinal("isidentity")) ||
-                column.DefaultValue != null && column.DefaultValue.StartsWith("nextval(");
+                column.DefaultValue != null && column.DefaultValue.StartsWith("nextval(", StringComparison.Ordinal);
 
             ColumnPostConfig(column, reader.GetInt32(reader.GetOrdinal("typmod")));