Skip to content

Commit 2acf396

Browse files
committed
🐛 Fixes status check dot in edit mode (Lissy93#301)
1 parent e9344fc commit 2acf396

File tree

1 file changed

+19
-3
lines changed

1 file changed

+19
-3
lines changed

src/components/LinkItems/Item.vue

Lines changed: 19 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
@contextmenu.prevent
66
:href="hyperLinkHref"
77
:target="anchorTarget"
8-
:class="`item ${!icon? 'short': ''} size-${itemSize} ${isAddNew ? 'add-new' : ''}`"
8+
:class="`item ${makeClassList}`"
99
v-tooltip="getTooltipOptions()"
1010
rel="noopener noreferrer" tabindex="0"
1111
:id="`link-${id}`"
@@ -30,8 +30,10 @@
3030
:statusSuccess="statusResponse ? statusResponse.successStatus : undefined"
3131
:statusText="statusResponse ? statusResponse.message : undefined"
3232
/>
33+
<!-- Edit icon (displayed only when in edit mode) -->
3334
<EditModeIcon v-if="isEditMode" class="edit-mode-item" @click="openItemSettings()" />
3435
</a>
36+
<!-- Right-click context menu -->
3537
<ContextMenu
3638
:show="contextMenuOpen && !isAddNew"
3739
v-click-outside="closeContextMenu"
@@ -43,6 +45,7 @@
4345
@openMoveItemMenu="openMoveItemMenu"
4446
@openDeleteItem="openDeleteItem"
4547
/>
48+
<!-- Edit and move item menu modals -->
4649
<MoveItemTo v-if="isEditMode" :itemId="id" />
4750
<EditItem v-if="editMenuOpen" :itemId="id"
4851
@closeEditMenu="closeEditMenu"
@@ -114,6 +117,14 @@ export default {
114117
accumulatedTarget() {
115118
return this.target || this.appConfig.defaultOpeningMethod || defaultOpeningMethod;
116119
},
120+
/* Based on item props, adjust class names */
121+
makeClassList() {
122+
const {
123+
icon, itemSize, isAddNew, isEditMode,
124+
} = this;
125+
return `size-${itemSize} ${!icon ? 'short' : ''} `
126+
+ `${isAddNew ? 'add-new' : ''} ${isEditMode ? 'is-edit-mode' : ''}`;
127+
},
117128
/* Convert config target value, into HTML anchor target attribute */
118129
anchorTarget() {
119130
if (this.isEditMode) return '_self';
@@ -521,13 +532,18 @@ export default {
521532
}
522533
}
523534
535+
/* Adjust positioning of status indicator, when in edit mode */
536+
a.item.is-edit-mode {
537+
&.size-medium .status-indicator { top: 1rem; }
538+
&.size-small .status-indicator { right: 1rem; }
539+
&.size-large .status-indicator { top: 1.5rem; }
540+
}
541+
524542
</style>
525543

526544
<!-- An un-scoped style tag, since tooltip is outside this DOM tree -->
527545
<style lang="scss">
528-
529546
.disabled-link {
530547
pointer-events: none;
531548
}
532-
533549
</style>

0 commit comments

Comments
 (0)