Fix test case incompatibilities, clean up ignores

Author: bennothommo

.gitignore

@@ -1,24 +1,32 @@
-/bootstrap/compiled.php
+# Composer ignores
 /vendor
 composer.phar
-.DS_Store
-.idea
+composer.lock
+
+# Framework ignores
 .env
 .env.*.php
 .env.php
+selenium.php
+/bootstrap/compiled.php
+.phpunit.result.cache
+
+# Hosting ignores
 php_errors.log
 nginx-error.log
 nginx-access.log
 nginx-ssl.access.log
 nginx-ssl.error.log
-php-errors.log
 sftp-config.json
 .ftpconfig
-selenium.php
-composer.lock
-package-lock.json
-/node_modules
-_ide_helper.php
 
-# for netbeans
+# Editor ignores
 nbproject
+.idea
+.vscode
+_ide_helper.php
+
+# Other ignores
+.DS_Store
+package-lock.json
+/node_modules

phpunit.xml phpunit.xml.dist

@@ -1,14 +1,14 @@
 <?xml version="1.0" encoding="UTF-8"?>
-<phpunit backupGlobals="false"
-         backupStaticAttributes="false"
-         bootstrap="tests/bootstrap.php"
-         colors="true"
-         convertErrorsToExceptions="true"
-         convertNoticesToExceptions="true"
-         convertWarningsToExceptions="true"
-         processIsolation="false"
-         stopOnFailure="false"
-         syntaxCheck="false"
+<phpunit
+    backupGlobals="false"
+    backupStaticAttributes="false"
+    bootstrap="tests/bootstrap.php"
+    colors="true"
+    convertErrorsToExceptions="true"
+    convertNoticesToExceptions="true"
+    convertWarningsToExceptions="true"
+    processIsolation="false"
+    stopOnFailure="false"
 >
     <testsuites>
         <testsuite name="October CMS Test Suite">

tests/UiTestCase.php

@@ -1,6 +1,6 @@
 <?php
 
-class UiTestCase extends PHPUnit_Extensions_SeleniumTestCase
+class UiTestCase extends PHPUnit\Extensions\Selenium2TestCase
 {
     protected function setUp()
     {

tests/unit/backend/classes/AuthManagerTest.php

@@ -4,7 +4,7 @@
 
 class AuthManagerTest extends TestCase
 {
-    public function setUp()
+    public function setUp(): void
     {
         $this->createApplication();
 
@@ -23,7 +23,7 @@ public function setUp()
         ]);
     }
 
-    public function tearDown()
+    public function tearDown(): void
     {
         AuthManager::forgetInstance();
     }

tests/unit/system/classes/AutoDatasourceTest.php

@@ -30,7 +30,7 @@ class AutoDatasourceTest extends PluginTestCase
      */
     public $datasource;
 
-    public function setUp()
+    public function setUp(): void
     {
         parent::setUp();
 
@@ -73,7 +73,7 @@ public function setUp()
         ]);
     }
 
-    public function tearDown()
+    public function tearDown(): void
     {
         foreach ($this->fixtures as $fixture) {
             $fixture->delete();