Skip to content

Commit 868208d

Browse files
committed
Review remarks
1 parent c264bae commit 868208d

File tree

2 files changed

+12
-5
lines changed

2 files changed

+12
-5
lines changed

.github/workflows/auto-release.yml

+10-4
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@ jobs:
2020
- if: steps.check.outputs.changed == 'true'
2121
id: is_preview
2222
run: |
23-
IFS=', ' read -r -a array <<< "${{ steps.check.outputs.version }}"
23+
IFS='.' read -r -a array <<< "${{ steps.check.outputs.version }}"
2424
if [ $((array[1]%2)) -eq 0 ];
2525
then
26-
echo ::set-output name=is_preview"false"
26+
echo is_preview="false" >> "$GITHUB_OUTPUT"
2727
else
28-
echo ::set-output name=is_preview"true"
28+
echo is_preview="true" >> "$GITHUB_OUTPUT"
2929
fi
3030
shell: bash
3131
- if: steps.check.outputs.changed == 'true'
@@ -45,6 +45,7 @@ jobs:
4545
artifacts: "vscode-clangd-*.vsix"
4646
tag: ${{ steps.check.outputs.version }}
4747
commit: ${{ steps.check.outputs.commit }}
48+
prerelease: ${{ steps.is_preview.outputs.is_preview }}
4849
token: ${{ secrets.GITHUB_TOKEN }}
4950
- name: publish to VSCode Marketplace
5051
if: steps.check.outputs.changed == 'true' && steps.is_preview.outputs.is_preview == 'false'
@@ -55,7 +56,12 @@ jobs:
5556
if: steps.check.outputs.changed == 'true' && steps.is_preview.outputs.is_preview == 'true'
5657
run: npm run publish-pre-release -- -p "${{ secrets.VSCODE_MARKETPLACE_TOKEN }}"
5758
- name: publish to OpenVSX
58-
if: steps.check.outputs.changed == 'true'
59+
if: steps.check.outputs.changed == 'true' && steps.is_preview.outputs.is_preview == 'false'
5960
# The token will expire. Regenerate it at:
6061
# https://open-vsx.org/user-settings/tokens
6162
run: npm run publish-openvsx -- -p "${{ secrets.OPENVSX_TOKEN }}"
63+
- name: publish to OpenVSX
64+
if: steps.check.outputs.changed == 'true' && steps.is_preview.outputs.is_preview == 'true'
65+
# The token will expire. Regenerate it at:
66+
# https://open-vsx.org/user-settings/tokens
67+
run: npm run publish-openvsx-pre-release -- -p "${{ secrets.OPENVSX_TOKEN }}"

package.json

+2-1
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,10 @@
4343
"test": "npm run test-compile && node ./out/test/index.js",
4444
"package": "vsce package --baseImagesUrl https://raw.githubusercontent.com/clangd/vscode-clangd/master/",
4545
"publish": "vsce publish --baseImagesUrl https://raw.githubusercontent.com/clangd/vscode-clangd/master/",
46+
"publish-openvsx": "ovsx publish --baseImagesUrl https://raw.githubusercontent.com/clangd/vscode-clangd/master/",
4647
"package-pre-release": "vsce package --pre-release --baseImagesUrl https://raw.githubusercontent.com/clangd/vscode-clangd/master/",
4748
"publish-pre-release": "vsce publish --pre-release --baseImagesUrl https://raw.githubusercontent.com/clangd/vscode-clangd/master/",
48-
"publish-openvsx": "ovsx publish --baseImagesUrl https://raw.githubusercontent.com/clangd/vscode-clangd/master/",
49+
"publish-openvsx-pre-release": "ovsx publish --preRelease --baseImagesUrl https://raw.githubusercontent.com/clangd/vscode-clangd/master/",
4950
"git-clang-format": "git-clang-format --extensions=ts"
5051
},
5152
"dependencies": {

0 commit comments

Comments
 (0)