Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question-Answering incorrect service name #145

Open
fideltak opened this issue Feb 6, 2024 · 0 comments
Open

Question-Answering incorrect service name #145

fideltak opened this issue Feb 6, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@fideltak
Copy link

fideltak commented Feb 6, 2024

Description & Reproduction

First of all, thank you for great demo contents.
In new UA 1.3, Kserve creates service like service/vectorstore-predictor.

vectorstore-predictor                 ExternalName   <none>           istio-ingressgateway.istio-system.svc.cluster.local   80/TCP                                               11m
vectorstore-predictor-00001           ClusterIP      10.97.188.94     <none>                                                80/TCP,443/TCP                                       11m
vectorstore-predictor-00001-private   ClusterIP      10.101.254.37    <none>                                                80/TCP,443/TCP,9090/TCP,9091/TCP,8022/TCP,8012/TCP   11m

However jupyter notebook is described as vectorstore-predictor-default.
And transformer code is hardcoded as {deployment_name}-predictor-default.

It seems -default prefix has been removed from kserve spec.
kserve/kserve#1397

Expected behavior

  • Corrent service path in Jupyter Notebook
  • Correct service path in codes
    • Or change app architecture to enable to set service path by env values.

https://github.com/HPEEzmeral/ezua-tutorials/blob/release-1.2.0/demos/question-answering/dockerfiles/transformer/src/model.py#L43C17-L43C52

System Info

  • EzUA: 1.3
@fideltak fideltak added the bug Something isn't working label Feb 6, 2024
@ask664 ask664 assigned dpoulopoulos and unassigned dpoulopoulos Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants