Refactor Amount Set Widget on ME Parts #3485
Draft
+62
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YoungOnionMC
added
type: bugfix
jurrejelle
reviewed
Jul 19, 2025
Contributor
jurrejelle
left a comment
jurrejelle
left a comment
There was a problem hiding this comment.
I have never done UI bs so ideally someone else reviews it too, but apart from the tiny code cleanness nitpick, LGTM
| if (this.index < 0) { | ||
| return "0"; | ||
| public long getAmount() { | ||
| if (index < 0) { |
Contributor
There was a problem hiding this comment.
very tiny nitpick, either use this.index both here and in setAmount, or just index in both <3
screret
suggested changes
Jul 20, 2025
| this.amountSetWidget.setVisible(false); | ||
| this.amountSetWidget.getAmountText().setVisible(false); | ||
| init(); | ||
| var asw = new AmountSetWidget(15, -53, this); |
Contributor
There was a problem hiding this comment.
why not just do this.amountSetWidget = ... here?
Comment on lines
+60
to
+62
| amountSetWidget.setSlotIndexClient(slotIndex); | ||
| amountSetWidget.setVisible(true); | ||
| amountSetWidget.getAmountText().setVisible(true); |
Contributor
There was a problem hiding this comment.
why remove the this. from all of these?
screret
suggested changes
Jul 20, 2025
| import it.unimi.dsi.fastutil.ints.Int2ObjectOpenHashMap; | ||
| import lombok.Getter; | ||
|
|
||
| import java.awt.*; |
Contributor
There was a problem hiding this comment.
hold up, what AWT class did you import? we can't use those because JREs don't have AWT by default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
cleans up the amount set widget for ae parts
Implementation Details
use a LongInputWidget instead of string and sanitization, use an actual background and label widgets instead of hard coding the amount text, shift around the widget grouping so its accessable
Outcome
easier to set the amount on all ae parts