Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using the characters ( and ) in the font name will generate an invalid CSS Example #1335

Open
jakejackson1 opened this issue May 10, 2022 · 0 comments
Labels
Milestone

Comments

@jakejackson1
Copy link
Member

jakejackson1 commented May 10, 2022

Description
If adding a new font via GPDFAPI::add_font() and it includes the character ( or ) the developer template sample will not display with the correct reference name.

Step To Reproduce
Steps to reproduce the behavior:

  1. Add a font with GPDFAPI::add_font()
  2. Open the Font Manager
  3. Select one of the fonts
  4. Open the developer code sample in the right pane

Expected behavior
The font family reference is correct

Screenshots
Screen Shot 2022-05-10 at 10 10 06 am

Additional context
It isn't possible to get into this state through the UI as we prevent non-alpha numeric characters in the font name. Let's allow this character in the font name but strip it when generating the font key.

@jakejackson1 jakejackson1 added this to the 6.x milestone May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant