Skip to content

Commit 02ad120

Browse files
chore: move CallLabels to core (#9746)
1 parent ca5e814 commit 02ad120

File tree

11 files changed

+15
-13
lines changed

11 files changed

+15
-13
lines changed

bigtable/bigtable-proxy/src/main/java/com/google/cloud/bigtable/examples/proxy/channelpool/DataChannel.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import com.google.bigtable.v2.BigtableGrpc;
2020
import com.google.bigtable.v2.PingAndWarmRequest;
2121
import com.google.bigtable.v2.PingAndWarmResponse;
22-
import com.google.cloud.bigtable.examples.proxy.metrics.CallLabels;
22+
import com.google.cloud.bigtable.examples.proxy.core.CallLabels;
2323
import com.google.cloud.bigtable.examples.proxy.metrics.Metrics;
2424
import com.google.cloud.bigtable.examples.proxy.metrics.Tracer;
2525
import com.google.common.util.concurrent.ListenableFuture;

bigtable/bigtable-proxy/src/main/java/com/google/cloud/bigtable/examples/proxy/channelpool/ResourceCollector.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
package com.google.cloud.bigtable.examples.proxy.channelpool;
1818

1919
import com.google.bigtable.v2.PingAndWarmRequest;
20-
import com.google.cloud.bigtable.examples.proxy.metrics.CallLabels;
20+
import com.google.cloud.bigtable.examples.proxy.core.CallLabels;
2121
import com.google.common.cache.Cache;
2222
import com.google.common.cache.CacheBuilder;
2323
import com.google.common.collect.ImmutableList;

bigtable/bigtable-proxy/src/main/java/com/google/cloud/bigtable/examples/proxy/commands/Verify.java

-2
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
import io.opentelemetry.sdk.metrics.internal.data.ImmutableLongPointData;
5959
import io.opentelemetry.sdk.metrics.internal.data.ImmutableMetricData;
6060
import io.opentelemetry.sdk.resources.Resource;
61-
import java.io.IOException;
6261
import java.time.Duration;
6362
import java.time.Instant;
6463
import java.time.temporal.ChronoUnit;
@@ -190,7 +189,6 @@ void checkMetrics(Credentials creds) {
190189
Instant end = Instant.now().truncatedTo(ChronoUnit.MINUTES);
191190
Instant start = end.minus(Duration.ofMinutes(1));
192191

193-
194192
GCPResourceProvider resourceProvider = new GCPResourceProvider();
195193
Resource resource = Resource.create(resourceProvider.getAttributes());
196194

+2-1
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,10 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.google.cloud.bigtable.examples.proxy.metrics;
17+
package com.google.cloud.bigtable.examples.proxy.core;
1818

1919
import com.google.auto.value.AutoValue;
20+
import com.google.cloud.bigtable.examples.proxy.metrics.MetricsImpl;
2021
import io.grpc.Metadata;
2122
import io.grpc.Metadata.Key;
2223
import io.grpc.MethodDescriptor;

bigtable/bigtable-proxy/src/main/java/com/google/cloud/bigtable/examples/proxy/core/ProxyHandler.java

-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616

1717
package com.google.cloud.bigtable.examples.proxy.core;
1818

19-
import com.google.cloud.bigtable.examples.proxy.metrics.CallLabels;
2019
import com.google.cloud.bigtable.examples.proxy.metrics.Metrics;
2120
import com.google.cloud.bigtable.examples.proxy.metrics.Tracer;
2221
import io.grpc.CallCredentials;

bigtable/bigtable-proxy/src/main/java/com/google/cloud/bigtable/examples/proxy/metrics/Metrics.java

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.google.cloud.bigtable.examples.proxy.metrics;
1818

19+
import com.google.cloud.bigtable.examples.proxy.core.CallLabels;
1920
import io.grpc.Status;
2021
import java.time.Duration;
2122

bigtable/bigtable-proxy/src/main/java/com/google/cloud/bigtable/examples/proxy/metrics/MetricsImpl.java

+6-5
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717
package com.google.cloud.bigtable.examples.proxy.metrics;
1818

1919
import com.google.auth.Credentials;
20+
import com.google.cloud.bigtable.examples.proxy.core.CallLabels;
2021
import com.google.cloud.opentelemetry.metric.GoogleCloudMetricExporter;
2122
import com.google.cloud.opentelemetry.metric.MetricConfiguration;
2223
import io.grpc.Status;
@@ -45,11 +46,11 @@ public class MetricsImpl implements Closeable, Metrics {
4546

4647
public static final String METRIC_PREFIX = "bigtableproxy.";
4748

48-
static final AttributeKey<String> API_CLIENT_KEY = AttributeKey.stringKey("api_client");
49-
static final AttributeKey<String> RESOURCE_KEY = AttributeKey.stringKey("resource");
50-
static final AttributeKey<String> APP_PROFILE_KEY = AttributeKey.stringKey("app_profile");
51-
static final AttributeKey<String> METHOD_KEY = AttributeKey.stringKey("method");
52-
static final AttributeKey<String> STATUS_KEY = AttributeKey.stringKey("status");
49+
public static final AttributeKey<String> API_CLIENT_KEY = AttributeKey.stringKey("api_client");
50+
public static final AttributeKey<String> RESOURCE_KEY = AttributeKey.stringKey("resource");
51+
public static final AttributeKey<String> APP_PROFILE_KEY = AttributeKey.stringKey("app_profile");
52+
public static final AttributeKey<String> METHOD_KEY = AttributeKey.stringKey("method");
53+
public static final AttributeKey<String> STATUS_KEY = AttributeKey.stringKey("status");
5354

5455
public static final String METRIC_PRESENCE_NAME = METRIC_PREFIX + "presence";
5556
public static final String METRIC_PRESENCE_DESC = "Number of proxy processes";

bigtable/bigtable-proxy/src/main/java/com/google/cloud/bigtable/examples/proxy/metrics/NoopMetrics.java

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.google.cloud.bigtable.examples.proxy.metrics;
1818

19+
import com.google.cloud.bigtable.examples.proxy.core.CallLabels;
1920
import io.grpc.Status;
2021
import java.time.Duration;
2122

bigtable/bigtable-proxy/src/main/java/com/google/cloud/bigtable/examples/proxy/metrics/Tracer.java

+1
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@
1616

1717
package com.google.cloud.bigtable.examples.proxy.metrics;
1818

19+
import com.google.cloud.bigtable.examples.proxy.core.CallLabels;
1920
import com.google.common.base.Stopwatch;
2021
import io.grpc.CallOptions;
2122
import io.grpc.CallOptions.Key;

bigtable/bigtable-proxy/src/test/java/com/google/cloud/bigtable/examples/proxy/commands/ServeMetricsTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@
2929
import com.google.bigtable.v2.BigtableGrpc.BigtableImplBase;
3030
import com.google.bigtable.v2.CheckAndMutateRowRequest;
3131
import com.google.bigtable.v2.CheckAndMutateRowResponse;
32-
import com.google.cloud.bigtable.examples.proxy.metrics.CallLabels;
32+
import com.google.cloud.bigtable.examples.proxy.core.CallLabels;
3333
import com.google.cloud.bigtable.examples.proxy.metrics.Metrics;
3434
import com.google.common.collect.Lists;
3535
import io.grpc.CallOptions;
+1-1
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
* limitations under the License.
1515
*/
1616

17-
package com.google.cloud.bigtable.examples.proxy.metrics;
17+
package com.google.cloud.bigtable.examples.proxy.core;
1818

1919
import static com.google.common.truth.Truth.assertAbout;
2020
import static com.google.common.truth.Truth.assertThat;

0 commit comments

Comments
 (0)