-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(genai): add thinking samples #3275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat(genai): add thinking samples #3275
Conversation
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @jdomingr, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the GenAI SDK's sample collection by introducing new examples focused on the model's 'thinking' functionalities. These additions provide developers with practical demonstrations of how to interact with advanced content generation features, such as managing the model's internal reasoning budget and accessing its step-by-step thought process, thereby enriching the SDK's educational resources and guiding users in leveraging these powerful capabilities. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new samples demonstrating the 'thinking' feature of the GenAI SDK. The overall structure is good, but I've identified some critical issues related to unsafe access of API responses across all new samples. This could lead to runtime exceptions if the model returns no content. I have provided suggestions to add robust checks for these scenarios. Additionally, I've recommended a correction for the ThinkingIncludeThoughtsWithTxt sample to ensure its logic for handling and returning response data is correct and consistent with its purpose.
Add samples for thinking:
All local tests have passed