Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed obsolete 'mesh_id' label #260

Merged
merged 2 commits into from
Feb 27, 2024
Merged

Conversation

jbrook
Copy link
Collaborator

@jbrook jbrook commented Feb 7, 2024

Background

Removed the mesh_id label because it is no longer required when installing Anthos Service mesh using the Fleet API. Previously it was needed to consolidate telemetry from multiple clusters in the UI.

Testing Procedure

terraform apply - tested cluster and mesh with test apps - verfiied telemetry is correctly displayed in UI.

@jbrook jbrook requested a review from a team as a code owner February 7, 2024 12:45
Copy link
Member

@bourgeoisor bourgeoisor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, lemme know if you need me to merge this

@jbrook jbrook merged commit ce39943 into GoogleCloudPlatform:main Feb 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants